Tarantool development patches archive
 help / color / mirror / Atom feed
* [Tarantool-patches] [PATCH v8 00/14] Fix luacheck warnings in test/sql and test/sql-tap
@ 2021-01-21 12:49 Sergey Bronnikov via Tarantool-patches
  2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 01/14] test: fix luacheck warnings in test/sql Sergey Bronnikov via Tarantool-patches
                   ` (15 more replies)
  0 siblings, 16 replies; 47+ messages in thread
From: Sergey Bronnikov via Tarantool-patches @ 2021-01-21 12:49 UTC (permalink / raw)
  To: tarantool-patches, v.shpilevoy

From: Sergey Bronnikov <sergeyb@tarantool.org>

Changelog v8:

- re-made patches for sql-tap suite
- removed fixes suppressed globally in .luacheckrc (like upvalue redefinitions)
- splitted huge patch to a number of patches per warning
- rebased to a master branch

Changelog v7:

- fixed warnings in a new code
- rebased to master branch

Changelog v6:

- splitted patch in test/ for patches per sub-directory
- adjusted suppressions in .luacheckrc
- fixed formatting issues in .luacheckrc

Note that a number of tests in sql-tap are broken (see suite.ini) and luacheck
fixes cannot be verified with running tests.

Gitlab CI: https://gitlab.com/tarantool/tarantool/-/pipelines/244912620
Branch: ligurio/gh-5463-luacheck-warnings-test-sql
Issues:
  - https://github.com/tarantool/tarantool/issues/5464
  - https://github.com/tarantool/tarantool/issues/5463
  - https://github.com/tarantool/tarantool/issues/5741

Sergey Bronnikov (14):
  test: fix luacheck warnings in test/sql
  test: remove functions to open and close SQL connection
  test: fix luacheck warnings W113 in test/sql-tap
  test: fix luacheck warnings W211 in test/sql-tap
  test: fix luacheck warnings W212 in test/sql-tap
  test: fix laucheck warnings W213 in test/sql-tap
  test: fix luacheck warnings W231 in test/sql-tap
  test: fix luacheck warnings W311 in test/sql-tap
  test: fix luacheck warnings W511 in test/sql-tap
  test: fix luacheck warnings W512 in test/sql-tap
  test: fix luacheck warnings W542 in test/sql-tap
  test: fix luacheck warnings W612, W613, W614 in test/sql-tap
  test: fix luacheck warnings W621 in test/sql-tap
  luacheck: add issues for suppressed warnings

 .luacheckrc                                   |  65 ++++----
 test/sql-tap/aggnested.test.lua               |   9 +-
 test/sql-tap/alias.test.lua                   |   4 +-
 test/sql-tap/alter.test.lua                   |   2 +-
 test/sql-tap/analyze1.test.lua                |   4 +-
 test/sql-tap/analyze3.test.lua                |  54 +++----
 test/sql-tap/analyze4.test.lua                |   6 +-
 test/sql-tap/analyze5.test.lua                |  22 +--
 test/sql-tap/analyze6.test.lua                |   2 -
 test/sql-tap/analyze7.test.lua                |  14 +-
 test/sql-tap/analyze8.test.lua                |  10 +-
 test/sql-tap/analyze9.test.lua                | 120 +++++++-------
 test/sql-tap/analyzeC.test.lua                |   3 -
 test/sql-tap/analyzeD.test.lua                |  24 ++-
 test/sql-tap/analyzeE.test.lua                |   2 -
 test/sql-tap/analyzeF.test.lua                |   6 +-
 test/sql-tap/atof1.test.lua                   |   2 +-
 test/sql-tap/autoinc.test.lua                 |   4 +-
 test/sql-tap/autoindex4.test.lua              |   6 +-
 test/sql-tap/badutf1.test.lua                 |  10 +-
 test/sql-tap/between.test.lua                 |   2 +-
 test/sql-tap/check.test.lua                   |   4 +-
 test/sql-tap/colname.test.lua                 |  10 +-
 test/sql-tap/contrib01.test.lua               |   4 +-
 test/sql-tap/count.test.lua                   |   1 -
 test/sql-tap/date.test.lua                    |   8 +-
 test/sql-tap/default.test.lua                 |  12 +-
 test/sql-tap/delete3.test.lua                 |   2 +-
 test/sql-tap/delete4.test.lua                 |  16 +-
 test/sql-tap/distinct.test.lua                |   7 +-
 test/sql-tap/e_delete.test.lua                |   2 +-
 test/sql-tap/e_expr.test.lua                  |  52 ++----
 test/sql-tap/e_select1.test.lua               |   8 +-
 test/sql-tap/eqp.test.lua                     |  54 +++----
 test/sql-tap/func.test.lua                    |  11 +-
 test/sql-tap/func5.test.lua                   |   2 +-
 test/sql-tap/gh-2723-concurrency.test.lua     |   8 +-
 .../gh-3083-ephemeral-unref-tuples.test.lua   |   2 +-
 .../gh-3332-tuple-format-leak.test.lua        |   2 +-
 .../gh2127-indentifier-max-length.test.lua    |  10 +-
 .../gh2250-trigger-chain-limit.test.lua       |   1 -
 test/sql-tap/icu.test.lua                     |   8 +-
 test/sql-tap/identifier-characters.test.lua   |   2 +-
 test/sql-tap/in1.test.lua                     |  48 +++---
 test/sql-tap/in2.test.lua                     |  12 +-
 test/sql-tap/in3.test.lua                     |  36 ++---
 test/sql-tap/in4.test.lua                     |  56 +++----
 test/sql-tap/in5.test.lua                     |   1 -
 test/sql-tap/index1.test.lua                  |   5 +-
 test/sql-tap/index3.test.lua                  |   6 +-
 test/sql-tap/index4.test.lua                  |  17 +-
 test/sql-tap/insert1.test.lua                 |   9 +-
 test/sql-tap/insert3.test.lua                 |   2 +-
 test/sql-tap/join.test.lua                    |  25 +--
 test/sql-tap/join3.test.lua                   |   4 +-
 test/sql-tap/join6.test.lua                   |   2 +-
 test/sql-tap/keyword1.test.lua                |   2 +-
 test/sql-tap/limit.test.lua                   |  25 ++-
 test/sql-tap/lua/sqltester.lua                |   7 +-
 test/sql-tap/lua_sql.test.lua                 |   6 +-
 test/sql-tap/minmax2.test.lua                 |   2 +
 test/sql-tap/minmax3.test.lua                 |  32 ++--
 test/sql-tap/minmax4.test.lua                 |   4 +-
 test/sql-tap/misc1.test.lua                   |  25 +--
 test/sql-tap/misc3.test.lua                   |   1 -
 test/sql-tap/misc5.test.lua                   |  55 ++++---
 test/sql-tap/null.test.lua                    |  10 +-
 test/sql-tap/numcast.test.lua                 |   2 -
 test/sql-tap/offset1.test.lua                 |   8 +-
 test/sql-tap/orderby1.test.lua                |  12 +-
 test/sql-tap/orderby2.test.lua                |   2 +-
 test/sql-tap/orderby3.test.lua                |   2 +-
 test/sql-tap/orderby4.test.lua                |   2 +-
 test/sql-tap/orderby5.test.lua                |   2 +-
 test/sql-tap/orderby6.test.lua                |  36 ++---
 test/sql-tap/orderby8.test.lua                |   1 -
 test/sql-tap/orderby9.test.lua                |   5 +-
 test/sql-tap/resolver01.test.lua              |   8 +-
 test/sql-tap/select1.test.lua                 |  59 +++----
 test/sql-tap/select3.test.lua                 |  30 ++--
 test/sql-tap/select4.test.lua                 |  32 ++--
 test/sql-tap/select5.test.lua                 |   8 +-
 test/sql-tap/select6.test.lua                 |  36 ++---
 test/sql-tap/select7.test.lua                 |   9 +-
 test/sql-tap/select8.test.lua                 |  24 +--
 test/sql-tap/select9.test.lua                 |  39 ++---
 test/sql-tap/selectA.test.lua                 |  13 --
 test/sql-tap/selectB.test.lua                 |  78 ++++-----
 test/sql-tap/selectC.test.lua                 |   6 +-
 test/sql-tap/selectE.test.lua                 |  16 +-
 test/sql-tap/selectF.test.lua                 |   9 +-
 test/sql-tap/selectG.test.lua                 |   2 -
 test/sql-tap/sort.test.lua                    |  12 +-
 test/sql-tap/subquery.test.lua                |  37 ++---
 test/sql-tap/subquery2.test.lua               |  10 +-
 test/sql-tap/subselect.test.lua               |   4 +-
 test/sql-tap/table.test.lua                   |  57 ++++---
 test/sql-tap/tkt-02a8e81d44.test.lua          |   2 +-
 test/sql-tap/tkt-31338dca7e.test.lua          |   2 +-
 test/sql-tap/tkt-385a5b56b9.test.lua          |   5 +-
 test/sql-tap/tkt-38cb5df375.test.lua          |   1 -
 test/sql-tap/tkt-3a77c9714e.test.lua          |   8 +-
 test/sql-tap/tkt-4a03edc4c8.test.lua          |   2 +-
 test/sql-tap/tkt-4dd95f6943.test.lua          |  17 +-
 test/sql-tap/tkt-4ef7e3cfca.test.lua          |   1 -
 test/sql-tap/tkt-54844eea3f.test.lua          |   7 +-
 test/sql-tap/tkt-752e1646fc.test.lua          |   8 +-
 test/sql-tap/tkt-7bbfb7d442.test.lua          |  15 +-
 test/sql-tap/tkt-80ba201079.test.lua          |   5 +-
 test/sql-tap/tkt-8c63ff0ec.test.lua           |   5 +-
 test/sql-tap/tkt-91e2e8ba6f.test.lua          |  10 +-
 test/sql-tap/tkt-9a8b09f8e6.test.lua          |   4 -
 test/sql-tap/tkt-a8a0d2996a.test.lua          |   3 +-
 test/sql-tap/tkt-b1d3a2e531.test.lua          |   3 -
 test/sql-tap/tkt-b75a9ca6b0.test.lua          |   1 -
 test/sql-tap/tkt-ba7cbfaedc.test.lua          |   5 +-
 test/sql-tap/tkt-bd484a090c.test.lua          |   6 +-
 test/sql-tap/tkt-d635236375.test.lua          |   1 -
 test/sql-tap/tkt-f973c7ac31.test.lua          |   6 +-
 test/sql-tap/tkt-fa7bf5ec.test.lua            |   6 +-
 test/sql-tap/tkt1443.test.lua                 |   9 +-
 test/sql-tap/tkt1444.test.lua                 |   2 +-
 test/sql-tap/tkt1449.test.lua                 |   2 +-
 test/sql-tap/tkt1473.test.lua                 |   8 +-
 test/sql-tap/tkt1501.test.lua                 |   2 +-
 test/sql-tap/tkt1514.test.lua                 |   2 +-
 test/sql-tap/tkt1537.test.lua                 |   2 +-
 test/sql-tap/tkt2141.test.lua                 |   2 +-
 test/sql-tap/tkt2192.test.lua                 |   7 +-
 test/sql-tap/tkt2391.test.lua                 |   4 +-
 test/sql-tap/tkt2640.test.lua                 |   2 +-
 test/sql-tap/tkt2822.test.lua                 |  46 +++---
 test/sql-tap/tkt2927.test.lua                 |  64 ++++----
 test/sql-tap/tkt2942.test.lua                 |   2 +-
 test/sql-tap/tkt3201.test.lua                 |   6 +-
 test/sql-tap/tkt3298.test.lua                 |   2 +-
 test/sql-tap/tkt3357.test.lua                 |   8 +-
 test/sql-tap/tkt3424.test.lua                 |  10 +-
 test/sql-tap/tkt3442.test.lua                 |   4 +-
 test/sql-tap/tkt3493.test.lua                 |  71 ++++----
 test/sql-tap/tkt3554.test.lua                 |   2 +-
 test/sql-tap/tkt3581.test.lua                 |   4 +-
 test/sql-tap/tkt3935.test.lua                 |  17 +-
 test/sql-tap/tokenize.test.lua                |   2 +-
 test/sql-tap/transitive1.test.lua             |   4 +-
 test/sql-tap/trigger1.test.lua                |   2 -
 test/sql-tap/trigger2.test.lua                |   4 +-
 test/sql-tap/trigger9.test.lua                |   3 +-
 test/sql-tap/triggerA.test.lua                |   2 -
 test/sql-tap/triggerB.test.lua                |  10 +-
 test/sql-tap/triggerC.test.lua                |   2 -
 test/sql-tap/types.test.lua                   |   1 -
 test/sql-tap/types2.test.lua                  |   8 +-
 test/sql-tap/update.test.lua                  |  28 ++--
 test/sql-tap/view.test.lua                    | 152 ++++++++----------
 test/sql-tap/where2.test.lua                  |  49 +++---
 test/sql-tap/where3.test.lua                  |  50 +++---
 test/sql-tap/where4.test.lua                  |  18 +--
 test/sql-tap/where6.test.lua                  |   6 +-
 test/sql-tap/where7.test.lua                  |  10 +-
 test/sql-tap/whereC.test.lua                  |   2 -
 test/sql-tap/whereD.test.lua                  |   7 +-
 test/sql-tap/whereF.test.lua                  |   9 +-
 test/sql-tap/whereG.test.lua                  |   9 +-
 test/sql-tap/whereI.test.lua                  |   7 +-
 test/sql-tap/whereK.test.lua                  |   1 -
 test/sql-tap/with1.test.lua                   |  56 +++----
 test/sql-tap/with2.test.lua                   |  41 +++--
 test/sql/lua/sql_tokenizer.lua                |   2 +-
 169 files changed, 1119 insertions(+), 1317 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 47+ messages in thread

end of thread, other threads:[~2021-03-02  9:47 UTC | newest]

Thread overview: 47+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-21 12:49 [Tarantool-patches] [PATCH v8 00/14] Fix luacheck warnings in test/sql and test/sql-tap Sergey Bronnikov via Tarantool-patches
2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 01/14] test: fix luacheck warnings in test/sql Sergey Bronnikov via Tarantool-patches
2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 02/14] test: remove functions to open and close SQL connection Sergey Bronnikov via Tarantool-patches
2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 03/14] test: fix luacheck warnings W113 in test/sql-tap Sergey Bronnikov via Tarantool-patches
2021-01-24 17:33   ` Vladislav Shpilevoy via Tarantool-patches
2021-02-06 17:52     ` Vladislav Shpilevoy via Tarantool-patches
2021-02-16 12:02     ` Sergey Bronnikov via Tarantool-patches
2021-02-23 21:25       ` Vladislav Shpilevoy via Tarantool-patches
2021-02-25 10:39         ` Sergey Bronnikov via Tarantool-patches
2021-02-26 23:42   ` Vladislav Shpilevoy via Tarantool-patches
2021-02-27 17:53     ` Sergey Bronnikov via Tarantool-patches
2021-02-28 15:30       ` Vladislav Shpilevoy via Tarantool-patches
2021-03-01 13:26         ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 04/14] test: fix luacheck warnings W211 " Sergey Bronnikov via Tarantool-patches
2021-01-24 17:34   ` Vladislav Shpilevoy via Tarantool-patches
2021-02-16 14:09     ` Sergey Bronnikov via Tarantool-patches
2021-02-23 21:26   ` Vladislav Shpilevoy via Tarantool-patches
2021-02-25 11:02     ` Sergey Bronnikov via Tarantool-patches
2021-02-26 23:42       ` Vladislav Shpilevoy via Tarantool-patches
2021-02-27 17:09         ` Sergey Bronnikov via Tarantool-patches
2021-02-28 15:30           ` Vladislav Shpilevoy via Tarantool-patches
2021-03-01 13:46             ` Sergey Bronnikov via Tarantool-patches
2021-03-01 21:27               ` Vladislav Shpilevoy via Tarantool-patches
2021-03-02  8:05                 ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 05/14] test: fix luacheck warnings W212 " Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 06/14] test: fix laucheck warnings W213 " Sergey Bronnikov via Tarantool-patches
2021-01-24 17:35   ` Vladislav Shpilevoy via Tarantool-patches
2021-01-29 16:32     ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 07/14] test: fix luacheck warnings W231 " Sergey Bronnikov via Tarantool-patches
2021-01-24 17:35   ` Vladislav Shpilevoy via Tarantool-patches
2021-01-29 22:39     ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 08/14] test: fix luacheck warnings W311 " Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 09/14] test: fix luacheck warnings W511 " Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 10/14] test: fix luacheck warnings W512 " Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 11/14] test: fix luacheck warnings W542 " Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 12/14] test: fix luacheck warnings W612, W613, W614 " Sergey Bronnikov via Tarantool-patches
2021-01-24 17:36   ` Vladislav Shpilevoy via Tarantool-patches
2021-01-29 16:23     ` Sergey Bronnikov via Tarantool-patches
2021-01-29 21:50       ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 13/14] test: fix luacheck warnings W621 " Sergey Bronnikov via Tarantool-patches
2021-01-24 17:37   ` Vladislav Shpilevoy via Tarantool-patches
2021-01-29 16:11     ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 14/14] luacheck: add issues for suppressed warnings Sergey Bronnikov via Tarantool-patches
2021-01-24 17:37   ` Vladislav Shpilevoy via Tarantool-patches
2021-01-29 16:13     ` Sergey Bronnikov via Tarantool-patches
2021-03-01 21:37 ` [Tarantool-patches] [PATCH v8 00/14] Fix luacheck warnings in test/sql and test/sql-tap Vladislav Shpilevoy via Tarantool-patches
2021-03-02  9:47 ` Kirill Yukhin via Tarantool-patches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox