From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id F267C6EC5C; Sat, 30 Jan 2021 00:50:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F267C6EC5C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611957023; bh=W2YNSaowHJeTpOdQjF2g4fgdvzCCVD/j5tMtGQ0Rrhs=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=BtF/MgQ9drtua9RQz5wd2QV2/LAiCygwH6mdgLpnGJpJUmBRpvSXjEdQ4i4efPhvu 1XRMjuKqOBDzYwedkhIg0I0+QDGgYpz+cpokM6o8Q5lMus6UdeDy0rJuPcGhmYg68n 5o/RCK0vuNfdLM8N6yynbLanXo/P7YGyd3nZSqRw= Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 902C86EC5C for ; Sat, 30 Jan 2021 00:50:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 902C86EC5C Received: by smtp36.i.mail.ru with esmtpa (envelope-from ) id 1l5bem-0007Kr-ON; Sat, 30 Jan 2021 00:50:21 +0300 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org References: <848043b44bc85501c8e72a86dea81a44f075ca54.1611232655.git.sergeyb@tarantool.org> <4c8c3998-4851-2c6f-a51d-9f22f5cb11b7@tarantool.org> <098bae4f-124d-586e-21f1-7bbf253889a3@tarantool.org> Message-ID: <4ebbd139-0f6d-3eef-52c9-7ecca068b022@tarantool.org> Date: Sat, 30 Jan 2021 00:50:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <098bae4f-124d-586e-21f1-7bbf253889a3@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD953AC099BC0052A9CD238BCF93DF23716D1711D0DDC4F5AC2182A05F5380850404557F6A2F585E546EE5436BCB1FDC791F93331D25D5C881D8345803EFCEAAC79 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76AB1B6FB25ACEDC9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B100969577675F2D8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC68C517D5EC73AB733A9E237DD3F83B0EE46B2BB044BB1F26389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0ECC8AC47CD0EDEFF8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B601F8F2FECC0250C8CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22496AAA084D2443F95876E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8BAF1BC11907C2F96F3AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE757A4FF9509D8095393EC92FD9297F6715571747095F342E857739F23D657EF2BD5E8D9A59859A8B637767D8BB9CF519C75ECD9A6C639B01B4E70A05D1297E1BBC6867C52282FAC85D9B7C4F32B44FF57285124B2A10EEC6C00306258E7E6ABB4E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5D8FE1B9F3BBF7D2587C4965FB1F0DA8E12E31A49A93DA8BFD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34EC58E35A639A24713F344ED25A46A273934E72A6A80F582D8174E8C6405C5BED9EDB7B2D78BFD36C1D7E09C32AA3244CAF645C2F73AFFFA0202FDC54E922D0EF69B6CAE0477E908DFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj0axADxPFAF8C4ll0OLyi4A== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F25884581C04C0406AF13060623EDABA22585927F065C7496A5DFF35282EC151BADDC1D3523A6D01B4765B2DFB59E2DDD9FE06B14FA522850F29BC30112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v8 12/14] test: fix luacheck warnings W612, W613, W614 in test/sql-tap X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 29.01.2021 19:23, Sergey Bronnikov wrote: > Thanks for review! > > On 24.01.2021 20:36, Vladislav Shpilevoy wrote: >> Thanks for the patch! >> >> See 3 comments below. >> >> On 21.01.2021 13:50, sergeyb@tarantool.org wrote: >>> From: Sergey Bronnikov >>> >>> W612 (A line contains trailing whitespace) >>> W613 (Trailing whitespace in a string) >>> W614 (Trailing whitespace in a comment) >>> >>> Note: changes were made automatically in vim with regexp "%s/\s\+$//e". >>> >>> Part of #5464 >>> --- >>> diff --git a/test/sql-tap/analyzeD.test.lua >>> b/test/sql-tap/analyzeD.test.lua >>> index 12722a3d4..e0426b974 100755 >>> --- a/test/sql-tap/analyzeD.test.lua >>> +++ b/test/sql-tap/analyzeD.test.lua >>> @@ -54,7 +54,7 @@ test:do_test( >>>               ANALYZE; >>>           ]]) >>>       end, { >>> -            -- <1.1> >>> +            -- <1.1> >> 1. Git highligts this line with red. I assume here is an inconsistency >> between tabs and spaces. But it does not matter as these comments can >> be dropped. They are useless artifacts of TCL -> Lua translation. > > Removed > Some testcases in test/sql-tap/tkt3935.test.lua and test/sql-tap/join.test.lua fails when trailing whitespace removed in SQL command line, so expected output line has been updated too where it was required.