From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 702A08205E; Sun, 24 Jan 2021 20:37:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 702A08205E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611509820; bh=aHs4eglkr4T3FlgLT4ODNihefITb/UNQwswBjyHJMIk=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Nw8pnh7h04S4ljzHoZN2m0rIMKRvcZ1HlK8ahYSNokH1WpDjGKiD6afWXV5H2aK+o aZvmvSVNNGswm8Uw8c2waUqAJKnGikxpmUDKySKIAmfw4bY7MGNzAoi4liJYimmDm2 3dg4/N/X9KUwy6oS646GClgmEf8TvUZYzR40AyuM= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8047D8205E for ; Sun, 24 Jan 2021 20:36:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8047D8205E Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1l3jJp-0003bV-LI; Sun, 24 Jan 2021 20:36:58 +0300 To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org References: <848043b44bc85501c8e72a86dea81a44f075ca54.1611232655.git.sergeyb@tarantool.org> Message-ID: <4c8c3998-4851-2c6f-a51d-9f22f5cb11b7@tarantool.org> Date: Sun, 24 Jan 2021 18:36:56 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <848043b44bc85501c8e72a86dea81a44f075ca54.1611232655.git.sergeyb@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9F0E84CC1954AA438DA7C9D49EFD56031073C96FF65D16ECE00894C459B0CD1B910E701404E55DCD9121E11F28A3073601F942A5D71E7AEBE3A6C2E7F7D92FB3D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E0D4B9A53B20B455EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374C29A2D8B98EBF198638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCBDC2C7681C9E637220014B551F6085E0E7FEBD475B916B64389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0ECC8AC47CD0EDEFF8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FC8E48D8FAA4D20A9F75ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4930A3850AC1BE2E735FC839A7D10C5E1E9C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0FECB2555BB02FD5A93B503F486389A921A5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A54FB8FB336B6924C9F5FF26A260DA8A3743E1E8EE0676B2EFD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D341C998A3771F041533C59F0BF1498B74E9B4D8FBD7E08DD12546FB83BF5E4BF2B456443993AB0755C1D7E09C32AA3244CDE96A939C610DC56806BD22744E6017E81560E2432555DBBFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojEcKN7r9rK/0CIXjJjsY/CA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382248AE4B079C5F6CF15FCC30E79FB391453841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v8 12/14] test: fix luacheck warnings W612, W613, W614 in test/sql-tap X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! See 3 comments below. On 21.01.2021 13:50, sergeyb@tarantool.org wrote: > From: Sergey Bronnikov > > W612 (A line contains trailing whitespace) > W613 (Trailing whitespace in a string) > W614 (Trailing whitespace in a comment) > > Note: changes were made automatically in vim with regexp "%s/\s\+$//e". > > Part of #5464 > --- > diff --git a/test/sql-tap/analyzeD.test.lua b/test/sql-tap/analyzeD.test.lua > index 12722a3d4..e0426b974 100755 > --- a/test/sql-tap/analyzeD.test.lua > +++ b/test/sql-tap/analyzeD.test.lua > @@ -54,7 +54,7 @@ test:do_test( > ANALYZE; > ]]) > end, { > - -- <1.1> > + -- <1.1> 1. Git highligts this line with red. I assume here is an inconsistency between tabs and spaces. But it does not matter as these comments can be dropped. They are useless artifacts of TCL -> Lua translation. > -- > }) > diff --git a/test/sql-tap/join.test.lua b/test/sql-tap/join.test.lua > index 1fc968307..4175608fd 100755 > --- a/test/sql-tap/join.test.lua > +++ b/test/sql-tap/join.test.lua > @@ -564,6 +564,7 @@ test:do_catchsql_test( > -- > }) > > +-- luacheck: ignore 2. Why? You couldn't delete some whitespaces here? Or what is the issue? > test:do_catchsql_test( > "join-3.5", > [[ > diff --git a/test/sql-tap/tkt3935.test.lua b/test/sql-tap/tkt3935.test.lua > index 7138e9e6a..f3bbe0b9f 100755 > --- a/test/sql-tap/tkt3935.test.lua > +++ b/test/sql-tap/tkt3935.test.lua > @@ -27,30 +27,31 @@ test:do_execsql_test( > CREATE TABLE t2(c INT primary key, d INT); > ]], { > -- > - > + > -- > }) > > test:do_execsql_test( > "tkt3935.2", > [[ > - SELECT j1.b FROM ( SELECT * FROM t1 INNER JOIN t2 ON a=c ) AS j1 > + SELECT j1.b FROM ( SELECT * FROM t1 INNER JOIN t2 ON a=c ) AS j1 > ]], { > -- > - > + > -- > }) > > test:do_execsql_test( > "tkt3935.3", > [[ > - SELECT j1.b FROM (t1 INNER JOIN t2 ON a=c) AS j1 > + SELECT j1.b FROM (t1 INNER JOIN t2 ON a=c) AS j1 > ]], { > -- > - > + > -- > }) > > +-- luacheck: ignore 3. The same question as in the previous comment. > test:do_catchsql_test( > "tkt3935.4", > [[