From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Subject: [Tarantool-patches] [PATCH v8 13/14] test: fix luacheck warnings W621 in test/sql-tap Date: Thu, 21 Jan 2021 15:50:17 +0300 [thread overview] Message-ID: <664352f76be1541dc4fbe26929380be160914dc3.1611232655.git.sergeyb@tarantool.org> (raw) In-Reply-To: <cover.1611232655.git.sergeyb@tarantool.org> From: Sergey Bronnikov <sergeyb@tarantool.org> W621 (Inconsistent indentation (SPACE followed by TAB)) Part of #5464 --- .luacheckrc | 2 -- test/sql-tap/analyze7.test.lua | 14 +++++++------- test/sql-tap/analyzeD.test.lua | 8 ++++---- test/sql-tap/analyzeF.test.lua | 2 +- test/sql-tap/index1.test.lua | 2 +- 5 files changed, 13 insertions(+), 15 deletions(-) diff --git a/.luacheckrc b/.luacheckrc index 69be93a67..a798ca6f8 100644 --- a/.luacheckrc +++ b/.luacheckrc @@ -53,8 +53,6 @@ files["test/sql-tap/**/*.lua"] = { ignore = { -- A line consists of nothing but whitespace. "611", - -- Inconsistent indentation (SPACE followed by TAB). - "621", -- Line is too long. "631" } diff --git a/test/sql-tap/analyze7.test.lua b/test/sql-tap/analyze7.test.lua index 203a0c3f9..8aa29e951 100755 --- a/test/sql-tap/analyze7.test.lua +++ b/test/sql-tap/analyze7.test.lua @@ -29,11 +29,11 @@ test:do_test( DROP TABLE IF EXISTS nums; CREATE TABLE nums(n INT PRIMARY KEY); INSERT into nums WITH RECURSIVE cnt(x) AS (VALUES(1) UNION ALL SELECT x+1 FROM cnt WHERE x<256) SELECT x FROM cnt; - INSERT INTO t1 SELECT n, n, n, n/100, n FROM nums; - EXPLAIN QUERY PLAN SELECT * FROM t1 WHERE a=123; + INSERT INTO t1 SELECT n, n, n, n/100, n FROM nums; + EXPLAIN QUERY PLAN SELECT * FROM t1 WHERE a=123; ]]) end, { - -- <analyze7-1.0> + -- <analyze7-1.0> 0, 0, 0, "SEARCH TABLE T1 USING COVERING INDEX T1A (A=?)" -- </analyze7-1.0> }) @@ -43,7 +43,7 @@ test:do_execsql_test( [[ EXPLAIN QUERY PLAN SELECT * FROM t1 WHERE b=123; ]], { - -- <analyze7-1.1> + -- <analyze7-1.1> 0, 0, 0, "SEARCH TABLE T1 USING COVERING INDEX T1B (B=?)" -- </analyze7-1.1> }) @@ -68,7 +68,7 @@ test:do_test( test:execsql("ANALYZE;") return test:execsql("EXPLAIN QUERY PLAN SELECT * FROM t1 WHERE a=123;") end, { - -- <analyze7-2.0> + -- <analyze7-2.0> 0, 0, 0, "SEARCH TABLE T1 USING COVERING INDEX T1A (A=?)" -- </analyze7-2.0> }) @@ -147,9 +147,9 @@ test:do_execsql_test( test:do_execsql_test( "analyze7-3.2.2", [[ - EXPLAIN QUERY PLAN SELECT * FROM t1 WHERE c=2; + EXPLAIN QUERY PLAN SELECT * FROM t1 WHERE c=2; ]], { - -- <analyze7-3.2.2> + -- <analyze7-3.2.2> 0, 0, 0, "SEARCH TABLE T1 USING COVERING INDEX T1CD (C=?)" -- </analyze7-3.2.2> }) diff --git a/test/sql-tap/analyzeD.test.lua b/test/sql-tap/analyzeD.test.lua index e0426b974..c6b9fa206 100755 --- a/test/sql-tap/analyzeD.test.lua +++ b/test/sql-tap/analyzeD.test.lua @@ -54,8 +54,8 @@ test:do_test( ANALYZE; ]]) end, { - -- <1.1> - -- </1.1> + -- <1.1> + -- </1.1> }) -- With full ANALYZE data, sql sees that c=150 (5 rows) is better than @@ -122,7 +122,7 @@ test:do_test( end, { -- <1.7> -- </1.7> - }) + }) -- Same test as 1.4, except this time the 7 rows that match the a=? condition -- do not feature larger values than all rows in the stat4 table. So sql @@ -135,7 +135,7 @@ test:do_execsql_test( -- <1.8> 0, 0, 0, "SEARCH TABLE T1 USING COVERING INDEX T1_C (C=?)" -- </1.8> - }) + }) test:do_catchsql_test( "analyzeD-1.9", diff --git a/test/sql-tap/analyzeF.test.lua b/test/sql-tap/analyzeF.test.lua index 0b621a3ae..cbb088415 100755 --- a/test/sql-tap/analyzeF.test.lua +++ b/test/sql-tap/analyzeF.test.lua @@ -25,7 +25,7 @@ box.internal.sql_create_function("isqrt", "NUMBER", isqrt) test:do_execsql_test( 1.0, [[ - DROP TABLE IF EXISTS t1; + DROP TABLE IF EXISTS t1; CREATE TABLE t1(id INT PRIMARY KEY, x INTEGER, y INTEGER); WITH data(i) AS (SELECT 1 UNION ALL SELECT i+1 FROM data) INSERT INTO t1 SELECT i, isqrt(i), isqrt(i) FROM data LIMIT 500; CREATE INDEX t1y ON t1(y); diff --git a/test/sql-tap/index1.test.lua b/test/sql-tap/index1.test.lua index 1ac02d60c..e647c22fe 100755 --- a/test/sql-tap/index1.test.lua +++ b/test/sql-tap/index1.test.lua @@ -406,7 +406,7 @@ test:do_test( test:do_catchsql_test( "index-8.1", [[ - CREATE TABLE test1(a INT PRIMARY KEY); + CREATE TABLE test1(a INT PRIMARY KEY); DROP INDEX index1 ON test1 ]], { -- <index-8.1> -- 2.25.1
next prev parent reply other threads:[~2021-01-21 12:56 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-21 12:49 [Tarantool-patches] [PATCH v8 00/14] Fix luacheck warnings in test/sql and test/sql-tap Sergey Bronnikov via Tarantool-patches 2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 01/14] test: fix luacheck warnings in test/sql Sergey Bronnikov via Tarantool-patches 2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 02/14] test: remove functions to open and close SQL connection Sergey Bronnikov via Tarantool-patches 2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 03/14] test: fix luacheck warnings W113 in test/sql-tap Sergey Bronnikov via Tarantool-patches 2021-01-24 17:33 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-06 17:52 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-16 12:02 ` Sergey Bronnikov via Tarantool-patches 2021-02-23 21:25 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-25 10:39 ` Sergey Bronnikov via Tarantool-patches 2021-02-26 23:42 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-27 17:53 ` Sergey Bronnikov via Tarantool-patches 2021-02-28 15:30 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-01 13:26 ` Sergey Bronnikov via Tarantool-patches 2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 04/14] test: fix luacheck warnings W211 " Sergey Bronnikov via Tarantool-patches 2021-01-24 17:34 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-16 14:09 ` Sergey Bronnikov via Tarantool-patches 2021-02-23 21:26 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-25 11:02 ` Sergey Bronnikov via Tarantool-patches 2021-02-26 23:42 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-27 17:09 ` Sergey Bronnikov via Tarantool-patches 2021-02-28 15:30 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-01 13:46 ` Sergey Bronnikov via Tarantool-patches 2021-03-01 21:27 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-02 8:05 ` Sergey Bronnikov via Tarantool-patches 2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 05/14] test: fix luacheck warnings W212 " Sergey Bronnikov via Tarantool-patches 2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 06/14] test: fix laucheck warnings W213 " Sergey Bronnikov via Tarantool-patches 2021-01-24 17:35 ` Vladislav Shpilevoy via Tarantool-patches 2021-01-29 16:32 ` Sergey Bronnikov via Tarantool-patches 2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 07/14] test: fix luacheck warnings W231 " Sergey Bronnikov via Tarantool-patches 2021-01-24 17:35 ` Vladislav Shpilevoy via Tarantool-patches 2021-01-29 22:39 ` Sergey Bronnikov via Tarantool-patches 2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 08/14] test: fix luacheck warnings W311 " Sergey Bronnikov via Tarantool-patches 2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 09/14] test: fix luacheck warnings W511 " Sergey Bronnikov via Tarantool-patches 2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 10/14] test: fix luacheck warnings W512 " Sergey Bronnikov via Tarantool-patches 2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 11/14] test: fix luacheck warnings W542 " Sergey Bronnikov via Tarantool-patches 2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 12/14] test: fix luacheck warnings W612, W613, W614 " Sergey Bronnikov via Tarantool-patches 2021-01-24 17:36 ` Vladislav Shpilevoy via Tarantool-patches 2021-01-29 16:23 ` Sergey Bronnikov via Tarantool-patches 2021-01-29 21:50 ` Sergey Bronnikov via Tarantool-patches 2021-01-21 12:50 ` Sergey Bronnikov via Tarantool-patches [this message] 2021-01-24 17:37 ` [Tarantool-patches] [PATCH v8 13/14] test: fix luacheck warnings W621 " Vladislav Shpilevoy via Tarantool-patches 2021-01-29 16:11 ` Sergey Bronnikov via Tarantool-patches 2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 14/14] luacheck: add issues for suppressed warnings Sergey Bronnikov via Tarantool-patches 2021-01-24 17:37 ` Vladislav Shpilevoy via Tarantool-patches 2021-01-29 16:13 ` Sergey Bronnikov via Tarantool-patches 2021-03-01 21:37 ` [Tarantool-patches] [PATCH v8 00/14] Fix luacheck warnings in test/sql and test/sql-tap Vladislav Shpilevoy via Tarantool-patches 2021-03-02 9:47 ` Kirill Yukhin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=664352f76be1541dc4fbe26929380be160914dc3.1611232655.git.sergeyb@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=sergeyb@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v8 13/14] test: fix luacheck warnings W621 in test/sql-tap' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox