Re: [Tarantool-patches] [PATCH v8 14/14] luacheck: add issues for suppressed warnings

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Thanks for review!

On 24.01.2021 20:37, Vladislav Shpilevoy wrote:
> Thanks for the patch!
>
> On 21.01.2021 13:50, sergeyb@tarantool.org wrote:
>> From: Sergey Bronnikov <sergeyb@tarantool.org>
>>
>> Closes #5464
>> ---
>>   .luacheckrc | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/.luacheckrc b/.luacheckrc
>> index a798ca6f8..597988367 100644
>> --- a/.luacheckrc
>> +++ b/.luacheckrc
>> @@ -52,8 +52,10 @@ exclude_files = {
>>   files["test/sql-tap/**/*.lua"] = {
>>       ignore = {
>>           -- A line consists of nothing but whitespace.
>> +        -- https://github.com/tarantool/tarantool/issues/5739
> Why can't you fix this one now? Is it so hard that it is
> worth adding a special issue for it? Doesn't the whole work
> consists of removing a bunch of empty lines or whitespaces
> from these lines?

I can. luacheck reported about 1k warnings of this type

and I was worried that it would be difficult to review.

Added new commit with fixes for W611.

>>           "611",
>>           -- Line is too long.
>> +        -- https://github.com/tarantool/tarantool/issues/5181
>>           "631"
>>       }
>>   }
>>