From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v8 12/14] test: fix luacheck warnings W612, W613, W614 in test/sql-tap Date: Fri, 29 Jan 2021 19:23:44 +0300 [thread overview] Message-ID: <098bae4f-124d-586e-21f1-7bbf253889a3@tarantool.org> (raw) In-Reply-To: <4c8c3998-4851-2c6f-a51d-9f22f5cb11b7@tarantool.org> Thanks for review! On 24.01.2021 20:36, Vladislav Shpilevoy wrote: > Thanks for the patch! > > See 3 comments below. > > On 21.01.2021 13:50, sergeyb@tarantool.org wrote: >> From: Sergey Bronnikov <sergeyb@tarantool.org> >> >> W612 (A line contains trailing whitespace) >> W613 (Trailing whitespace in a string) >> W614 (Trailing whitespace in a comment) >> >> Note: changes were made automatically in vim with regexp "%s/\s\+$//e". >> >> Part of #5464 >> --- >> diff --git a/test/sql-tap/analyzeD.test.lua b/test/sql-tap/analyzeD.test.lua >> index 12722a3d4..e0426b974 100755 >> --- a/test/sql-tap/analyzeD.test.lua >> +++ b/test/sql-tap/analyzeD.test.lua >> @@ -54,7 +54,7 @@ test:do_test( >> ANALYZE; >> ]]) >> end, { >> - -- <1.1> >> + -- <1.1> > 1. Git highligts this line with red. I assume here is an inconsistency > between tabs and spaces. But it does not matter as these comments can > be dropped. They are useless artifacts of TCL -> Lua translation. Removed --- a/test/sql-tap/analyzeD.test.lua +++ b/test/sql-tap/analyzeD.test.lua @@ -54,8 +54,6 @@ test:do_test( ANALYZE; ]]) end, { - -- <1.1> - -- </1.1> }) -- With full ANALYZE data, sql sees that c=150 (5 rows) is better than >> -- </1.1> >> }) >> diff --git a/test/sql-tap/join.test.lua b/test/sql-tap/join.test.lua >> index 1fc968307..4175608fd 100755 >> --- a/test/sql-tap/join.test.lua >> +++ b/test/sql-tap/join.test.lua >> @@ -564,6 +564,7 @@ test:do_catchsql_test( >> -- </join-3.4.2> >> }) >> >> +-- luacheck: ignore > 2. Why? You couldn't delete some whitespaces here? > Or what is the issue? --- a/test/sql-tap/join.test.lua +++ b/test/sql-tap/join.test.lua @@ -564,11 +564,10 @@ test:do_catchsql_test( -- </join-3.4.2> }) --- luacheck: ignore test:do_catchsql_test( "join-3.5", [[ - SELECT * FROM t1 USING(a) + SELECT * FROM t1 USING(a) ]], { -- <join-3.5> 1, "Syntax error at line 1 at or near position 40: a JOIN clause is required before ON and USING" > >> test:do_catchsql_test( >> "join-3.5", >> [[ >> diff --git a/test/sql-tap/tkt3935.test.lua b/test/sql-tap/tkt3935.test.lua >> index 7138e9e6a..f3bbe0b9f 100755 >> --- a/test/sql-tap/tkt3935.test.lua >> +++ b/test/sql-tap/tkt3935.test.lua >> @@ -27,30 +27,31 @@ test:do_execsql_test( >> CREATE TABLE t2(c INT primary key, d INT); >> ]], { >> -- <tkt3935.1> >> - >> + >> -- </tkt3935.1> >> }) >> >> test:do_execsql_test( >> "tkt3935.2", >> [[ >> - SELECT j1.b FROM ( SELECT * FROM t1 INNER JOIN t2 ON a=c ) AS j1 >> + SELECT j1.b FROM ( SELECT * FROM t1 INNER JOIN t2 ON a=c ) AS j1 >> ]], { >> -- <tkt3935.2> >> - >> + >> -- </tkt3935.2> >> }) >> >> test:do_execsql_test( >> "tkt3935.3", >> [[ >> - SELECT j1.b FROM (t1 INNER JOIN t2 ON a=c) AS j1 >> + SELECT j1.b FROM (t1 INNER JOIN t2 ON a=c) AS j1 >> ]], { >> -- <tkt3935.3> >> - >> + >> -- </tkt3935.3> >> }) >> >> +-- luacheck: ignore > 3. The same question as in the previous comment. Fixed. --- a/test/sql-tap/tkt3935.test.lua +++ b/test/sql-tap/tkt3935.test.lua @@ -51,77 +51,70 @@ test:do_execsql_test( -- </tkt3935.3> }) --- luacheck: ignore test:do_catchsql_test( "tkt3935.4", [[ - SELECT a FROM (t1) AS t ON b USING(a) + SELECT a FROM (t1) AS t ON b USING(a) ]], { -- <tkt3935.4> 1, "Syntax error at line 1 at or near position 52: a JOIN clause is required before ON and USING" -- </tkt3935.4> }) --- luacheck: ignore test:do_catchsql_test( "tkt3935.5", [[ - SELECT a FROM (t1) AS t ON b + SELECT a FROM (t1) AS t ON b ]], { -- <tkt3935.5> 1, "Syntax error at line 1 at or near position 43: a JOIN clause is required before ON and USING" -- </tkt3935.5> }) --- luacheck: ignore test:do_catchsql_test( "tkt3935.6", [[ - SELECT a FROM (SELECT * FROM t1) AS t ON b USING(a) + SELECT a FROM (SELECT * FROM t1) AS t ON b USING(a) ]], { -- <tkt3935.6> 1, "Syntax error at line 1 at or near position 66: a JOIN clause is required before ON and USING" -- </tkt3935.6> }) --- luacheck: ignore test:do_catchsql_test( "tkt3935.7", [[ - SELECT a FROM (SELECT * FROM t1) AS t ON b + SELECT a FROM (SELECT * FROM t1) AS t ON b ]], { -- <tkt3935.7> 1, "Syntax error at line 1 at or near position 57: a JOIN clause is required before ON and USING" -- </tkt3935.7> }) --- luacheck: ignore test:do_catchsql_test( "tkt3935.8", [[ - SELECT a FROM t1 AS t ON b + SELECT a FROM t1 AS t ON b ]], { -- <tkt3935.8> 1, "Syntax error at line 1 at or near position 41: a JOIN clause is required before ON and USING" -- </tkt3935.8> }) --- luacheck: ignore test:do_catchsql_test( "tkt3935.9", [[ - SELECT a FROM t1 AS t ON b USING(a) + SELECT a FROM t1 AS t ON b USING(a) ]], { -- <tkt3935.9> 1, "Syntax error at line 1 at or near position 50: a JOIN clause is required before ON and USING" -- </tkt3935.9> }) --- luacheck: ignore test:do_catchsql_test( "tkt3935.10", [[ - SELECT a FROM t1 AS t USING(a) + SELECT a FROM t1 AS t USING(a) ]], { -- <tkt3935.10> 1, "Syntax error at line 1 at or near position 45: a JOIN clause is required before ON and USING" > >> test:do_catchsql_test( >> "tkt3935.4", >> [[
next prev parent reply other threads:[~2021-01-29 16:23 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-21 12:49 [Tarantool-patches] [PATCH v8 00/14] Fix luacheck warnings in test/sql and test/sql-tap Sergey Bronnikov via Tarantool-patches 2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 01/14] test: fix luacheck warnings in test/sql Sergey Bronnikov via Tarantool-patches 2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 02/14] test: remove functions to open and close SQL connection Sergey Bronnikov via Tarantool-patches 2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 03/14] test: fix luacheck warnings W113 in test/sql-tap Sergey Bronnikov via Tarantool-patches 2021-01-24 17:33 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-06 17:52 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-16 12:02 ` Sergey Bronnikov via Tarantool-patches 2021-02-23 21:25 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-25 10:39 ` Sergey Bronnikov via Tarantool-patches 2021-02-26 23:42 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-27 17:53 ` Sergey Bronnikov via Tarantool-patches 2021-02-28 15:30 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-01 13:26 ` Sergey Bronnikov via Tarantool-patches 2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 04/14] test: fix luacheck warnings W211 " Sergey Bronnikov via Tarantool-patches 2021-01-24 17:34 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-16 14:09 ` Sergey Bronnikov via Tarantool-patches 2021-02-23 21:26 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-25 11:02 ` Sergey Bronnikov via Tarantool-patches 2021-02-26 23:42 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-27 17:09 ` Sergey Bronnikov via Tarantool-patches 2021-02-28 15:30 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-01 13:46 ` Sergey Bronnikov via Tarantool-patches 2021-03-01 21:27 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-02 8:05 ` Sergey Bronnikov via Tarantool-patches 2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 05/14] test: fix luacheck warnings W212 " Sergey Bronnikov via Tarantool-patches 2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 06/14] test: fix laucheck warnings W213 " Sergey Bronnikov via Tarantool-patches 2021-01-24 17:35 ` Vladislav Shpilevoy via Tarantool-patches 2021-01-29 16:32 ` Sergey Bronnikov via Tarantool-patches 2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 07/14] test: fix luacheck warnings W231 " Sergey Bronnikov via Tarantool-patches 2021-01-24 17:35 ` Vladislav Shpilevoy via Tarantool-patches 2021-01-29 22:39 ` Sergey Bronnikov via Tarantool-patches 2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 08/14] test: fix luacheck warnings W311 " Sergey Bronnikov via Tarantool-patches 2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 09/14] test: fix luacheck warnings W511 " Sergey Bronnikov via Tarantool-patches 2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 10/14] test: fix luacheck warnings W512 " Sergey Bronnikov via Tarantool-patches 2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 11/14] test: fix luacheck warnings W542 " Sergey Bronnikov via Tarantool-patches 2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 12/14] test: fix luacheck warnings W612, W613, W614 " Sergey Bronnikov via Tarantool-patches 2021-01-24 17:36 ` Vladislav Shpilevoy via Tarantool-patches 2021-01-29 16:23 ` Sergey Bronnikov via Tarantool-patches [this message] 2021-01-29 21:50 ` Sergey Bronnikov via Tarantool-patches 2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 13/14] test: fix luacheck warnings W621 " Sergey Bronnikov via Tarantool-patches 2021-01-24 17:37 ` Vladislav Shpilevoy via Tarantool-patches 2021-01-29 16:11 ` Sergey Bronnikov via Tarantool-patches 2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 14/14] luacheck: add issues for suppressed warnings Sergey Bronnikov via Tarantool-patches 2021-01-24 17:37 ` Vladislav Shpilevoy via Tarantool-patches 2021-01-29 16:13 ` Sergey Bronnikov via Tarantool-patches 2021-03-01 21:37 ` [Tarantool-patches] [PATCH v8 00/14] Fix luacheck warnings in test/sql and test/sql-tap Vladislav Shpilevoy via Tarantool-patches 2021-03-02 9:47 ` Kirill Yukhin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=098bae4f-124d-586e-21f1-7bbf253889a3@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=sergeyb@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v8 12/14] test: fix luacheck warnings W612, W613, W614 in test/sql-tap' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox