From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v8 06/14] test: fix laucheck warnings W213 in test/sql-tap
Date: Sun, 24 Jan 2021 18:35:10 +0100 [thread overview]
Message-ID: <84e3a15c-8bae-1384-04f4-c2b1ce67d67a@tarantool.org> (raw)
In-Reply-To: <316462e217117629e781d7aff533741763005b2c.1611232655.git.sergeyb@tarantool.org>
Thanks for the patch!
On 21.01.2021 13:50, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
>
> W213 (Unused loop variable)
>
> Part of #5464
> ---
> diff --git a/test/sql-tap/gh-3083-ephemeral-unref-tuples.test.lua b/test/sql-tap/gh-3083-ephemeral-unref-tuples.test.lua
> index 0b7c3ca32..57302811b 100755
> --- a/test/sql-tap/gh-3083-ephemeral-unref-tuples.test.lua
> +++ b/test/sql-tap/gh-3083-ephemeral-unref-tuples.test.lua
> @@ -12,7 +12,7 @@ test:do_test(
> box.execute("insert into test(id, k) values(" .. i .. "," .. i .. ")")
> end
>
> - for i = 1, 10000 do
> + for i = 1, 10000 do -- luacheck: ignore unused i
Why do you ignore it here, and replace with _ in some other places?
next prev parent reply other threads:[~2021-01-24 17:35 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 12:49 [Tarantool-patches] [PATCH v8 00/14] Fix luacheck warnings in test/sql and test/sql-tap Sergey Bronnikov via Tarantool-patches
2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 01/14] test: fix luacheck warnings in test/sql Sergey Bronnikov via Tarantool-patches
2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 02/14] test: remove functions to open and close SQL connection Sergey Bronnikov via Tarantool-patches
2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 03/14] test: fix luacheck warnings W113 in test/sql-tap Sergey Bronnikov via Tarantool-patches
2021-01-24 17:33 ` Vladislav Shpilevoy via Tarantool-patches
2021-02-06 17:52 ` Vladislav Shpilevoy via Tarantool-patches
2021-02-16 12:02 ` Sergey Bronnikov via Tarantool-patches
2021-02-23 21:25 ` Vladislav Shpilevoy via Tarantool-patches
2021-02-25 10:39 ` Sergey Bronnikov via Tarantool-patches
2021-02-26 23:42 ` Vladislav Shpilevoy via Tarantool-patches
2021-02-27 17:53 ` Sergey Bronnikov via Tarantool-patches
2021-02-28 15:30 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-01 13:26 ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 04/14] test: fix luacheck warnings W211 " Sergey Bronnikov via Tarantool-patches
2021-01-24 17:34 ` Vladislav Shpilevoy via Tarantool-patches
2021-02-16 14:09 ` Sergey Bronnikov via Tarantool-patches
2021-02-23 21:26 ` Vladislav Shpilevoy via Tarantool-patches
2021-02-25 11:02 ` Sergey Bronnikov via Tarantool-patches
2021-02-26 23:42 ` Vladislav Shpilevoy via Tarantool-patches
2021-02-27 17:09 ` Sergey Bronnikov via Tarantool-patches
2021-02-28 15:30 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-01 13:46 ` Sergey Bronnikov via Tarantool-patches
2021-03-01 21:27 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-02 8:05 ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 05/14] test: fix luacheck warnings W212 " Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 06/14] test: fix laucheck warnings W213 " Sergey Bronnikov via Tarantool-patches
2021-01-24 17:35 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-01-29 16:32 ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 07/14] test: fix luacheck warnings W231 " Sergey Bronnikov via Tarantool-patches
2021-01-24 17:35 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-29 22:39 ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 08/14] test: fix luacheck warnings W311 " Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 09/14] test: fix luacheck warnings W511 " Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 10/14] test: fix luacheck warnings W512 " Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 11/14] test: fix luacheck warnings W542 " Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 12/14] test: fix luacheck warnings W612, W613, W614 " Sergey Bronnikov via Tarantool-patches
2021-01-24 17:36 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-29 16:23 ` Sergey Bronnikov via Tarantool-patches
2021-01-29 21:50 ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 13/14] test: fix luacheck warnings W621 " Sergey Bronnikov via Tarantool-patches
2021-01-24 17:37 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-29 16:11 ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 14/14] luacheck: add issues for suppressed warnings Sergey Bronnikov via Tarantool-patches
2021-01-24 17:37 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-29 16:13 ` Sergey Bronnikov via Tarantool-patches
2021-03-01 21:37 ` [Tarantool-patches] [PATCH v8 00/14] Fix luacheck warnings in test/sql and test/sql-tap Vladislav Shpilevoy via Tarantool-patches
2021-03-02 9:47 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84e3a15c-8bae-1384-04f4-c2b1ce67d67a@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v8 06/14] test: fix laucheck warnings W213 in test/sql-tap' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox