Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
	tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v8 04/14] test: fix luacheck warnings W211 in test/sql-tap
Date: Sat, 27 Feb 2021 20:09:09 +0300	[thread overview]
Message-ID: <33adda25-ba4d-b50c-575e-9dd30b38488a@tarantool.org> (raw)
In-Reply-To: <bfbb8668-73db-9cdb-9052-d24f83128075@tarantool.org>

Hello!

On 27.02.2021 02:42, Vladislav Shpilevoy wrote:
> Thanks for the fixes!
>
>>>> diff --git a/test/sql-tap/func.test.lua b/test/sql-tap/func.test.lua
>>>> index 9cd517673..5dab23007 100755
>>>> --- a/test/sql-tap/func.test.lua
>>>> +++ b/test/sql-tap/func.test.lua
>>>> @@ -1382,7 +1380,6 @@ test:do_execsql_test(
>>>>        })
>>>>      db("cache", "flush")
>>>> -V = "three"
>>> 2. 'V' is supposed to be a variable. It is used in the queries
>>> in the surrounding code. Please, don't delete parts of the tests.
>>> It will not make it simpler to restore the context later. The tests
>>> in this patchset either must be deleted, or resurrected, or hacked
>>> to keep their context and not fail luacheck. What to choose - depends
>>> on individual tests. Here clearly we need to keep 'V'. Try to make
>>> another pass of self-review to locate more of such test-"breaking"
>>> changes.
>> reverted and suppressed
>>
>> --- a/test/sql-tap/func.test.lua
>> +++ b/test/sql-tap/func.test.lua
>> @@ -1382,6 +1382,7 @@ test:do_execsql_test(
>>       })
>>
>>   db("cache", "flush")
>> +local V = "three" -- luacheck: no unused
>>   test:do_execsql_test(
>>       "13.8.6",
>>       [[
> Now take a look at the diff in this file:
>
> ====================
> @@ -1361,7 +1361,6 @@ test:do_execsql_test(
>           -- </13.8.3>
>       })
>   
> -local V = "one"
>   test:do_execsql_test(
>       "13.8.4",
>       [[
> @@ -1372,7 +1371,6 @@ test:do_execsql_test(
>           -- </13.8.4>
>       })
>   
> -V = "two"
>   test:do_execsql_test(
>       "13.8.5",
>       [[
> @@ -1384,7 +1382,7 @@ test:do_execsql_test(
>       })
>   
>   db("cache", "flush")
> -V = "three"
> +local V = "three" -- luacheck: no unused
> ====================
>
> The comment wasn't about only "three". You shouldn't delete
> "two" and "one", obviously. By the same reason. They are
> "used" in these not working tests.
Agree, looks bad. Fixed for "one" and "two" too.
>> diff --git a/test/sql-tap/select9.test.lua b/test/sql-tap/select9.test.lua
>> index 4f7da84e2..045d0e4c8 100755
>> --- a/test/sql-tap/select9.test.lua
>> +++ b/test/sql-tap/select9.test.lua
>> @@ -274,10 +274,8 @@ test:do_execsql_test(
>>           -- </select9-2.0>
>>       })
>>   
>> -local t1_space_id = ""
>> -local t2_space_id = ""
>> -t1_space_id = test:execsql([[SELECT * from "_space" where "name"='T1']])["id"]
>> -t2_space_id = test:execsql([[SELECT * from "_space" where "name"='T2']])["id"]
>> +local _ = test:execsql([[SELECT * from "_space" where "name"='T1']])["id"]
>> +local _ = test:execsql([[SELECT * from "_space" where "name"='T2']])["id"]
>>   --X(276, "X!cmd", [=[["db","eval","SELECT * from _space where name='t2'","data","\n  set t2_space_id $data(id)\n"]]=])
>>   --local function reverse(lhs, rhs)
>>   --    return X(283, "X!cmd", [=[["string","compare",["rhs"],["lhs"]]]=])
> t2_space_id is used in the commented code. But it looks already
> corrupted, I can't even closely understand what is happening here.

I read a history of commits for select9.test.lua and "t{1,2}_space_id" 
haven't changed since initial import.

See [1].

> t2_space_id and t1_space_id are obvious names anyway, so we probably could
> just delete their declaration and assignment but keep t2_space_id usage
> in the commented code.
>
> Or comment them out too.

removed:

--- a/test/sql-tap/select9.test.lua
+++ b/test/sql-tap/select9.test.lua
@@ -274,10 +274,8 @@ test:do_execsql_test(
          -- </select9-2.0>
      })

-local t1_space_id = ""
-local t2_space_id = ""
-t1_space_id = test:execsql([[SELECT * from "_space" where 
"name"='T1']])["id"]
-t2_space_id = test:execsql([[SELECT * from "_space" where 
"name"='T2']])["id"]
+local _ = test:execsql([[SELECT * from "_space" where "name"='T1']])["id"]
+local _ = test:execsql([[SELECT * from "_space" where "name"='T2']])["id"]
  --X(276, "X!cmd", [=[["db","eval","SELECT * from _space where 
name='t2'","data","\n  set t2_space_id $data(id)\n"]]=])
  --local function reverse(lhs, rhs)
  --    return X(283, "X!cmd", [=[["string","compare",["rhs"],["lhs"]]]=])

1. 
https://github.com/tarantool/tarantool/commit/47b70d97579a0f9fb59ab122cc97cea4a616be3d#diff-e2e23d907919e91e8ea29b579fd5caa73fd7526b242f65688c2c3939a45372a7R276-R279


  reply	other threads:[~2021-02-27 17:09 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21 12:49 [Tarantool-patches] [PATCH v8 00/14] Fix luacheck warnings in test/sql and test/sql-tap Sergey Bronnikov via Tarantool-patches
2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 01/14] test: fix luacheck warnings in test/sql Sergey Bronnikov via Tarantool-patches
2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 02/14] test: remove functions to open and close SQL connection Sergey Bronnikov via Tarantool-patches
2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 03/14] test: fix luacheck warnings W113 in test/sql-tap Sergey Bronnikov via Tarantool-patches
2021-01-24 17:33   ` Vladislav Shpilevoy via Tarantool-patches
2021-02-06 17:52     ` Vladislav Shpilevoy via Tarantool-patches
2021-02-16 12:02     ` Sergey Bronnikov via Tarantool-patches
2021-02-23 21:25       ` Vladislav Shpilevoy via Tarantool-patches
2021-02-25 10:39         ` Sergey Bronnikov via Tarantool-patches
2021-02-26 23:42   ` Vladislav Shpilevoy via Tarantool-patches
2021-02-27 17:53     ` Sergey Bronnikov via Tarantool-patches
2021-02-28 15:30       ` Vladislav Shpilevoy via Tarantool-patches
2021-03-01 13:26         ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:49 ` [Tarantool-patches] [PATCH v8 04/14] test: fix luacheck warnings W211 " Sergey Bronnikov via Tarantool-patches
2021-01-24 17:34   ` Vladislav Shpilevoy via Tarantool-patches
2021-02-16 14:09     ` Sergey Bronnikov via Tarantool-patches
2021-02-23 21:26   ` Vladislav Shpilevoy via Tarantool-patches
2021-02-25 11:02     ` Sergey Bronnikov via Tarantool-patches
2021-02-26 23:42       ` Vladislav Shpilevoy via Tarantool-patches
2021-02-27 17:09         ` Sergey Bronnikov via Tarantool-patches [this message]
2021-02-28 15:30           ` Vladislav Shpilevoy via Tarantool-patches
2021-03-01 13:46             ` Sergey Bronnikov via Tarantool-patches
2021-03-01 21:27               ` Vladislav Shpilevoy via Tarantool-patches
2021-03-02  8:05                 ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 05/14] test: fix luacheck warnings W212 " Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 06/14] test: fix laucheck warnings W213 " Sergey Bronnikov via Tarantool-patches
2021-01-24 17:35   ` Vladislav Shpilevoy via Tarantool-patches
2021-01-29 16:32     ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 07/14] test: fix luacheck warnings W231 " Sergey Bronnikov via Tarantool-patches
2021-01-24 17:35   ` Vladislav Shpilevoy via Tarantool-patches
2021-01-29 22:39     ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 08/14] test: fix luacheck warnings W311 " Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 09/14] test: fix luacheck warnings W511 " Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 10/14] test: fix luacheck warnings W512 " Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 11/14] test: fix luacheck warnings W542 " Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 12/14] test: fix luacheck warnings W612, W613, W614 " Sergey Bronnikov via Tarantool-patches
2021-01-24 17:36   ` Vladislav Shpilevoy via Tarantool-patches
2021-01-29 16:23     ` Sergey Bronnikov via Tarantool-patches
2021-01-29 21:50       ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 13/14] test: fix luacheck warnings W621 " Sergey Bronnikov via Tarantool-patches
2021-01-24 17:37   ` Vladislav Shpilevoy via Tarantool-patches
2021-01-29 16:11     ` Sergey Bronnikov via Tarantool-patches
2021-01-21 12:50 ` [Tarantool-patches] [PATCH v8 14/14] luacheck: add issues for suppressed warnings Sergey Bronnikov via Tarantool-patches
2021-01-24 17:37   ` Vladislav Shpilevoy via Tarantool-patches
2021-01-29 16:13     ` Sergey Bronnikov via Tarantool-patches
2021-03-01 21:37 ` [Tarantool-patches] [PATCH v8 00/14] Fix luacheck warnings in test/sql and test/sql-tap Vladislav Shpilevoy via Tarantool-patches
2021-03-02  9:47 ` Kirill Yukhin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33adda25-ba4d-b50c-575e-9dd30b38488a@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v8 04/14] test: fix luacheck warnings W211 in test/sql-tap' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox