Re: [Tarantool-patches] [PATCH v8 00/14] Fix luacheck warnings in test/sql and test/sql-tap

[Kirill Yukhin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hello,

On 21 янв 15:49, Sergey Bronnikov via Tarantool-patches wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> Changelog v8:
> 
> - re-made patches for sql-tap suite
> - removed fixes suppressed globally in .luacheckrc (like upvalue redefinitions)
> - splitted huge patch to a number of patches per warning
> - rebased to a master branch
> 
> Changelog v7:
> 
> - fixed warnings in a new code
> - rebased to master branch
> 
> Changelog v6:
> 
> - splitted patch in test/ for patches per sub-directory
> - adjusted suppressions in .luacheckrc
> - fixed formatting issues in .luacheckrc
> 
> Note that a number of tests in sql-tap are broken (see suite.ini) and luacheck
> fixes cannot be verified with running tests.
> 
> Gitlab CI: https://gitlab.com/tarantool/tarantool/-/pipelines/244912620
> Branch: ligurio/gh-5463-luacheck-warnings-test-sql
> Issues:
>   - https://github.com/tarantool/tarantool/issues/5464
>   - https://github.com/tarantool/tarantool/issues/5463
>   - https://github.com/tarantool/tarantool/issues/5741
> 
> Sergey Bronnikov (14):
>   test: fix luacheck warnings in test/sql
>   test: remove functions to open and close SQL connection
>   test: fix luacheck warnings W113 in test/sql-tap
>   test: fix luacheck warnings W211 in test/sql-tap
>   test: fix luacheck warnings W212 in test/sql-tap
>   test: fix laucheck warnings W213 in test/sql-tap
>   test: fix luacheck warnings W231 in test/sql-tap
>   test: fix luacheck warnings W311 in test/sql-tap
>   test: fix luacheck warnings W511 in test/sql-tap
>   test: fix luacheck warnings W512 in test/sql-tap
>   test: fix luacheck warnings W542 in test/sql-tap
>   test: fix luacheck warnings W612, W613, W614 in test/sql-tap
>   test: fix luacheck warnings W621 in test/sql-tap
>   luacheck: add issues for suppressed warnings

I've checked your patch set into 2.6, 2.7 and master.

--
Regards, Kirill Yukhin