From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A47C26EC5F; Tue, 2 Mar 2021 12:47:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A47C26EC5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1614678455; bh=oDDJR03iLZP0gwkX9UL2ZJHf0BTJdgtYvZShp1MpKto=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=IKqb66cSDJ3qtbtD0J/mWJEDHerEei3Jv3zSvsov+eJPgF6wx+TG9jP8Yj9+7d+Fy wQsWwANu2LyJtTeTIk+1m/8147GisHB6fFThEsy1U4mhTlViv2Bobjpz9Xxh0fLoeg TkjgfdEk4IvAgG8odQRsbHyCDBrDv9McRIbc7d6s= Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AF8736EC5F for ; Tue, 2 Mar 2021 12:47:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AF8736EC5F Received: by smtp60.i.mail.ru with esmtpa (envelope-from ) id 1lH1cr-0004vM-QS; Tue, 02 Mar 2021 12:47:34 +0300 Date: Tue, 2 Mar 2021 09:47:33 +0000 To: sergeyb@tarantool.org Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Message-ID: <20210302094733.jas4ce6wmdxeb53j@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92A98208ECBDD29F5BCF62610559114B730DD7337B29CB406182A05F538085040074C7C587922FD03527E80592E06EAF5320736992F987415E29E601F09ECC82C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE792C68BF9CD4C0E9EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006373768BF035B57E5168638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCE5411627659F8B2B03FBB304219B0DB67E94746A0F3CA500389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6D082881546D93491CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249158D4E55945CAD4B76E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8BB848EF1909C7D7FD3AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE70BB89B22BF4660DC67F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C37727919777A35F2B35872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C934F12F0C005D1A85E5BFE6E7EFDEDCD789D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5B632E48A6A0DF5AAB201558ECF196300D4B6BC0F539F2220D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F05B761BB9C2AA44A2C515EE4A4CB9EA9DFC29AFE4D190983ABC4F9CE259420BD6BDCA72AE2057451D7E09C32AA3244C65768E301228ADA65B94A094E1486C1CFE8DA44ABE2443F7FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojnpKwxR6GFbsISygz5pkXKA== X-Mailru-Sender: 05EB39F83D09414F9B5D7F52D7CDFDD2283521C2315ADC75AF6113FDECBEC38101A9439201B89D6FCA16B95394F0DD5CE99530A0C0F27B5268329DCED823713783C0E760C018FF54112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v8 00/14] Fix luacheck warnings in test/sql and test/sql-tap X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kirill Yukhin via Tarantool-patches Reply-To: Kirill Yukhin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello, On 21 янв 15:49, Sergey Bronnikov via Tarantool-patches wrote: > From: Sergey Bronnikov > > Changelog v8: > > - re-made patches for sql-tap suite > - removed fixes suppressed globally in .luacheckrc (like upvalue redefinitions) > - splitted huge patch to a number of patches per warning > - rebased to a master branch > > Changelog v7: > > - fixed warnings in a new code > - rebased to master branch > > Changelog v6: > > - splitted patch in test/ for patches per sub-directory > - adjusted suppressions in .luacheckrc > - fixed formatting issues in .luacheckrc > > Note that a number of tests in sql-tap are broken (see suite.ini) and luacheck > fixes cannot be verified with running tests. > > Gitlab CI: https://gitlab.com/tarantool/tarantool/-/pipelines/244912620 > Branch: ligurio/gh-5463-luacheck-warnings-test-sql > Issues: > - https://github.com/tarantool/tarantool/issues/5464 > - https://github.com/tarantool/tarantool/issues/5463 > - https://github.com/tarantool/tarantool/issues/5741 > > Sergey Bronnikov (14): > test: fix luacheck warnings in test/sql > test: remove functions to open and close SQL connection > test: fix luacheck warnings W113 in test/sql-tap > test: fix luacheck warnings W211 in test/sql-tap > test: fix luacheck warnings W212 in test/sql-tap > test: fix laucheck warnings W213 in test/sql-tap > test: fix luacheck warnings W231 in test/sql-tap > test: fix luacheck warnings W311 in test/sql-tap > test: fix luacheck warnings W511 in test/sql-tap > test: fix luacheck warnings W512 in test/sql-tap > test: fix luacheck warnings W542 in test/sql-tap > test: fix luacheck warnings W612, W613, W614 in test/sql-tap > test: fix luacheck warnings W621 in test/sql-tap > luacheck: add issues for suppressed warnings I've checked your patch set into 2.6, 2.7 and master. -- Regards, Kirill Yukhin