From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 11BC96EC5C; Fri, 29 Jan 2021 19:13:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 11BC96EC5C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611936821; bh=Y8z75vvOFwa0nEI9pJSbA3zHQsRW2IcD2KeqEzeB4yM=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=HDimZXAj0NdpBCDICyNQOlnD2ub76+j3SeJbyB/wDPtP2kt1fcwtxcQVF4Y9ymNIf xnQQaX0eqWJPucsVIIG8DwMMmFCjAnszttqYal5wacYUbdI85bizgtvhjGAdHPag8f I3dPF6ntXLtU2RwCJCjbdb0Kn+RkLWQUxzoTZFJI= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 179C06EC5C for ; Fri, 29 Jan 2021 19:13:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 179C06EC5C Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1l5WOx-0003lM-9I; Fri, 29 Jan 2021 19:13:39 +0300 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org References: <88fbfd235f4c9080a02ab6afd6496d598b9ca0b6.1611232655.git.sergeyb@tarantool.org> Message-ID: Date: Fri, 29 Jan 2021 19:13:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD953AC099BC0052A9C55152E5B36F7009490E3DBC75EBFD4CE182A05F5380850405F205C47BF74EA6A7A427FE2B0ACDF498061A1A4F4EDAD69236CE53C97FA25AF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76042E2DB3E33BF2BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637A521848D7B067A388638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC5E544B2C40DA4DC1570FE0105FA7BAC355EA4858C2547609389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0DEC8C2C8BCD2534D8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6E5E764EB5D94DBD4CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FC81B72331FDCC3D2375ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE493B89ED3C7A6281781C96613F75B7D048DC4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F05F538519369F3743B503F486389A921A5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A55D9F3A7D7316C4AC286F6592497DD6844AFB057210C09CFBD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340D3A19269BBEBAAF2FE0E8D911CBBF8BE12EB6689631A5478629C8495180CB3C52DBA4CE8862E6211D7E09C32AA3244C44CB809067AE3F11E9E66E7C1AE80D0B81560E2432555DBBFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj0axADxPFAF+29mVipdVBdQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822D924B701E069A5E9AC548DF91EBC8234DD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v8 14/14] luacheck: add issues for suppressed warnings X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for review! On 24.01.2021 20:37, Vladislav Shpilevoy wrote: > Thanks for the patch! > > On 21.01.2021 13:50, sergeyb@tarantool.org wrote: >> From: Sergey Bronnikov >> >> Closes #5464 >> --- >> .luacheckrc | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/.luacheckrc b/.luacheckrc >> index a798ca6f8..597988367 100644 >> --- a/.luacheckrc >> +++ b/.luacheckrc >> @@ -52,8 +52,10 @@ exclude_files = { >> files["test/sql-tap/**/*.lua"] = { >> ignore = { >> -- A line consists of nothing but whitespace. >> + -- https://github.com/tarantool/tarantool/issues/5739 > Why can't you fix this one now? Is it so hard that it is > worth adding a special issue for it? Doesn't the whole work > consists of removing a bunch of empty lines or whitespaces > from these lines? I can. luacheck reported about 1k warnings of this type and I was worried that it would be difficult to review. Added new commit with fixes for W611. >> "611", >> -- Line is too long. >> + -- https://github.com/tarantool/tarantool/issues/5181 >> "631" >> } >> } >>