From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B2F0C6EC5C; Fri, 29 Jan 2021 19:11:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B2F0C6EC5C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611936687; bh=Od+C3j9QkUTpFv5MjxZkpfYlb4ec6M2JJQFNuCSep7c=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=QkLkJJZ6CXam8SQHUSPWHBO7UrGsDa3k9ZGdOY8arkVC7gmZugxHv1HFDqR+vo8Wb ZYYUmSmD45zpQHOVyTYUR+dDvpwOaeYlAHX1DBRcMh0HXzl4FZdn/XMpBV/1dSJbWr AKj6hGEtAlG0BGXx2BjuWPWG44zsttaHnClInbT4= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B2B7A6EC5C for ; Fri, 29 Jan 2021 19:11:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B2B7A6EC5C Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1l5WMn-0002QC-N6; Fri, 29 Jan 2021 19:11:26 +0300 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org References: <664352f76be1541dc4fbe26929380be160914dc3.1611232655.git.sergeyb@tarantool.org> Message-ID: <3966879f-60f6-6f1f-4846-9d3a1176691b@tarantool.org> Date: Fri, 29 Jan 2021 19:11:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD953AC099BC0052A9C3D690943982D6E894AC6DB5C833CB876182A05F53808504017EC23BCFBD4F6CE865F23AF525FEC5C22877CC5EFDEC8AF3E52DBB1AE024590 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE748069E1E80091F23EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637C8DFB935205A313D8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC5E544B2C40DA4DC1628920E38D5A037093681CD0E5B4C3BB389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6D082881546D93491CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FCA43F4593FF08F5ED75ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE493B89ED3C7A62817811CE60B8040019C36C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F05F538519369F3743B503F486389A921A5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A50E972DDAC127E21A4E0D5C128F7D38CBC369495A578E5DFFD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340A59E724FC7897F70E5E2AB333C0D7A4891558C3726DBC2C6F7B84B60E5BD75C9342C1AF9B3183BB1D7E09C32AA3244C7C678296DD91C0CC6B315B45338C3B1ACE0B41342B755BCDFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj0axADxPFAF9iOJZk1r2Dmw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822AF9CE79A91C72DDB7E5AA545035C405DDD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v8 13/14] test: fix luacheck warnings W621 in test/sql-tap X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for review! On 24.01.2021 20:37, Vladislav Shpilevoy wrote: > Thanks for the patch! > > See 2 comments below. > > On 21.01.2021 13:50, sergeyb@tarantool.org wrote: >> From: Sergey Bronnikov >> >> W621 (Inconsistent indentation (SPACE followed by TAB)) >> >> Part of #5464 >> --- >> diff --git a/test/sql-tap/analyze7.test.lua b/test/sql-tap/analyze7.test.lua >> index 203a0c3f9..8aa29e951 100755 >> --- a/test/sql-tap/analyze7.test.lua >> +++ b/test/sql-tap/analyze7.test.lua >> @@ -29,11 +29,11 @@ test:do_test( >> DROP TABLE IF EXISTS nums; >> CREATE TABLE nums(n INT PRIMARY KEY); >> INSERT into nums WITH RECURSIVE cnt(x) AS (VALUES(1) UNION ALL SELECT x+1 FROM cnt WHERE x<256) SELECT x FROM cnt; >> - INSERT INTO t1 SELECT n, n, n, n/100, n FROM nums; >> - EXPLAIN QUERY PLAN SELECT * FROM t1 WHERE a=123; >> + INSERT INTO t1 SELECT n, n, n, n/100, n FROM nums; >> + EXPLAIN QUERY PLAN SELECT * FROM t1 WHERE a=123; >> ]]) >> end, { >> - -- >> + -- > 1. This is now misaligned with the next comment. Reverted --- a/test/sql-tap/analyze7.test.lua +++ b/test/sql-tap/analyze7.test.lua @@ -33,7 +33,7 @@ test:do_test(                          EXPLAIN QUERY PLAN SELECT * FROM t1 WHERE a=123;                 ]])                 end, { -                -- +               --              0, 0, 0, "SEARCH TABLE T1 USING COVERING INDEX T1A (A=?)"              --          }) > >> 0, 0, 0, "SEARCH TABLE T1 USING COVERING INDEX T1A (A=?)" >> -- >> }) >> diff --git a/test/sql-tap/analyzeD.test.lua b/test/sql-tap/analyzeD.test.lua >> index e0426b974..c6b9fa206 100755 >> --- a/test/sql-tap/analyzeD.test.lua >> +++ b/test/sql-tap/analyzeD.test.lua >> @@ -54,8 +54,8 @@ test:do_test( >> ANALYZE; >> ]]) >> end, { >> - -- <1.1> >> - -- >> + -- <1.1> >> + -- > 2. You can drop both lines. They are not necessary > for anything. Removed --- a/test/sql-tap/analyzeD.test.lua +++ b/test/sql-tap/analyzeD.test.lua @@ -54,8 +54,6 @@ test:do_test(                         ANALYZE;                 ]])         end, { -                -- <1.1> -                --      })  -- With full ANALYZE data, sql sees that c=150 (5 rows) is better than