From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B30586EC5B; Mon, 1 Mar 2021 16:26:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B30586EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1614605170; bh=6kIpSPAbnHrURcA64xj0g8vwDipbM45YtJRBcnpNpt0=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=XvSTXQ250BjFHuNWBenaYPRvPZcPqOCPqSqNhti3b9MYO1oRSqnRMKh9IJ4PBbBmA DgsNH/lU9HRp/Sp4qTv+YlgKARqxxeKDM0JRuufmu5UIwlphMBU85ijVjAgVbQ6tqC VELomYOtCtvG48yXSenHkgOGrVoHgjPenP/zdz1k= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8BFDB6EC5B for ; Mon, 1 Mar 2021 16:26:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8BFDB6EC5B Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lGiYq-0000ri-Sl; Mon, 01 Mar 2021 16:26:09 +0300 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org References: <3a5360daf42cd920e3ce536020a6ff2fbccc095e.1611232655.git.sergeyb@tarantool.org> <9c57efe9-3b45-40ee-ab94-a55b08bb27d1@tarantool.org> <6bfcded5-da78-92a7-f641-679bd3e1ea7f@tarantool.org> Message-ID: <29fccf22-92f8-6538-5b7f-08af446ec7f2@tarantool.org> Date: Mon, 1 Mar 2021 16:26:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9795828B892398B72414AFA2BC3D2D62B9685CCEF58C84E9A182A05F5380850404BF3A393EDE5965DFD6570E86A12F25C6A917FD58F48BFA110B051D8E39ACD94 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B9D6DADD6B53929DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063750E64749F09C4ED58638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC17C6117F61ECB8816B323F3C2C055FD29955EC471A01E379389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FC80B9CEB5436E71E375ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4930A3850AC1BE2E735430FDFEF8887E0B2C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F05F538519369F3743B503F486389A921A5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A583318E3E8357666778E1113A75BE83693EC98B5AFD49DBCBD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34682FD2D2951524C5561EE375B8429663A8D39CFB0EADD8E8FA732F8ADD4CF5FA2CD800E920E466EA1D7E09C32AA3244CDA3FD73E9CE50899235B3121943129D5250262A5EE9971B0729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojnpKwxR6GFbsTOKBv9k4PwQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638226E04F6D94AB5B567CF65CAB4544D1198DD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v8 03/14] test: fix luacheck warnings W113 in test/sql-tap X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello! On 28.02.2021 18:30, Vladislav Shpilevoy wrote: > Hi again! > >> diff --git a/test/sql-tap/lua_sql.test.lua b/test/sql-tap/lua_sql.test.lua >> index b22f195ca..0f6360dd4 100755 >> --- a/test/sql-tap/lua_sql.test.lua >> +++ b/test/sql-tap/lua_sql.test.lua >> @@ -102,9 +104,10 @@ box.schema.func.create('CHECK_FROM_LUA_TO_SQL', {language = 'Lua', >> exports = {'LUA', 'SQL'}}) >> >> -- check for different types >> -for i = 1, #from_lua_to_sql, 1 do >> +for i = 1, #from_lua_to_sql, 1 do -- luacheck: ignore from_lua_to_sql >> test:do_execsql_test( >> "lua_sql-2.3."..i, >> + -- luacheck: ignore from_lua_to_sql > Why do you need these ignores now? Applied solution to `from_sql_to_lua` and missed that there is `from_lua_to_sql`. Fixed with patch below: --- a/test/sql-tap/lua_sql.test.lua +++ b/test/sql-tap/lua_sql.test.lua @@ -84,7 +84,7 @@ for i = 1, #from_sql_to_lua, 1 do          {1})  end -_G.from_lua_to_sql = { +local from_lua_to_sql = {      [1] = {1, 1},      [2] = {"1.5", 1.5},      [3] = {"'1'", "1"}, @@ -93,6 +93,8 @@ _G.from_lua_to_sql = {      [6] = {12, 12LL},  } +_G.from_lua_to_sql = from_lua_to_sql +  box.schema.func.create('CHECK_FROM_LUA_TO_SQL', {language = 'Lua',                         is_deterministic = true,                         body = [[ @@ -104,10 +106,9 @@ box.schema.func.create('CHECK_FROM_LUA_TO_SQL', {language = 'Lua',                         exports = {'LUA', 'SQL'}})  -- check for different types -for i = 1, #from_lua_to_sql, 1 do -- luacheck: ignore from_lua_to_sql +for i = 1, #from_lua_to_sql, 1 do      test:do_execsql_test(          "lua_sql-2.3."..i, -        -- luacheck: ignore from_lua_to_sql          "select "..tostring(from_lua_to_sql[i][1]).." = check_from_lua_to_sql("..i..")",          {true})  end > >> "select "..tostring(from_lua_to_sql[i][1]).." = check_from_lua_to_sql("..i..")", >> {true}) >> end