From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E41F257E46; Sun, 24 Jan 2021 20:37:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E41F257E46 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611509853; bh=TOgoldThNNED9u0mAn8LNMnXbcDlei9cGLBCutS1jjo=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Xqac1UUpxqXdWEK8TC7brL3rv4ZUxkGhN+dBzsnpXz0yOdLhYynenGPDc9M2XlImx JrHFITQ3uvzLlzVz9L0hL7Nu9IOGfjnG0U3ttmWmDOYNQiONdG6s5FCXqxDTM5KqiL v1YXgVi/9auKC0vUdxmgu6pmTQYu6ZXwS0vSjVwc= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8464C57E46 for ; Sun, 24 Jan 2021 20:37:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8464C57E46 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1l3jKN-0001uk-Lo; Sun, 24 Jan 2021 20:37:32 +0300 To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org References: <664352f76be1541dc4fbe26929380be160914dc3.1611232655.git.sergeyb@tarantool.org> Message-ID: Date: Sun, 24 Jan 2021 18:37:30 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <664352f76be1541dc4fbe26929380be160914dc3.1611232655.git.sergeyb@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9F0E84CC1954AA438331E2B4DE5EF215F78D30482705E9CFF00894C459B0CD1B9391E8E4BF8CDEDCDE52B7E795BAF30161F942A5D71E7AEBEC4426626564D10EB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7178CF5C0F418A002EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CCDA16D05354CC6E8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCBDC2C7681C9E6372A121B688E77757042B4E614870744A5F389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B68424CA1AAF98A6958941B15DA834481F9449624AB7ADAF3735872C767BF85DA29E625A9149C048EE0A3850AC1BE2E735F67BA0E7924E9B8D4AD6D5ED66289B524E70A05D1297E1BB35872C767BF85DA227C277FBC8AE2E8BE5C5E69497F0F96F75ECD9A6C639B01B4E70A05D1297E1BBC6867C52282FAC85D9B7C4F32B44FF57E8FBB06288C1946000306258E7E6ABB4E4A6367B16DE6309 X-B7AD71C0: 6FEFE4C63DFE2D85469AD6E133326EAB664F5199923B286E81C2AD9CFA0FBF5C9C2BBA594F31363B5803BE1F3B17DC36E8F7B195E1C9783145E15F0CE03DEC99916D7973594ED144 X-C1DE0DAB: 0D63561A33F958A593F67BE90D48EBFAB514680A8F4E1D2462C99697629E26DFD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349320586B19AD2C72B5D35ACDEF3DFA4987A2048C19BD445C2AAAB63872B8A0527BE98C6744A77AA81D7E09C32AA3244CE11D6076E9613BF17E4233A5EE8AE8DEC3B3ADDA61883BB5FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojEcKN7r9rK/3D7B9u8tp8vg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638223FF025D35D80614555A9A706259658443841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v8 13/14] test: fix luacheck warnings W621 in test/sql-tap X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! See 2 comments below. On 21.01.2021 13:50, sergeyb@tarantool.org wrote: > From: Sergey Bronnikov > > W621 (Inconsistent indentation (SPACE followed by TAB)) > > Part of #5464 > --- > diff --git a/test/sql-tap/analyze7.test.lua b/test/sql-tap/analyze7.test.lua > index 203a0c3f9..8aa29e951 100755 > --- a/test/sql-tap/analyze7.test.lua > +++ b/test/sql-tap/analyze7.test.lua > @@ -29,11 +29,11 @@ test:do_test( > DROP TABLE IF EXISTS nums; > CREATE TABLE nums(n INT PRIMARY KEY); > INSERT into nums WITH RECURSIVE cnt(x) AS (VALUES(1) UNION ALL SELECT x+1 FROM cnt WHERE x<256) SELECT x FROM cnt; > - INSERT INTO t1 SELECT n, n, n, n/100, n FROM nums; > - EXPLAIN QUERY PLAN SELECT * FROM t1 WHERE a=123; > + INSERT INTO t1 SELECT n, n, n, n/100, n FROM nums; > + EXPLAIN QUERY PLAN SELECT * FROM t1 WHERE a=123; > ]]) > end, { > - -- > + -- 1. This is now misaligned with the next comment. > 0, 0, 0, "SEARCH TABLE T1 USING COVERING INDEX T1A (A=?)" > -- > }) > diff --git a/test/sql-tap/analyzeD.test.lua b/test/sql-tap/analyzeD.test.lua > index e0426b974..c6b9fa206 100755 > --- a/test/sql-tap/analyzeD.test.lua > +++ b/test/sql-tap/analyzeD.test.lua > @@ -54,8 +54,8 @@ test:do_test( > ANALYZE; > ]]) > end, { > - -- <1.1> > - -- > + -- <1.1> > + -- 2. You can drop both lines. They are not necessary for anything.