From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 32CA56465D; Thu, 21 Jan 2021 15:50:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 32CA56465D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611233414; bh=Ug/vGUVfUW9pXuDyH3qKSt/+KIcSq4Ouui4+xgLoHSM=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=XEgtipn2Vo5FGQkufEEFXXt/Br5Zpgpt2bo/zXzY4QxLcSXkg/791DH+A445kenbI zhaLEbu1J+J64CrFdCPaflEzVA8KZszXnC46MSw4HE2vCcnulCYy6Us3R+j7YfWHSU BIOEhM6Ecj2HRt6WEMKIfCpQyLhF6IfmQhZG7Z5w= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EBC446465D for ; Thu, 21 Jan 2021 15:50:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EBC446465D Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1l2ZPg-0007wD-Nc; Thu, 21 Jan 2021 15:50:13 +0300 To: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Date: Thu, 21 Jan 2021 15:49:51 +0300 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9FAB20BF8F075903611E4AAC87D4D1F5ADD85E7A24115F22B182A05F5380850406EC7698695566946D7F9DCFEB4A258053E8615052F73DE88B141F62714C21597 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7978947DCA0D4215FEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063737452AF4BFD067BF8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCEB69F05919F51CB435A5268FB126E4A382B255A3AC3B3624389733CBF5DBD5E913377AFFFEAFD269A417C69337E82CC2CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92A417C69337E82CC2CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FC6F009C1859321A3875ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4931B544F03EFBC4D57C2546860BDEA057BC4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F05F538519369F3743B503F486389A921A5CC5B56E945C8DA X-C1DE0DAB: C20DE7B7AB408E4181F030C43753B8186998911F362727C414F749A5E30D975C2549B6A8B600A67A2E49AFE6291E08C1F60F26913885262A9C2B6934AE262D3EE7EAB7254005DCED7D57246285A038711E0A4E2319210D9B64D260DF9561598F01A9E91200F654B069F8FEF10F1C2C2993EDB24507CE13387DFF0A840B692CF8 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349DAEDEF7DE8FDCFAD3ABA97423A817DF5A72711EB0717D1A38C9F6546BCD9F148068225B5E4E47A61D7E09C32AA3244CBA3F2E0ACBC9510FC2A17E3768143921A8CE788DE6831205927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojYT//mZRaUeg1Y94DI9OJKA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638224563B5DFEAF3E99133A3F1B7749A6C4DDD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: [Tarantool-patches] [PATCH v8 00/14] Fix luacheck warnings in test/sql and test/sql-tap X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: sergeyb@tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" From: Sergey Bronnikov Changelog v8: - re-made patches for sql-tap suite - removed fixes suppressed globally in .luacheckrc (like upvalue redefinitions) - splitted huge patch to a number of patches per warning - rebased to a master branch Changelog v7: - fixed warnings in a new code - rebased to master branch Changelog v6: - splitted patch in test/ for patches per sub-directory - adjusted suppressions in .luacheckrc - fixed formatting issues in .luacheckrc Note that a number of tests in sql-tap are broken (see suite.ini) and luacheck fixes cannot be verified with running tests. Gitlab CI: https://gitlab.com/tarantool/tarantool/-/pipelines/244912620 Branch: ligurio/gh-5463-luacheck-warnings-test-sql Issues: - https://github.com/tarantool/tarantool/issues/5464 - https://github.com/tarantool/tarantool/issues/5463 - https://github.com/tarantool/tarantool/issues/5741 Sergey Bronnikov (14): test: fix luacheck warnings in test/sql test: remove functions to open and close SQL connection test: fix luacheck warnings W113 in test/sql-tap test: fix luacheck warnings W211 in test/sql-tap test: fix luacheck warnings W212 in test/sql-tap test: fix laucheck warnings W213 in test/sql-tap test: fix luacheck warnings W231 in test/sql-tap test: fix luacheck warnings W311 in test/sql-tap test: fix luacheck warnings W511 in test/sql-tap test: fix luacheck warnings W512 in test/sql-tap test: fix luacheck warnings W542 in test/sql-tap test: fix luacheck warnings W612, W613, W614 in test/sql-tap test: fix luacheck warnings W621 in test/sql-tap luacheck: add issues for suppressed warnings .luacheckrc | 65 ++++---- test/sql-tap/aggnested.test.lua | 9 +- test/sql-tap/alias.test.lua | 4 +- test/sql-tap/alter.test.lua | 2 +- test/sql-tap/analyze1.test.lua | 4 +- test/sql-tap/analyze3.test.lua | 54 +++---- test/sql-tap/analyze4.test.lua | 6 +- test/sql-tap/analyze5.test.lua | 22 +-- test/sql-tap/analyze6.test.lua | 2 - test/sql-tap/analyze7.test.lua | 14 +- test/sql-tap/analyze8.test.lua | 10 +- test/sql-tap/analyze9.test.lua | 120 +++++++------- test/sql-tap/analyzeC.test.lua | 3 - test/sql-tap/analyzeD.test.lua | 24 ++- test/sql-tap/analyzeE.test.lua | 2 - test/sql-tap/analyzeF.test.lua | 6 +- test/sql-tap/atof1.test.lua | 2 +- test/sql-tap/autoinc.test.lua | 4 +- test/sql-tap/autoindex4.test.lua | 6 +- test/sql-tap/badutf1.test.lua | 10 +- test/sql-tap/between.test.lua | 2 +- test/sql-tap/check.test.lua | 4 +- test/sql-tap/colname.test.lua | 10 +- test/sql-tap/contrib01.test.lua | 4 +- test/sql-tap/count.test.lua | 1 - test/sql-tap/date.test.lua | 8 +- test/sql-tap/default.test.lua | 12 +- test/sql-tap/delete3.test.lua | 2 +- test/sql-tap/delete4.test.lua | 16 +- test/sql-tap/distinct.test.lua | 7 +- test/sql-tap/e_delete.test.lua | 2 +- test/sql-tap/e_expr.test.lua | 52 ++---- test/sql-tap/e_select1.test.lua | 8 +- test/sql-tap/eqp.test.lua | 54 +++---- test/sql-tap/func.test.lua | 11 +- test/sql-tap/func5.test.lua | 2 +- test/sql-tap/gh-2723-concurrency.test.lua | 8 +- .../gh-3083-ephemeral-unref-tuples.test.lua | 2 +- .../gh-3332-tuple-format-leak.test.lua | 2 +- .../gh2127-indentifier-max-length.test.lua | 10 +- .../gh2250-trigger-chain-limit.test.lua | 1 - test/sql-tap/icu.test.lua | 8 +- test/sql-tap/identifier-characters.test.lua | 2 +- test/sql-tap/in1.test.lua | 48 +++--- test/sql-tap/in2.test.lua | 12 +- test/sql-tap/in3.test.lua | 36 ++--- test/sql-tap/in4.test.lua | 56 +++---- test/sql-tap/in5.test.lua | 1 - test/sql-tap/index1.test.lua | 5 +- test/sql-tap/index3.test.lua | 6 +- test/sql-tap/index4.test.lua | 17 +- test/sql-tap/insert1.test.lua | 9 +- test/sql-tap/insert3.test.lua | 2 +- test/sql-tap/join.test.lua | 25 +-- test/sql-tap/join3.test.lua | 4 +- test/sql-tap/join6.test.lua | 2 +- test/sql-tap/keyword1.test.lua | 2 +- test/sql-tap/limit.test.lua | 25 ++- test/sql-tap/lua/sqltester.lua | 7 +- test/sql-tap/lua_sql.test.lua | 6 +- test/sql-tap/minmax2.test.lua | 2 + test/sql-tap/minmax3.test.lua | 32 ++-- test/sql-tap/minmax4.test.lua | 4 +- test/sql-tap/misc1.test.lua | 25 +-- test/sql-tap/misc3.test.lua | 1 - test/sql-tap/misc5.test.lua | 55 ++++--- test/sql-tap/null.test.lua | 10 +- test/sql-tap/numcast.test.lua | 2 - test/sql-tap/offset1.test.lua | 8 +- test/sql-tap/orderby1.test.lua | 12 +- test/sql-tap/orderby2.test.lua | 2 +- test/sql-tap/orderby3.test.lua | 2 +- test/sql-tap/orderby4.test.lua | 2 +- test/sql-tap/orderby5.test.lua | 2 +- test/sql-tap/orderby6.test.lua | 36 ++--- test/sql-tap/orderby8.test.lua | 1 - test/sql-tap/orderby9.test.lua | 5 +- test/sql-tap/resolver01.test.lua | 8 +- test/sql-tap/select1.test.lua | 59 +++---- test/sql-tap/select3.test.lua | 30 ++-- test/sql-tap/select4.test.lua | 32 ++-- test/sql-tap/select5.test.lua | 8 +- test/sql-tap/select6.test.lua | 36 ++--- test/sql-tap/select7.test.lua | 9 +- test/sql-tap/select8.test.lua | 24 +-- test/sql-tap/select9.test.lua | 39 ++--- test/sql-tap/selectA.test.lua | 13 -- test/sql-tap/selectB.test.lua | 78 ++++----- test/sql-tap/selectC.test.lua | 6 +- test/sql-tap/selectE.test.lua | 16 +- test/sql-tap/selectF.test.lua | 9 +- test/sql-tap/selectG.test.lua | 2 - test/sql-tap/sort.test.lua | 12 +- test/sql-tap/subquery.test.lua | 37 ++--- test/sql-tap/subquery2.test.lua | 10 +- test/sql-tap/subselect.test.lua | 4 +- test/sql-tap/table.test.lua | 57 ++++--- test/sql-tap/tkt-02a8e81d44.test.lua | 2 +- test/sql-tap/tkt-31338dca7e.test.lua | 2 +- test/sql-tap/tkt-385a5b56b9.test.lua | 5 +- test/sql-tap/tkt-38cb5df375.test.lua | 1 - test/sql-tap/tkt-3a77c9714e.test.lua | 8 +- test/sql-tap/tkt-4a03edc4c8.test.lua | 2 +- test/sql-tap/tkt-4dd95f6943.test.lua | 17 +- test/sql-tap/tkt-4ef7e3cfca.test.lua | 1 - test/sql-tap/tkt-54844eea3f.test.lua | 7 +- test/sql-tap/tkt-752e1646fc.test.lua | 8 +- test/sql-tap/tkt-7bbfb7d442.test.lua | 15 +- test/sql-tap/tkt-80ba201079.test.lua | 5 +- test/sql-tap/tkt-8c63ff0ec.test.lua | 5 +- test/sql-tap/tkt-91e2e8ba6f.test.lua | 10 +- test/sql-tap/tkt-9a8b09f8e6.test.lua | 4 - test/sql-tap/tkt-a8a0d2996a.test.lua | 3 +- test/sql-tap/tkt-b1d3a2e531.test.lua | 3 - test/sql-tap/tkt-b75a9ca6b0.test.lua | 1 - test/sql-tap/tkt-ba7cbfaedc.test.lua | 5 +- test/sql-tap/tkt-bd484a090c.test.lua | 6 +- test/sql-tap/tkt-d635236375.test.lua | 1 - test/sql-tap/tkt-f973c7ac31.test.lua | 6 +- test/sql-tap/tkt-fa7bf5ec.test.lua | 6 +- test/sql-tap/tkt1443.test.lua | 9 +- test/sql-tap/tkt1444.test.lua | 2 +- test/sql-tap/tkt1449.test.lua | 2 +- test/sql-tap/tkt1473.test.lua | 8 +- test/sql-tap/tkt1501.test.lua | 2 +- test/sql-tap/tkt1514.test.lua | 2 +- test/sql-tap/tkt1537.test.lua | 2 +- test/sql-tap/tkt2141.test.lua | 2 +- test/sql-tap/tkt2192.test.lua | 7 +- test/sql-tap/tkt2391.test.lua | 4 +- test/sql-tap/tkt2640.test.lua | 2 +- test/sql-tap/tkt2822.test.lua | 46 +++--- test/sql-tap/tkt2927.test.lua | 64 ++++---- test/sql-tap/tkt2942.test.lua | 2 +- test/sql-tap/tkt3201.test.lua | 6 +- test/sql-tap/tkt3298.test.lua | 2 +- test/sql-tap/tkt3357.test.lua | 8 +- test/sql-tap/tkt3424.test.lua | 10 +- test/sql-tap/tkt3442.test.lua | 4 +- test/sql-tap/tkt3493.test.lua | 71 ++++---- test/sql-tap/tkt3554.test.lua | 2 +- test/sql-tap/tkt3581.test.lua | 4 +- test/sql-tap/tkt3935.test.lua | 17 +- test/sql-tap/tokenize.test.lua | 2 +- test/sql-tap/transitive1.test.lua | 4 +- test/sql-tap/trigger1.test.lua | 2 - test/sql-tap/trigger2.test.lua | 4 +- test/sql-tap/trigger9.test.lua | 3 +- test/sql-tap/triggerA.test.lua | 2 - test/sql-tap/triggerB.test.lua | 10 +- test/sql-tap/triggerC.test.lua | 2 - test/sql-tap/types.test.lua | 1 - test/sql-tap/types2.test.lua | 8 +- test/sql-tap/update.test.lua | 28 ++-- test/sql-tap/view.test.lua | 152 ++++++++---------- test/sql-tap/where2.test.lua | 49 +++--- test/sql-tap/where3.test.lua | 50 +++--- test/sql-tap/where4.test.lua | 18 +-- test/sql-tap/where6.test.lua | 6 +- test/sql-tap/where7.test.lua | 10 +- test/sql-tap/whereC.test.lua | 2 - test/sql-tap/whereD.test.lua | 7 +- test/sql-tap/whereF.test.lua | 9 +- test/sql-tap/whereG.test.lua | 9 +- test/sql-tap/whereI.test.lua | 7 +- test/sql-tap/whereK.test.lua | 1 - test/sql-tap/with1.test.lua | 56 +++---- test/sql-tap/with2.test.lua | 41 +++-- test/sql/lua/sql_tokenizer.lua | 2 +- 169 files changed, 1119 insertions(+), 1317 deletions(-) -- 2.25.1