From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3ECF98205E; Sun, 24 Jan 2021 20:36:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3ECF98205E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611509760; bh=Kk/+DS4QA4y1eI+RoyJERitWk1uiYfauKDNfqxaigzI=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=YDa7ToYJxe3YT6UmeOVS0yfBS3N5DnvrjK9Arx+P8XW/nqViQnu2iJrt6c+fEISEw KFyMZWgxcGJ/D6tm5IaVQniqM7FL1mi/odZgaSxJ/Dk5aCKCPVxLHoS5gtCb78zK/u gQOXchApwbyqKTnipvLSwGRTj7PMAugEHjVvABYc= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EB3868205E for ; Sun, 24 Jan 2021 20:35:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EB3868205E Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1l3jIs-00084Y-32; Sun, 24 Jan 2021 20:35:58 +0300 To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org References: <2784ee79c0a4cdf900bc49821d50f44c9317d7e5.1611232655.git.sergeyb@tarantool.org> Message-ID: <3283e4df-e15b-f8b8-f2f4-a93b26bc427b@tarantool.org> Date: Sun, 24 Jan 2021 18:35:57 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <2784ee79c0a4cdf900bc49821d50f44c9317d7e5.1611232655.git.sergeyb@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9F0E84CC1954AA438CF139A4DF54DC2E88E2FE7C97C65DF6000894C459B0CD1B9139E357489378C894EF5B10D51990B4D1F942A5D71E7AEBE083B9DBA0D511FCC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A20935EE237A17ECEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC18FED211962C318638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCBDC2C7681C9E6372598A9FBA2D2E4FB2D8B3693E79EA1865389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B64854413538E1713FCC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FC8E48D8FAA4D20A9F75ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4930A3850AC1BE2E735FC839A7D10C5E1E9C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0FECB2555BB02FD5A93B503F486389A921A5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5EC07BFC3B6B2E03A72EC98634DC7F73DD80F16079651AE17D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3488E5CD2E691F55664E60D62DBCD35BB62246164791C73A959720D72A7D852D1B9B012759BF2D58D81D7E09C32AA3244C329212FFA4ED0F681918F846A840A3B897FE24653F78E668FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojEcKN7r9rK/23Kpoate7g0A== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822789DA5C989B3F664F59F26D53AB8F1C53841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v8 07/14] test: fix luacheck warnings W231 in test/sql-tap X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! On 21.01.2021 13:50, sergeyb@tarantool.org wrote: > From: Sergey Bronnikov > > W231 (Local variable is set but never accessed) > > Part of #5464 > --- > diff --git a/test/sql-tap/e_expr.test.lua b/test/sql-tap/e_expr.test.lua > index 5f8b206d3..b488bdc60 100755 > --- a/test/sql-tap/e_expr.test.lua > +++ b/test/sql-tap/e_expr.test.lua > @@ -2554,9 +2550,6 @@ test:do_test( > -- evaluation of the THEN expression that corresponds to the first WHEN > -- expression that evaluates to true. > -- > -a = 0 > -b = 1 > -c = 0 These look like an artifact of a wrong conversion from TCL to Lua. The variables are used in the SQL statements. I think the converter thought it could just declare them as Lua variables to make visible in SQL. Better keep them and add MUST_WORK_TEST if it is not here yet. So in future we would see the expected variable values, and either decide fix the tests or delete them entirely. The latter can easily happen due to how much the type system was reworked. > test:do_execsql_test( > "e_expr-21.2.1", > [[