From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1D1E46EC5C; Sun, 28 Feb 2021 18:30:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1D1E46EC5C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1614526259; bh=EIVkrLrkndnUYmikCZHztW+8eveCQhjMYHE9f4IVFXE=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=LAZNaN+24nmMswGrKmZkMGWXHjsOq9heyPbjvJJ4PbtVz/5ACemoaN9SvNABo5O3R jkPRJAL5MA90yvjraP9hsISMyvVQl872i2p2ynpiJhzw31zIkdXEODVRFqyl1ZqrNv MvBWIUYmlldZy2L0KQlzR21ebYEC45Urz9ZHpacM= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A94DF6EC5C for ; Sun, 28 Feb 2021 18:30:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A94DF6EC5C Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lGO25-0000OS-46; Sun, 28 Feb 2021 18:30:57 +0300 To: Sergey Bronnikov , tarantool-patches@dev.tarantool.org References: <68a02630-efac-0e6c-d6ab-0af18d0192c1@tarantool.org> <33adda25-ba4d-b50c-575e-9dd30b38488a@tarantool.org> Message-ID: Date: Sun, 28 Feb 2021 16:30:56 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <33adda25-ba4d-b50c-575e-9dd30b38488a@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9795828B892398B724C36000F553DB7088BF2DEFE7247A74B182A05F538085040B83F01AB4B0B9E9188139D5CA213DDC238FC6E950859095B6BE62D0F7F190BFD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72F22E6DC541F75D9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378010A306A5B6F90A8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C25752893F242F32C55701F08599F0EE199B05BFD72A827B3A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7E9512AC99003B6BE9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C309122B91796FF21F117882F4460429728AD0CFFFB425014E868A13BD56FB6657A7F4EDE966BC389F9E8FC8737B5C2249B1CFA6D474D4A6A4089D37D7C0E48F6CCF19DD082D7633A0E7DDDDC251EA7DABAAAE862A0553A39223F8577A6DFFEA7C3B6C7E47A292E8D043847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148F3545B7F30541B7742623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5DB2DF3BB9F737C7F6AA4451BCBE609E6AE1100536052B0D6D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3498910055B812BD9CC9F70ED6A3A0CD87EBFFC0E1398D6F97CD9B5E1A3B07AF92F050BD43A35B51D31D7E09C32AA3244C19F60A696A8FC25CE98CC5EC5DA49BD0CE0B41342B755BCD729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojlGyyJLC51G8Z2bgp2uf7Tw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638228DBB022827C94CD7A20E72A77A2C10D03841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v8 04/14] test: fix luacheck warnings W211 in test/sql-tap X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the fixes! > --- a/test/sql-tap/select9.test.lua > +++ b/test/sql-tap/select9.test.lua > @@ -274,10 +274,8 @@ test:do_execsql_test( >          -- >      }) > > -local t1_space_id = "" > -local t2_space_id = "" > -t1_space_id = test:execsql([[SELECT * from "_space" where "name"='T1']])["id"] > -t2_space_id = test:execsql([[SELECT * from "_space" where "name"='T2']])["id"] > +local _ = test:execsql([[SELECT * from "_space" where "name"='T1']])["id"] > +local _ = test:execsql([[SELECT * from "_space" where "name"='T2']])["id"] But nothing changed. It was the same before my comment. By 'delete' them I mean literally 'delete'. SELECTs don't have any effect unlike DML/DDL. You can remove them and nothing will change. ==================== }) -local _ = test:execsql([[SELECT * from "_space" where "name"='T1']])["id"] -local _ = test:execsql([[SELECT * from "_space" where "name"='T2']])["id"] --X(276, "X!cmd", [=[["db","eval","SELECT * from _space where name='t2'","data","\n set t2_space_id $data(id)\n"]]=]) ==================== However even if we would would to keep them you wouldn't need `local _ = `. You can call functions without saving their result into a variable.