Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Максим Корякшин" <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 10/10] test: disable test/lua-Harness-tests/241-standalone.t on FreeBSD
Date: Thu, 29 Jul 2021 12:45:00 +0300
Message-ID: <YQJ4nE5+q863wvJF@root> (raw)
In-Reply-To: <1627551664.293003209@f306.i.mail.ru>

Hi, thanks for the fixes!

LGTM, except a few nits below.
On 29.07.21, Максим Корякшин wrote:
> 
> Hi! Thanks for the review, Sergey!
> Here is the diff, which adds a comment explaining the reason why the
> discussed assertion was masked:
> ======================================================================
> diff --git a/test/lua-Harness-tests/241-standalone.t b/test/lua-Harness-tests/241-standalone.t
> index bdd95514..742765d4 100755
> --- a/test/lua-Harness-tests/241-standalone.t
> +++ b/test/lua-Harness-tests/241-standalone.t
> @@ -112,6 +112,8 @@ f = io.popen(cmd)
>  equals(f:read'*l', 'Hello World', "redirect")
>  f:close()
> +-- FIXME Tarantool interactive mode misbehaviour has been found on

Typo: s/FIXME/FIXME:/

Nit: Also I suppose, that "has been found" can be dropped.
Feel free to ignore.

> +-- FreeBSD (for more info see #6231).

Typo: s/for more info see/for more info, see/

>  if jit.os ~= 'BSD' then
>      cmd = lua .. " -i hello-241.lua < hello-241.lua 2>&1"
>      f = io.popen(cmd)
> ======================================================================
>  
> And here is the new commit message with your comments in mind:
> ======================================================================
>     test: disable interactive mode assertion on BSD
>  
>     Tarantool interactive mode misbehaviour has been found on
>     FreeBSD (for more info see tarantool/tarantool#6231). Hence, this[1]
>     particular assertion is masked for FreeBSD until the mentioned issue
>     resolves.
>  
>     [1]:  https://framagit.org/fperrad/lua-Harness/-/blob/master/test_lua/241-standalone.t#L115-130
>  
>     Part of tarantool/tarantool#5970
>     Part of tarantool/tarantool#4473
>     Relates to tarantool/tarantool#6231
>  
> ======================================================================
> > 
> >> 
> >>>Hi!
> >>>Thanks for the patch!
> >>>
> >>>LGTM, except a few nits below.
> >>>
> >>>On 26.07.21, Максим Корякшин wrote:
> >>>>
> >>>> Sorry for the several emails, I have encountered some issues with the email client.
> >>>>  
> >>>> Anyway, here is the diff, that masks only one particular assertion instead of masking all of them:
> >>>> ========================================================================
> >>>> diff --git a/test/lua-Harness-tests/241-standalone.t b/test/lua-Harness-tests/241-standalone.t
> >>>> index d5373b9f..bdd95514 100755
> >>>> --- a/test/lua-Harness-tests/241-standalone.t
> >>>> +++ b/test/lua-Harness-tests/241-standalone.t
> >>>> @@ -51,10 +51,6 @@ if not pcall(io.popen, lua .. [[ -e "a=1"]]) then
> >>>>      skip_all "io.popen not supported"
> >>>>  end
> >>>> -if jit.os == 'BSD' then
> >>>> -    skip_all "BSD is not supported yet"
> >>>> -end
> >>>> -
> >>>>  plan'no_plan'
> >>>>  diag(lua)
> >>>> @@ -116,22 +112,24 @@ f = io.popen(cmd)
> >>>>  equals(f:read'*l', 'Hello World', "redirect")
> >>>>  f:close()
> >>>> -cmd = lua .. " -i hello-241.lua < hello-241.lua 2>&1"
> >>>> -f = io.popen(cmd)
> >>>> -matches(f:read'*l', banner, "-i")
> >>>> -if ujit then
> >>>> -    matches(f:read'*l', '^JIT:')
> >>>> -end
> >>>> -if ravi then
> >>>> -    matches(f:read'*l', '^Copyright %(C%)')
> >>>> -    matches(f:read'*l', '^Portions Copyright %(C%)')
> >>>> -    matches(f:read'*l', '^Options')
> >>>> -end
> >>>> -if _TARANTOOL then
> >>>> -    matches(f:read'*l', "^type 'help' for interactive help")
> >>>> +if jit.os ~= 'BSD' then
> >>>
> >>>Nit: Feel free to drop a comment here why this part is disabled for
> >>>FreeBSD (maybe with FIXME or XXX label).
> >>>
> >>>> +    cmd = lua .. " -i hello-241.lua < hello-241.lua 2>&1"
> >>>> +    f = io.popen(cmd)
> >>>> +    matches(f:read'*l', banner, "-i")
> >>>> +    if ujit then
> >>>> +        matches(f:read'*l', '^JIT:')
> >>>> +    end
> >>>> +    if ravi then
> >>>> +        matches(f:read'*l', '^Copyright %(C%)')
> >>>> +        matches(f:read'*l', '^Portions Copyright %(C%)')
> >>>> +        matches(f:read'*l', '^Options')
> >>>> +    end
> >>>> +    if _TARANTOOL then
> >>>> +        matches(f:read'*l', "^type 'help' for interactive help")
> >>>> +    end
> >>>> +    equals(f:read'*l', 'Hello World')
> >>>> +    f:close()
> >>>>  end
> >>>> -equals(f:read'*l', 'Hello World')
> >>>> -f:close()
> >>>>  cmd = lua .. [[ -e"a=1" -e "print(a)"]]
> >>>>  f = io.popen(cmd)
> >>>> ========================================================================
> >>>>  
> >>>> And here is the fixed commit message:
> >>>> ========================================================================
> >>>>     test: disable 241-standalone.t on FreeBSD
> >>>
> >>>Nit: Strictly saying the patch disables only interactive mode part with
> >>>input from the file.
> >>>
> >>>>  
> >>>>     Tarantool interactive mode misbehaviour has been found on
> >>>>     FreeBSD (for more info see tarantool/tarantool#6231). Hence, this[1]
> >>>>     particular assertion is masked for FreeBSD until the mentioned issue
> >>>>     resolves.
> >>>>  
> >>>>     [1]:  https://framagit.org/fperrad/lua-Harness/-/blob/master/test_lua/241-standalone.t#L115-130
> >>>>  
> >>>>     Part of tarantool/tarantool#5970
> >>>>     Part of tarantool/tarantool#4473
> >>>>     Relates to tarantool/tarantool#6231
> >>>>  
> >>>> ========================================================================
> >>>>  
> >>>> >Понедельник, 26 июля 2021, 15:32 +03:00 от Максим Корякшин < m.kokryashkin@tarantool.org >:
> >>>> > 
> >>>> >diff:
> >>>> > 
> >>>> > 
> >>>> >> 
> >>>> >>>Max,
> >>>> >>>
> >>>> >>>Thanks for the patch! Please consider the comments below.
> >>>> >>>
> >>>> >>>At first, commit subject exceeds 50 symbols and the message exceeds 72
> >>>> >>>symbols. Please check this patch against our guidelines[1].
> >>>> >>>
> >>>> >>>On 20.07.21, Maxim Kokryashkin wrote:
> >>>> >>>> Tarantool interactive mode misbehaviour has been found on FreeBSD (for more info see #6231).
> >>>> >>>
> >>>> >>>The issue is mentioned the wrong way. The right format is
> >>>> >>>tarantool/tarantool#6231.
> >>>> >>>
> >>>> >>>> Hence, this particular assertion is masked for FreeBSD until the mentioned issue resolves.
> >>>> >>>
> >>>> >>>Strictly saying, you skipped all assertions (not only those using broken
> >>>> >>>interactive mode), not the particular one.
> >>>> >>>
> >>>> >>>>
> >>>> >>>> Resolves #5970
> >>>> >>>
> >>>> >>>This patch doesn't resolve the issue, since Tarantool profile introduced
> >>>> >>>in "[PATCH v2 06/10] test: support tarantool in lua-Harness" is not used
> >>>> >>>by Tarantool CI. Hence this is only "Part of" patch.
> >>>> >>>
> >>>> >>>> Part of #4473
> >>>> >>>
> >>>> >>>BTW, both issues are also mentioned the wrong way. The right format is
> >>>> >>>tarantool/tarantool#<issue-number> for both cases (see the previous
> >>>> >>>patches in the series for the examples).
> >>>> >>>
> >>>> >>>It's also worth to add "Relates to tarantool/tarantool#6231".
> >>>> >>>
> >>>> >>>> ---
> >>>> >>>> Additional info:  https://github.com/tarantool/tarantool/issues/5970#issuecomment-883253400
> >>>> >>>>
> >>>> >>>> test/lua-Harness-tests/241-standalone.t | 4 ++++
> >>>> >>>> 1 file changed, 4 insertions(+)
> >>>> >>>>
> >>>> >>>> diff --git a/test/lua-Harness-tests/241-standalone.t b/test/lua-Harness-tests/241-standalone.t
> >>>> >>>> index afbcf5b8..d5373b9f 100755
> >>>> >>>> --- a/test/lua-Harness-tests/241-standalone.t
> >>>> >>>> +++ b/test/lua-Harness-tests/241-standalone.t
> >>>> >>>> @@ -51,6 +51,10 @@ if not pcall(io.popen, lua .. [[ -e "a=1"]]) then
> >>>> >>>> skip_all "io.popen not supported"
> >>>> >>>> end
> >>>> >>>>
> >>>> >>>> +if jit.os == 'BSD' then
> >>>> >>>> + skip_all "BSD is not supported yet"
> >>>> >>>> +end
> >>>> >>>
> >>>> >>>At first, please add a comment with the rationale for this change.
> >>>> >>>Furthermore, it's better to skip only assertions using interactive mode
> >>>> >>>and run other assertions related to CLI behaviour.
> >>>> >>>
> >>>> >>>> +
> >>>> >>>> plan'no_plan'
> >>>> >>>> diag(lua)
> >>>> >>>>
> >>>> >>>> --
> >>>> >>>> 2.32.0
> >>>> >>>>
> >>>> >>>
> >>>> >>>[1]:  https://www.tarantool.io/en/doc/latest/dev_guide/developer_guidelines/
> >>>> >>>
> >>>> >>>--
> >>>> >>>Best regards,
> >>>> >>>IM
> >>>> >> 
> >>>> > 
> >>>>  
> >>>
> >>>--
> >>>Best regards,
> >>>Sergey Kaplun
> >> 

-- 
Best regards,
Sergey Kaplun

  reply	other threads:[~2021-07-29  9:46 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20 16:26 [Tarantool-patches] [PATCH v2 00/10] test: lua-Harness suite patch bump Maxim Kokryashkin via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 01/10] test: port lua-Harness to Test.Assertion Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:08   ` Igor Munkin via Tarantool-patches
2021-07-26 10:38     ` Максим Корякшин via Tarantool-patches
2021-07-27  6:41       ` Sergey Kaplun via Tarantool-patches
2021-07-27 22:18         ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 02/10] test: rename lua-Harness tap to test_assertion Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:08   ` Igor Munkin via Tarantool-patches
2021-07-27  6:27   ` Sergey Kaplun via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 03/10] test: use CI friendly variables in lua-Harness Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:09   ` Igor Munkin via Tarantool-patches
2021-07-27  9:01     ` Sergey Kaplun via Tarantool-patches
2021-07-27 22:23       ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 04/10] test: refactor with _retrieve_progname Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:09   ` Igor Munkin via Tarantool-patches
2021-07-27  9:27     ` Sergey Kaplun via Tarantool-patches
2021-07-27 22:28       ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 05/10] test: refactor with _dofile Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:10   ` Igor Munkin via Tarantool-patches
2021-07-26 12:11     ` Максим Корякшин via Tarantool-patches
2021-07-27  9:34       ` Sergey Kaplun via Tarantool-patches
2021-07-27 22:36         ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 06/10] test: support tarantool in lua-Harness Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:11   ` Igor Munkin via Tarantool-patches
2021-07-26 11:07     ` Максим Корякшин via Tarantool-patches
2021-07-26 19:46       ` Igor Munkin via Tarantool-patches
2021-07-27 10:04   ` Sergey Kaplun via Tarantool-patches
2021-07-28 17:40     ` Максим Корякшин via Tarantool-patches
2021-07-28 17:42     ` Максим Корякшин via Tarantool-patches
2021-07-28 18:34       ` Sergey Kaplun via Tarantool-patches
2021-07-29  9:19         ` Максим Корякшин via Tarantool-patches
2021-07-29  9:22           ` Igor Munkin via Tarantool-patches
2021-07-29 10:12             ` Максим Корякшин via Tarantool-patches
2021-07-29  9:47           ` Sergey Kaplun via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 07/10] test: backport lua-Harness directory detection Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:12   ` Igor Munkin via Tarantool-patches
2021-07-26 11:13     ` Максим Корякшин via Tarantool-patches
2021-07-28 18:37       ` Sergey Kaplun via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 08/10] test: support tarantool cli in lua-Harness Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:13   ` Igor Munkin via Tarantool-patches
2021-07-26 11:17     ` Максим Корякшин via Tarantool-patches
2021-07-26 19:53       ` Igor Munkin via Tarantool-patches
2021-07-28 18:44       ` Sergey Kaplun via Tarantool-patches
2021-07-28 18:50         ` Sergey Kaplun via Tarantool-patches
2021-07-29  9:23         ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 09/10] test: update lua-Harness to b7b1a9a2 Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:14   ` Igor Munkin via Tarantool-patches
2021-07-26 12:21     ` Максим Корякшин via Tarantool-patches
2021-07-26 20:04       ` Igor Munkin via Tarantool-patches
2021-07-28 18:48       ` Sergey Kaplun via Tarantool-patches
2021-07-29  9:27         ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 10/10] test: disable test/lua-Harness-tests/241-standalone.t on FreeBSD Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:17   ` Igor Munkin via Tarantool-patches
2021-07-26 12:31     ` Максим Корякшин via Tarantool-patches
2021-07-26 12:32       ` Максим Корякшин via Tarantool-patches
2021-07-26 12:36         ` Максим Корякшин via Tarantool-patches
2021-07-26 20:13           ` Igor Munkin via Tarantool-patches
2021-07-27  6:21           ` Sergey Kaplun via Tarantool-patches
2021-07-29  9:41             ` Максим Корякшин via Tarantool-patches
2021-07-29  9:45               ` Sergey Kaplun via Tarantool-patches [this message]
2021-07-29  9:57                 ` Максим Корякшин via Tarantool-patches
2021-07-30 17:09                   ` Igor Munkin via Tarantool-patches
2021-07-25 21:03 ` [Tarantool-patches] [PATCH v2 00/10] test: lua-Harness suite patch bump Igor Munkin via Tarantool-patches
2021-07-30 19:19 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQJ4nE5+q863wvJF@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --cc=skaplun@tarantool.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Tarantool development patches archive

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lists.tarantool.org/tarantool-patches/0 tarantool-patches/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 tarantool-patches tarantool-patches/ https://lists.tarantool.org/tarantool-patches \
		tarantool-patches@dev.tarantool.org.
	public-inbox-index tarantool-patches

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git