From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9B5326EC55; Thu, 29 Jul 2021 12:46:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9B5326EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627551989; bh=2AIHF5KOoI3iJkvAZQOQk4rVf8/Z3rdgVTHmQIbc5vo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=eFuji3I38XN6X33OuoKXioRwQil+qSu3OJIEecNnHP/1NoeTlLPYC4JIwi0OzRDvK Z0Cldj+YDObMiOm2OR/eAecN/Lv+N8V9CzfrjObaUvaFjVNBwuBjrIhUbSc+mORfIj ZkNi8SiLqLQBqefT7eMyH6c0nQQC+D+kii8BRpcQ= Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2D6E36EC55 for ; Thu, 29 Jul 2021 12:46:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2D6E36EC55 Received: by smtp55.i.mail.ru with esmtpa (envelope-from ) id 1m92cG-0000uE-43; Thu, 29 Jul 2021 12:46:12 +0300 Date: Thu, 29 Jul 2021 12:45:00 +0300 To: =?utf-8?B?0JzQsNC60YHQuNC8INCa0L7RgNGP0LrRiNC40L0=?= Message-ID: References: <1627302979.755910918@f710.i.mail.ru> <1627551664.293003209@f306.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1627551664.293003209@f306.i.mail.ru> X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD941C43E597735A9C351B198F4576AC7B2770D7874BA03B4AE182A05F538085040CE3A34DD543F6B3058299F3241E244C91ED5C0A66B09594DB08F682DD90964C0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C2204D4F9A221771EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006377E3992E1815AFF058638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8AF93DC8F1ABE8A0BD219A0886ECF2510117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD1828451B159A507268D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B65D56369A3576CBA5089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5CEA520086E08230CDCE6749E7BF5E8C8DD7FA1EA452F76AED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA751B940EDA0DFB0535410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34181D1E89D5A0B42FA574E9D0B206897316D1312D01C5AE3219E78873BB949424346F9132F1E622881D7E09C32AA3244CE6F92AD0D456A614CBACB27AD889808C6C24832127668422FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPp/mPgZxawEzKXeRQKSvsg== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB41A38EA7E0E2430966B33C3316B48424D04176AAE5055CC72F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 10/10] test: disable test/lua-Harness-tests/241-standalone.t on FreeBSD X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, thanks for the fixes! LGTM, except a few nits below. On 29.07.21, Максим Корякшин wrote: > > Hi! Thanks for the review, Sergey! > Here is the diff, which adds a comment explaining the reason why the > discussed assertion was masked: > ====================================================================== > diff --git a/test/lua-Harness-tests/241-standalone.t b/test/lua-Harness-tests/241-standalone.t > index bdd95514..742765d4 100755 > --- a/test/lua-Harness-tests/241-standalone.t > +++ b/test/lua-Harness-tests/241-standalone.t > @@ -112,6 +112,8 @@ f = io.popen(cmd) >  equals(f:read'*l', 'Hello World', "redirect") >  f:close() > +-- FIXME Tarantool interactive mode misbehaviour has been found on Typo: s/FIXME/FIXME:/ Nit: Also I suppose, that "has been found" can be dropped. Feel free to ignore. > +-- FreeBSD (for more info see #6231). Typo: s/for more info see/for more info, see/ >  if jit.os ~= 'BSD' then >      cmd = lua .. " -i hello-241.lua < hello-241.lua 2>&1" >      f = io.popen(cmd) > ====================================================================== >   > And here is the new commit message with your comments in mind: > ====================================================================== >     test: disable interactive mode assertion on BSD >   >     Tarantool interactive mode misbehaviour has been found on >     FreeBSD (for more info see tarantool/tarantool#6231). Hence, this[1] >     particular assertion is masked for FreeBSD until the mentioned issue >     resolves. >   >     [1]: https://framagit.org/fperrad/lua-Harness/-/blob/master/test_lua/241-standalone.t#L115-130 >   >     Part of tarantool/tarantool#5970 >     Part of tarantool/tarantool#4473 >     Relates to tarantool/tarantool#6231 >   > ====================================================================== > >  > >>  > >>>Hi! > >>>Thanks for the patch! > >>> > >>>LGTM, except a few nits below. > >>> > >>>On 26.07.21, Максим Корякшин wrote: > >>>> > >>>> Sorry for the several emails, I have encountered some issues with the email client. > >>>>   > >>>> Anyway, here is the diff, that masks only one particular assertion instead of masking all of them: > >>>> ======================================================================== > >>>> diff --git a/test/lua-Harness-tests/241-standalone.t b/test/lua-Harness-tests/241-standalone.t > >>>> index d5373b9f..bdd95514 100755 > >>>> --- a/test/lua-Harness-tests/241-standalone.t > >>>> +++ b/test/lua-Harness-tests/241-standalone.t > >>>> @@ -51,10 +51,6 @@ if not pcall(io.popen, lua .. [[ -e "a=1"]]) then > >>>>      skip_all "io.popen not supported" > >>>>  end > >>>> -if jit.os == 'BSD' then > >>>> -    skip_all "BSD is not supported yet" > >>>> -end > >>>> - > >>>>  plan'no_plan' > >>>>  diag(lua) > >>>> @@ -116,22 +112,24 @@ f = io.popen(cmd) > >>>>  equals(f:read'*l', 'Hello World', "redirect") > >>>>  f:close() > >>>> -cmd = lua .. " -i hello-241.lua < hello-241.lua 2>&1" > >>>> -f = io.popen(cmd) > >>>> -matches(f:read'*l', banner, "-i") > >>>> -if ujit then > >>>> -    matches(f:read'*l', '^JIT:') > >>>> -end > >>>> -if ravi then > >>>> -    matches(f:read'*l', '^Copyright %(C%)') > >>>> -    matches(f:read'*l', '^Portions Copyright %(C%)') > >>>> -    matches(f:read'*l', '^Options') > >>>> -end > >>>> -if _TARANTOOL then > >>>> -    matches(f:read'*l', "^type 'help' for interactive help") > >>>> +if jit.os ~= 'BSD' then > >>> > >>>Nit: Feel free to drop a comment here why this part is disabled for > >>>FreeBSD (maybe with FIXME or XXX label). > >>> > >>>> +    cmd = lua .. " -i hello-241.lua < hello-241.lua 2>&1" > >>>> +    f = io.popen(cmd) > >>>> +    matches(f:read'*l', banner, "-i") > >>>> +    if ujit then > >>>> +        matches(f:read'*l', '^JIT:') > >>>> +    end > >>>> +    if ravi then > >>>> +        matches(f:read'*l', '^Copyright %(C%)') > >>>> +        matches(f:read'*l', '^Portions Copyright %(C%)') > >>>> +        matches(f:read'*l', '^Options') > >>>> +    end > >>>> +    if _TARANTOOL then > >>>> +        matches(f:read'*l', "^type 'help' for interactive help") > >>>> +    end > >>>> +    equals(f:read'*l', 'Hello World') > >>>> +    f:close() > >>>>  end > >>>> -equals(f:read'*l', 'Hello World') > >>>> -f:close() > >>>>  cmd = lua .. [[ -e"a=1" -e "print(a)"]] > >>>>  f = io.popen(cmd) > >>>> ======================================================================== > >>>>   > >>>> And here is the fixed commit message: > >>>> ======================================================================== > >>>>     test: disable 241-standalone.t on FreeBSD > >>> > >>>Nit: Strictly saying the patch disables only interactive mode part with > >>>input from the file. > >>> > >>>>   > >>>>     Tarantool interactive mode misbehaviour has been found on > >>>>     FreeBSD (for more info see tarantool/tarantool#6231). Hence, this[1] > >>>>     particular assertion is masked for FreeBSD until the mentioned issue > >>>>     resolves. > >>>>   > >>>>     [1]: https://framagit.org/fperrad/lua-Harness/-/blob/master/test_lua/241-standalone.t#L115-130 > >>>>   > >>>>     Part of tarantool/tarantool#5970 > >>>>     Part of tarantool/tarantool#4473 > >>>>     Relates to tarantool/tarantool#6231 > >>>>   > >>>> ======================================================================== > >>>>   > >>>> >Понедельник, 26 июля 2021, 15:32 +03:00 от Максим Корякшин < m.kokryashkin@tarantool.org >: > >>>> >  > >>>> >diff: > >>>> >  > >>>> >  > >>>> >>  > >>>> >>>Max, > >>>> >>> > >>>> >>>Thanks for the patch! Please consider the comments below. > >>>> >>> > >>>> >>>At first, commit subject exceeds 50 symbols and the message exceeds 72 > >>>> >>>symbols. Please check this patch against our guidelines[1]. > >>>> >>> > >>>> >>>On 20.07.21, Maxim Kokryashkin wrote: > >>>> >>>> Tarantool interactive mode misbehaviour has been found on FreeBSD (for more info see #6231). > >>>> >>> > >>>> >>>The issue is mentioned the wrong way. The right format is > >>>> >>>tarantool/tarantool#6231. > >>>> >>> > >>>> >>>> Hence, this particular assertion is masked for FreeBSD until the mentioned issue resolves. > >>>> >>> > >>>> >>>Strictly saying, you skipped all assertions (not only those using broken > >>>> >>>interactive mode), not the particular one. > >>>> >>> > >>>> >>>> > >>>> >>>> Resolves #5970 > >>>> >>> > >>>> >>>This patch doesn't resolve the issue, since Tarantool profile introduced > >>>> >>>in "[PATCH v2 06/10] test: support tarantool in lua-Harness" is not used > >>>> >>>by Tarantool CI. Hence this is only "Part of" patch. > >>>> >>> > >>>> >>>> Part of #4473 > >>>> >>> > >>>> >>>BTW, both issues are also mentioned the wrong way. The right format is > >>>> >>>tarantool/tarantool# for both cases (see the previous > >>>> >>>patches in the series for the examples). > >>>> >>> > >>>> >>>It's also worth to add "Relates to tarantool/tarantool#6231". > >>>> >>> > >>>> >>>> --- > >>>> >>>> Additional info: https://github.com/tarantool/tarantool/issues/5970#issuecomment-883253400 > >>>> >>>> > >>>> >>>> test/lua-Harness-tests/241-standalone.t | 4 ++++ > >>>> >>>> 1 file changed, 4 insertions(+) > >>>> >>>> > >>>> >>>> diff --git a/test/lua-Harness-tests/241-standalone.t b/test/lua-Harness-tests/241-standalone.t > >>>> >>>> index afbcf5b8..d5373b9f 100755 > >>>> >>>> --- a/test/lua-Harness-tests/241-standalone.t > >>>> >>>> +++ b/test/lua-Harness-tests/241-standalone.t > >>>> >>>> @@ -51,6 +51,10 @@ if not pcall(io.popen, lua .. [[ -e "a=1"]]) then > >>>> >>>> skip_all "io.popen not supported" > >>>> >>>> end > >>>> >>>> > >>>> >>>> +if jit.os == 'BSD' then > >>>> >>>> + skip_all "BSD is not supported yet" > >>>> >>>> +end > >>>> >>> > >>>> >>>At first, please add a comment with the rationale for this change. > >>>> >>>Furthermore, it's better to skip only assertions using interactive mode > >>>> >>>and run other assertions related to CLI behaviour. > >>>> >>> > >>>> >>>> + > >>>> >>>> plan'no_plan' > >>>> >>>> diag(lua) > >>>> >>>> > >>>> >>>> -- > >>>> >>>> 2.32.0 > >>>> >>>> > >>>> >>> > >>>> >>>[1]: https://www.tarantool.io/en/doc/latest/dev_guide/developer_guidelines/ > >>>> >>> > >>>> >>>-- > >>>> >>>Best regards, > >>>> >>>IM > >>>> >>  > >>>> >  > >>>>   > >>> > >>>-- > >>>Best regards, > >>>Sergey Kaplun > >>  -- Best regards, Sergey Kaplun