From: "Максим Корякшин via Tarantool-patches" <tarantool-patches@dev.tarantool.org>
To: "Sergey Kaplun" <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 09/10] test: update lua-Harness to b7b1a9a2
Date: Thu, 29 Jul 2021 12:27:08 +0300 [thread overview]
Message-ID: <1627550828.581809254@f434.i.mail.ru> (raw)
In-Reply-To: <YQGmiFqYqimAazts@root>
[-- Attachment #1: Type: text/plain, Size: 6571 bytes --]
Hi! Thanks for the review, Sergey!
New commit message:
==============================================================
test: update lua-Harness to c4451fe
This patch backports several small commits from the lua-Harness suite:
- follow ravi 1.0-beta4[1]
- refactor with near[2]
- follow LuaJIT[3]
- fix when no debug[4]
- check if luac exists[5]
- https[6]
- more assert[7]
[1]: https://framagit.org/fperrad/lua-Harness/-/commit/9455281b
[2]: https://framagit.org/fperrad/lua-Harness/-/commit/70404580
[3]: https://framagit.org/fperrad/lua-Harness/-/commit/ac7671b6
[4]: https://framagit.org/fperrad/lua-Harness/-/commit/4db7e539
[5]: https://framagit.org/fperrad/lua-Harness/-/commit/97e9e4c1
[6]: https://framagit.org/fperrad/lua-Harness/-/commit/673c7869
[7]: https://framagit.org/fperrad/lua-Harness/-/commit/b7b1a9a2
Part of tarantool/tarantool#5970
Part of tarantool/tarantool#4473
==============================================================
>
>>Hi, Maxim!
>>
>>LGTM, except a single nitpick regarding the commit message.
>>
>>On 26.07.21, Максим Корякшин wrote:
>>>
>>> Thanks for the review, Igor!
>>> New commit message, considering your suggestions:
>>> =============================================================
>>> test: update lua-Harness to c4451fe
>>>
>>> This patch backports several small commits from lua-Harness suite:
>>
>>Typo: s/from lua-Harness suite/from the lua-Harness suite/
>>
>>> - follow ravi 1.0-beta4[1]
>>> - refactor with near[2]
>>> - follow LuaJIT[3]
>>> - fix when no debug[4]
>>> - check if luac exists[5]
>>> - https[6]
>>> - more assert[7]
>>>
>>> [1]: https://framagit.org/fperrad/lua-Harness/-/commit/9455281b
>>> [2]: https://framagit.org/fperrad/lua-Harness/-/commit/70404580
>>> [3]: https://framagit.org/fperrad/lua-Harness/-/commit/ac7671b6
>>> [4]: https://framagit.org/fperrad/lua-Harness/-/commit/4db7e539
>>> [5]: https://framagit.org/fperrad/lua-Harness/-/commit/97e9e4c1
>>> [6]: https://framagit.org/fperrad/lua-Harness/-/commit/673c7869
>>> [7]: https://framagit.org/fperrad/lua-Harness/-/commit/b7b1a9a2
>>>
>>> Part of tarantool/tarantool#5970
>>> Part of tarantool/tarantool#4473
>>>
>>> =============================================================
>>>
>>> And here is the diff, which will add missing changes:
>>> =============================================================
>>> diff --git a/test/lua-Harness-tests/301-basic.t b/test/lua-Harness-tests/301-basic.t
>>> index 4adbb55c..e4ed2c41 100755
>>> --- a/test/lua-Harness-tests/301-basic.t
>>> +++ b/test/lua-Harness-tests/301-basic.t
>>> @@ -53,13 +53,15 @@ local lua = _retrieve_progname()
>>> plan'no_plan'
>>> do -- assert
>>> - local v, msg = assert('text', "assert string")
>>> + local v, msg, extra = assert('text', "assert string", 'extra')
>>> equals(v, 'text', "function assert")
>>> equals(msg, "assert string")
>>> - v, msg = assert({}, "assert table")
>>> + equals(extra, 'extra')
>>> + v, msg, extra = assert({}, "assert table", 'extra')
>>> equals(msg, "assert table")
>>> + equals(extra, 'extra')
>>> - error_matches(function () assert(false, "ASSERTION TEST") end,
>>> + error_matches(function () assert(false, "ASSERTION TEST", 'extra') end,
>>> "^[^:]+:%d+: ASSERTION TEST",
>>> "function assert(false, msg)")
>>> @@ -73,7 +75,7 @@ do -- assert
>>> else
>>> error_matches(function () assert(false, 42) end,
>>> "^[^:]+:%d+: 42",
>>> - "function assert(false, 42)")
>>> + "function assert(false, 42) --> invalid")
>>> end
>>> if has_error53 then
>>> =============================================================
>>>
>>>
>>>
>>> >Max,
>>> >
>>> >Thanks for the patch! Please consider the comments below.
>>> >
>>> >On 20.07.21, Maxim Kokryashkin wrote:
>>> >> This patch backports several small commits from lua-Harness suite:
>>> >> - follow ravi 1.0-beta4[1]
>>> >> - refactor with near[2]
>>> >> - follow LuaJIT[3]
>>> >> - fix when no debug[4]
>>> >> - check if luac exists[5]
>>> >> - https[6]
>>> >> - more assert[7]
>>> >>
>>> >> [1]: https://framagit.org/fperrad/lua-Harness/-/commit/9455281b
>>> >> [2]: https://framagit.org/fperrad/lua-Harness/-/commit/70404580
>>> >> [3]: https://framagit.org/fperrad/lua-Harness/-/commit/ac7671b6
>>> >> [4]: https://framagit.org/fperrad/lua-Harness/-/commit/4db7e539
>>> >> [5]: https://framagit.org/fperrad/lua-Harness/-/commit/97e9e4c1
>>> >> [6]: https://framagit.org/fperrad/lua-Harness/-/commit/673c7869
>>> >> [7]: https://framagit.org/fperrad/lua-Harness/-/commit/b7b1a9a2
>>> >
>>> >The changes from the latter commit is missing.
>>> >
>>> >Furthermore, you've updated lua-Harness up to c4451fe, which is
>>> >backported in scope of "[PATCH v2 01/10] test: port lua-Harness to
>>> >Test.Assertion". Hence, the commit subject need to be updated too.
>>> >
>>> >>
>>> >> Part of #5970
>>> >> Part of #4473
>>> >
>>> >BTW, both issues are also mentioned the wrong way. The right format is
>>> >tarantool/tarantool#<issue-number> for both cases (see the previous
>>> >patches in the series for the examples).
>>> >
>>> >> ---
>>> >> test/lua-Harness-tests/200-examples.t | 2 +-
>>> >> test/lua-Harness-tests/203-lexico.t | 2 +-
>>> >> test/lua-Harness-tests/241-standalone.t | 3 +-
>>> >> test/lua-Harness-tests/242-luac.t | 4 +++
>>> >> test/lua-Harness-tests/301-basic.t | 2 +-
>>> >> test/lua-Harness-tests/304-string.t | 2 +-
>>> >> test/lua-Harness-tests/307-math.t | 44 +++++++++++------------
>>> >> test/lua-Harness-tests/310-debug.t | 2 --
>>> >> test/lua-Harness-tests/320-stdin.t | 14 +++++---
>>> >> test/lua-Harness-tests/401-bitop.t | 2 +-
>>> >> test/lua-Harness-tests/402-ffi.t | 2 +-
>>> >> test/lua-Harness-tests/403-jit.t | 2 +-
>>> >> test/lua-Harness-tests/404-ext.t | 2 +-
>>> >> test/lua-Harness-tests/411-luajit.t | 2 +-
>>> >> test/lua-Harness-tests/profile_ravi.lua | 4 +--
>>> >> test/lua-Harness-tests/test_assertion.lua | 9 +++++
>>> >> 16 files changed, 57 insertions(+), 41 deletions(-)
>>> >>
>>> >
>>> ><snipped>
>>> >
>>> >> --
>>> >> 2.32.0
>>> >>
>>> >
>>> >--
>>> >Best regards,
>>> >IM
>>>
>>
>>--
>>Best regards,
>>Sergey Kaplun
>
[-- Attachment #2: Type: text/html, Size: 9944 bytes --]
next prev parent reply other threads:[~2021-07-29 9:27 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 16:26 [Tarantool-patches] [PATCH v2 00/10] test: lua-Harness suite patch bump Maxim Kokryashkin via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 01/10] test: port lua-Harness to Test.Assertion Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:08 ` Igor Munkin via Tarantool-patches
2021-07-26 10:38 ` Максим Корякшин via Tarantool-patches
2021-07-27 6:41 ` Sergey Kaplun via Tarantool-patches
2021-07-27 22:18 ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 02/10] test: rename lua-Harness tap to test_assertion Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:08 ` Igor Munkin via Tarantool-patches
2021-07-27 6:27 ` Sergey Kaplun via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 03/10] test: use CI friendly variables in lua-Harness Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:09 ` Igor Munkin via Tarantool-patches
2021-07-27 9:01 ` Sergey Kaplun via Tarantool-patches
2021-07-27 22:23 ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 04/10] test: refactor with _retrieve_progname Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:09 ` Igor Munkin via Tarantool-patches
2021-07-27 9:27 ` Sergey Kaplun via Tarantool-patches
2021-07-27 22:28 ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 05/10] test: refactor with _dofile Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:10 ` Igor Munkin via Tarantool-patches
2021-07-26 12:11 ` Максим Корякшин via Tarantool-patches
2021-07-27 9:34 ` Sergey Kaplun via Tarantool-patches
2021-07-27 22:36 ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 06/10] test: support tarantool in lua-Harness Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:11 ` Igor Munkin via Tarantool-patches
2021-07-26 11:07 ` Максим Корякшин via Tarantool-patches
2021-07-26 19:46 ` Igor Munkin via Tarantool-patches
2021-07-27 10:04 ` Sergey Kaplun via Tarantool-patches
2021-07-28 17:40 ` Максим Корякшин via Tarantool-patches
2021-07-28 17:42 ` Максим Корякшин via Tarantool-patches
2021-07-28 18:34 ` Sergey Kaplun via Tarantool-patches
2021-07-29 9:19 ` Максим Корякшин via Tarantool-patches
2021-07-29 9:22 ` Igor Munkin via Tarantool-patches
2021-07-29 10:12 ` Максим Корякшин via Tarantool-patches
2021-07-29 9:47 ` Sergey Kaplun via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 07/10] test: backport lua-Harness directory detection Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:12 ` Igor Munkin via Tarantool-patches
2021-07-26 11:13 ` Максим Корякшин via Tarantool-patches
2021-07-28 18:37 ` Sergey Kaplun via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 08/10] test: support tarantool cli in lua-Harness Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:13 ` Igor Munkin via Tarantool-patches
2021-07-26 11:17 ` Максим Корякшин via Tarantool-patches
2021-07-26 19:53 ` Igor Munkin via Tarantool-patches
2021-07-28 18:44 ` Sergey Kaplun via Tarantool-patches
2021-07-28 18:50 ` Sergey Kaplun via Tarantool-patches
2021-07-29 9:23 ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 09/10] test: update lua-Harness to b7b1a9a2 Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:14 ` Igor Munkin via Tarantool-patches
2021-07-26 12:21 ` Максим Корякшин via Tarantool-patches
2021-07-26 20:04 ` Igor Munkin via Tarantool-patches
2021-07-28 18:48 ` Sergey Kaplun via Tarantool-patches
2021-07-29 9:27 ` Максим Корякшин via Tarantool-patches [this message]
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 10/10] test: disable test/lua-Harness-tests/241-standalone.t on FreeBSD Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:17 ` Igor Munkin via Tarantool-patches
2021-07-26 12:31 ` Максим Корякшин via Tarantool-patches
2021-07-26 12:32 ` Максим Корякшин via Tarantool-patches
2021-07-26 12:36 ` Максим Корякшин via Tarantool-patches
2021-07-26 20:13 ` Igor Munkin via Tarantool-patches
2021-07-27 6:21 ` Sergey Kaplun via Tarantool-patches
2021-07-29 9:41 ` Максим Корякшин via Tarantool-patches
2021-07-29 9:45 ` Sergey Kaplun via Tarantool-patches
2021-07-29 9:57 ` Максим Корякшин via Tarantool-patches
2021-07-30 17:09 ` Igor Munkin via Tarantool-patches
2021-07-25 21:03 ` [Tarantool-patches] [PATCH v2 00/10] test: lua-Harness suite patch bump Igor Munkin via Tarantool-patches
2021-07-30 19:19 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1627550828.581809254@f434.i.mail.ru \
--to=tarantool-patches@dev.tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 09/10] test: update lua-Harness to b7b1a9a2' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox