Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 05/10] test: refactor with _dofile
Date: Mon, 26 Jul 2021 00:10:51 +0300	[thread overview]
Message-ID: <20210725211051.GG27855@tarantool.org> (raw)
In-Reply-To: <34c2c2f332776613a3fd456ea62d00e892ad6369.1626797225.git.m.kokryashkin@tarantool.org>

Max,

Thanks for the fixes! LGTM, except the three typos in
luajit-test-init.lua.

On 20.07.21, Maxim Kokryashkin wrote:
> The patch[1] from lua-Harness suite is quite similar to commit
> d11c5bbc08a118b11167c5d455d4024607dab662 ('test: adjust lua-Harness
> tests that use dofile'), with the one difference (except the naming):
> `make_specific_checks()` provides the particular behaviour to run the
> tests for out-of-source build, however `_dofile()` allows user to
> overload this function considering his purposes. If user leave
> `_dofile()` untouched, it defaults to `dofile()` Lua standard library
> function.
> 
> It's worth to mention, that LuaJIT testing machinery has been using
> such approach since commit 734cc0f1d508429c2c3c46bd1860398db0051060
> ('test: adapt PUC-Rio suite for out-of-source build') and `_dofile()`
> behaviour for running tests when out of source build is used is
> already defined in luajit-test-init.lua.
> 
> [1]: https://framagit.org/fperrad/lua-Harness/-/commit/60da289
> 
> Part of tarantool/tarantool#5970
> Part of tarantool/tarantool#4473
> ---
>  test/lua-Harness-tests/101-boolean.t      |  2 +-
>  test/lua-Harness-tests/102-function.t     |  2 +-
>  test/lua-Harness-tests/103-nil.t          |  2 +-
>  test/lua-Harness-tests/104-number.t       |  2 +-
>  test/lua-Harness-tests/105-string.t       |  2 +-
>  test/lua-Harness-tests/106-table.t        |  2 +-
>  test/lua-Harness-tests/107-thread.t       |  2 +-
>  test/lua-Harness-tests/108-userdata.t     |  2 +-
>  test/lua-Harness-tests/203-lexico.t       |  8 ++++----
>  test/lua-Harness-tests/231-metatable.t    |  2 +-
>  test/lua-Harness-tests/301-basic.t        |  2 +-
>  test/lua-Harness-tests/305-utf8.t         |  4 ++--
>  test/lua-Harness-tests/404-ext.t          |  2 +-
>  test/lua-Harness-tests/test_assertion.lua | 10 ++--------
>  test/luajit-test-init.lua                 |  2 ++
>  15 files changed, 21 insertions(+), 25 deletions(-)
> 

<snipped>

> diff --git a/test/luajit-test-init.lua b/test/luajit-test-init.lua
> index 54a1f815..feec17cf 100644
> --- a/test/luajit-test-init.lua
> +++ b/test/luajit-test-init.lua
> @@ -2,6 +2,8 @@
>  -- `_loadfile()` exists and uses it for code loading from test
>  -- files. If the variable is not defined then suite uses
>  -- `loadfile()` as default. Same for the `_dofile()`.
> +-- Lua-Harness also uses the same implementation of `dofile()`

Typo: s/Lua-Harness/lua-Harness/.

> +-- fot he same reason

Typo: s/fot/for/.
Typo: Dot is missing at the end of the sentence.

>  
>  -- XXX: Some tests in PUC Rio Lua 5.1 test suite clean `arg`
>  -- variable, so evaluate this once and use later.
> -- 
> 2.32.0
> 

-- 
Best regards,
IM

  reply	other threads:[~2021-07-25 21:34 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20 16:26 [Tarantool-patches] [PATCH v2 00/10] test: lua-Harness suite patch bump Maxim Kokryashkin via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 01/10] test: port lua-Harness to Test.Assertion Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:08   ` Igor Munkin via Tarantool-patches
2021-07-26 10:38     ` Максим Корякшин via Tarantool-patches
2021-07-27  6:41       ` Sergey Kaplun via Tarantool-patches
2021-07-27 22:18         ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 02/10] test: rename lua-Harness tap to test_assertion Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:08   ` Igor Munkin via Tarantool-patches
2021-07-27  6:27   ` Sergey Kaplun via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 03/10] test: use CI friendly variables in lua-Harness Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:09   ` Igor Munkin via Tarantool-patches
2021-07-27  9:01     ` Sergey Kaplun via Tarantool-patches
2021-07-27 22:23       ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 04/10] test: refactor with _retrieve_progname Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:09   ` Igor Munkin via Tarantool-patches
2021-07-27  9:27     ` Sergey Kaplun via Tarantool-patches
2021-07-27 22:28       ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 05/10] test: refactor with _dofile Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:10   ` Igor Munkin via Tarantool-patches [this message]
2021-07-26 12:11     ` Максим Корякшин via Tarantool-patches
2021-07-27  9:34       ` Sergey Kaplun via Tarantool-patches
2021-07-27 22:36         ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 06/10] test: support tarantool in lua-Harness Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:11   ` Igor Munkin via Tarantool-patches
2021-07-26 11:07     ` Максим Корякшин via Tarantool-patches
2021-07-26 19:46       ` Igor Munkin via Tarantool-patches
2021-07-27 10:04   ` Sergey Kaplun via Tarantool-patches
2021-07-28 17:40     ` Максим Корякшин via Tarantool-patches
2021-07-28 17:42     ` Максим Корякшин via Tarantool-patches
2021-07-28 18:34       ` Sergey Kaplun via Tarantool-patches
2021-07-29  9:19         ` Максим Корякшин via Tarantool-patches
2021-07-29  9:22           ` Igor Munkin via Tarantool-patches
2021-07-29 10:12             ` Максим Корякшин via Tarantool-patches
2021-07-29  9:47           ` Sergey Kaplun via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 07/10] test: backport lua-Harness directory detection Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:12   ` Igor Munkin via Tarantool-patches
2021-07-26 11:13     ` Максим Корякшин via Tarantool-patches
2021-07-28 18:37       ` Sergey Kaplun via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 08/10] test: support tarantool cli in lua-Harness Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:13   ` Igor Munkin via Tarantool-patches
2021-07-26 11:17     ` Максим Корякшин via Tarantool-patches
2021-07-26 19:53       ` Igor Munkin via Tarantool-patches
2021-07-28 18:44       ` Sergey Kaplun via Tarantool-patches
2021-07-28 18:50         ` Sergey Kaplun via Tarantool-patches
2021-07-29  9:23         ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 09/10] test: update lua-Harness to b7b1a9a2 Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:14   ` Igor Munkin via Tarantool-patches
2021-07-26 12:21     ` Максим Корякшин via Tarantool-patches
2021-07-26 20:04       ` Igor Munkin via Tarantool-patches
2021-07-28 18:48       ` Sergey Kaplun via Tarantool-patches
2021-07-29  9:27         ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 10/10] test: disable test/lua-Harness-tests/241-standalone.t on FreeBSD Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:17   ` Igor Munkin via Tarantool-patches
2021-07-26 12:31     ` Максим Корякшин via Tarantool-patches
2021-07-26 12:32       ` Максим Корякшин via Tarantool-patches
2021-07-26 12:36         ` Максим Корякшин via Tarantool-patches
2021-07-26 20:13           ` Igor Munkin via Tarantool-patches
2021-07-27  6:21           ` Sergey Kaplun via Tarantool-patches
2021-07-29  9:41             ` Максим Корякшин via Tarantool-patches
2021-07-29  9:45               ` Sergey Kaplun via Tarantool-patches
2021-07-29  9:57                 ` Максим Корякшин via Tarantool-patches
2021-07-30 17:09                   ` Igor Munkin via Tarantool-patches
2021-07-25 21:03 ` [Tarantool-patches] [PATCH v2 00/10] test: lua-Harness suite patch bump Igor Munkin via Tarantool-patches
2021-07-30 19:19 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210725211051.GG27855@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2 05/10] test: refactor with _dofile' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox