Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Максим Корякшин" <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 08/10] test: support tarantool cli in lua-Harness
Date: Wed, 28 Jul 2021 21:44:14 +0300
Message-ID: <YQGlfiZwfxcyTwy7@root> (raw)
In-Reply-To: <1627298220.392923948@f312.i.mail.ru>

Hi, Maxim!

Thanks for the patch and fixes!

LGTM, except a few nits regarding to the commit message.

On 26.07.21, Максим Корякшин wrote:
> 
> Thanks for the review, Igor!
> Here is the new commit message, considering your comments:
> =================================================
>     test: support tarantool cli in lua-Harness
>  
>     The patch[1] from lua-Harness suite adjusts some checks in

Typo: s/from lua-Harness suite/the from lua-Harness suite/

>     lua-Harness tests, so they are compatible with Tarantool now.
>  
>     As a result, the introduced assertion for Tarantool error message fails
>     on MacOS, since getopt_long(3) yields the error message without single
>     quotes wrapping the flag. Hence, this commit also includes fix for that

Typo: s/fix/the fix/

>     from patch[2] in the trunk.

Typo: s/patch/the patch/

>  
>     [1]: https://framagit.org/fperrad/lua-Harness/-/commit/1da5b1b
>     [2]:  https://framagit.org/fperrad/lua-Harness/-/commit/a0532c5
>  
>     Part of tarantool/tarantool#5970
>     Part of tarantool/tarantool#4473
>  
> =================================================
>  
>   
> >Понедельник, 26 июля 2021, 0:37 +03:00 от Igor Munkin <imun@tarantool.org>:
> > 
> >Max,
> >
> >Thanks for the patch! The changes are fine, but please consider the
> >comments below regarding the commit message.
> >
> >On 20.07.21, Maxim Kokryashkin wrote:
> >> The patch[1] from lua-Harness suite adds some specific checks to
> >> lua-Harness tests, so they are compatible with Tarantool now.
> >
> >Strictly saying, no *new* checks are *added*, but the *existing* ones
> >are *adjusted* considering Tarantool specifics.
> >
> >>
> >> Considering this, commit d4e12d7ac28e3bc857d30971dd77deec66a67297('test:
> >> disable LuaJIT CLI tests in lua-Harness suite'), which disabled
> >> tarantool cli tests, can be superseded.
> >
> >No, it can't. The mentioned commit is superseded by "[PATCH v2 06/10]
> >test: support tarantool in lua-Harness" in this series.
> >
> >>
> >> As a result, the introduced assertion for Tarantool error message fails
> >> on MacOS, since getopt_long(3) yields the error message without single
> >> quotes wrapping the flag. Hence, this commit also includes fix for that
> >> from patch[2] in the trunk.
> >>
> >> [1]:  https://framagit.org/fperrad/lua-Harness/-/commit/1da5b1b3
> >
> >Minor: 7 digits are enough. This is not critical, but just odd to have
> >two similar links with the different number of digits, so feel free to
> >ignore this nit.
> >
> >> [2]:  https://framagit.org/fperrad/lua-Harness/-/commit/a0532c5
> >
> >Please mention the related issues: #5970 and #4473.
> >
> >> ---
> >> Additional information on issue with MacOS:
> >>  https://github.com/tarantool/tarantool/issues/5970#issuecomment-880158605
> >>
> >> NOTICE: tests for this separate commit are failing on FreeBSD
> >>
> >> test/lua-Harness-tests/241-standalone.t | 79 +++++++++++++++++++------
> >> 1 file changed, 61 insertions(+), 18 deletions(-)
> >>
> >
> ><snipped>
> >
> >> --
> >> 2.32.0
> >>
> >
> >--
> >Best regards,
> >IM
>  

-- 
Best regards,
Sergey Kaplun

  parent reply	other threads:[~2021-07-28 18:45 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20 16:26 [Tarantool-patches] [PATCH v2 00/10] test: lua-Harness suite patch bump Maxim Kokryashkin via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 01/10] test: port lua-Harness to Test.Assertion Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:08   ` Igor Munkin via Tarantool-patches
2021-07-26 10:38     ` Максим Корякшин via Tarantool-patches
2021-07-27  6:41       ` Sergey Kaplun via Tarantool-patches
2021-07-27 22:18         ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 02/10] test: rename lua-Harness tap to test_assertion Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:08   ` Igor Munkin via Tarantool-patches
2021-07-27  6:27   ` Sergey Kaplun via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 03/10] test: use CI friendly variables in lua-Harness Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:09   ` Igor Munkin via Tarantool-patches
2021-07-27  9:01     ` Sergey Kaplun via Tarantool-patches
2021-07-27 22:23       ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 04/10] test: refactor with _retrieve_progname Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:09   ` Igor Munkin via Tarantool-patches
2021-07-27  9:27     ` Sergey Kaplun via Tarantool-patches
2021-07-27 22:28       ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 05/10] test: refactor with _dofile Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:10   ` Igor Munkin via Tarantool-patches
2021-07-26 12:11     ` Максим Корякшин via Tarantool-patches
2021-07-27  9:34       ` Sergey Kaplun via Tarantool-patches
2021-07-27 22:36         ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 06/10] test: support tarantool in lua-Harness Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:11   ` Igor Munkin via Tarantool-patches
2021-07-26 11:07     ` Максим Корякшин via Tarantool-patches
2021-07-26 19:46       ` Igor Munkin via Tarantool-patches
2021-07-27 10:04   ` Sergey Kaplun via Tarantool-patches
2021-07-28 17:40     ` Максим Корякшин via Tarantool-patches
2021-07-28 17:42     ` Максим Корякшин via Tarantool-patches
2021-07-28 18:34       ` Sergey Kaplun via Tarantool-patches
2021-07-29  9:19         ` Максим Корякшин via Tarantool-patches
2021-07-29  9:22           ` Igor Munkin via Tarantool-patches
2021-07-29 10:12             ` Максим Корякшин via Tarantool-patches
2021-07-29  9:47           ` Sergey Kaplun via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 07/10] test: backport lua-Harness directory detection Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:12   ` Igor Munkin via Tarantool-patches
2021-07-26 11:13     ` Максим Корякшин via Tarantool-patches
2021-07-28 18:37       ` Sergey Kaplun via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 08/10] test: support tarantool cli in lua-Harness Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:13   ` Igor Munkin via Tarantool-patches
2021-07-26 11:17     ` Максим Корякшин via Tarantool-patches
2021-07-26 19:53       ` Igor Munkin via Tarantool-patches
2021-07-28 18:44       ` Sergey Kaplun via Tarantool-patches [this message]
2021-07-28 18:50         ` Sergey Kaplun via Tarantool-patches
2021-07-29  9:23         ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 09/10] test: update lua-Harness to b7b1a9a2 Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:14   ` Igor Munkin via Tarantool-patches
2021-07-26 12:21     ` Максим Корякшин via Tarantool-patches
2021-07-26 20:04       ` Igor Munkin via Tarantool-patches
2021-07-28 18:48       ` Sergey Kaplun via Tarantool-patches
2021-07-29  9:27         ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 10/10] test: disable test/lua-Harness-tests/241-standalone.t on FreeBSD Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:17   ` Igor Munkin via Tarantool-patches
2021-07-26 12:31     ` Максим Корякшин via Tarantool-patches
2021-07-26 12:32       ` Максим Корякшин via Tarantool-patches
2021-07-26 12:36         ` Максим Корякшин via Tarantool-patches
2021-07-26 20:13           ` Igor Munkin via Tarantool-patches
2021-07-27  6:21           ` Sergey Kaplun via Tarantool-patches
2021-07-29  9:41             ` Максим Корякшин via Tarantool-patches
2021-07-29  9:45               ` Sergey Kaplun via Tarantool-patches
2021-07-29  9:57                 ` Максим Корякшин via Tarantool-patches
2021-07-30 17:09                   ` Igor Munkin via Tarantool-patches
2021-07-25 21:03 ` [Tarantool-patches] [PATCH v2 00/10] test: lua-Harness suite patch bump Igor Munkin via Tarantool-patches
2021-07-30 19:19 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQGlfiZwfxcyTwy7@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --cc=skaplun@tarantool.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Tarantool development patches archive

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lists.tarantool.org/tarantool-patches/0 tarantool-patches/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 tarantool-patches tarantool-patches/ https://lists.tarantool.org/tarantool-patches \
		tarantool-patches@dev.tarantool.org.
	public-inbox-index tarantool-patches

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git