Re: [Tarantool-patches] [PATCH v2 07/10] test: backport lua-Harness directory detection

["Максим Корякшин via Tarantool-patches" <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1476 bytes --]


Thanks for the review, Igor!
New commit message, considering all your comments:
=============================================
    test: backport lua-Harness directory detection
 
    The patch[1] from lua-Harness fixes the same issue commit
    789820aac7cecc3b5ae394aadc12a5ec25b68121 ('test: fix directory detection
    in lua-Harness suite') does, but it also works on Windows, so the
    mentioned commit can be superseded by that patch.
    [1]:  https://framagit.org/fperrad/lua-Harness/-/commit/24a570c1
 
    Part of tarantool/tarantool#5970
    Part of tarantool/tarantool#4473
=============================================
 
>
>Понедельник, 26 июля 2021, 0:35 +03:00 от Igor Munkin <imun@tarantool.org>:
> 
>Max,
>
>Thanks for the patch! LGTM, except the three typos.
>
>On 20.07.21, Maxim Kokryashkin wrote:
>> The patch[1] from lua-Harness fixes the same issue commit
>
>Typo: The link is missing.
>
>> 789820aac7cecc3b5ae394aadc12a5ec25b68121('test: fix directory detection
>
>Typo: Space is missing after the commit hash.
>
>> in lua-Harness suite') does, but it also works on Windows, so the
>> mentioned commit can be supreseded by that patch.
>
>Typo: s/supreseded/superseded/.
>
>>
>> Part of tarantool/tarantool#5970
>> Part of tarantool/tarantool#4473
>> ---
>> test/lua-Harness-tests/314-regex.t | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
><snipped>
>
>> --
>> 2.32.0
>>
>
>--
>Best regards,
>IM
 

[-- Attachment #2: Type: text/html, Size: 2157 bytes --]