Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Максим Корякшин" <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 01/10] test: port lua-Harness to Test.Assertion
Date: Tue, 27 Jul 2021 09:41:10 +0300	[thread overview]
Message-ID: <YP+qho+FjutU9K0n@root> (raw)
In-Reply-To: <1627295891.514312153@f172.i.mail.ru>

Hi!

Thanks for the patch!

LGTM, except a few nits regarding the commit message.

On 26.07.21, Максим Корякшин wrote:
> 
> Thanks for the review, Igor!
> Here is the new commit message with your suggestions in mind:
> ==========================================================
>     test: port lua-Harness to Test.Assertion
>     Backports conversion to Test.Assertion patch[1] from lua-Harness suite.

Typo: s/from lua-Harness suite/from the lua-Harness suite/

>     As a result of this change out-of-source testing is broken, but the
>     previous assertion using package.path as a second argument worked fine.
>     Because of that, this commit includes fix, that was made by this patch[2]
>     in mainline lua-Harness.

Nit: Missing optional empty line here.

>     [1]:  https://framagit.org/fperrad/lua-Harness/-/commit/074fefa
>     [2]:  https://framagit.org/fperrad/lua-Harness/-/commit/c4451fe

Nit: Missing empty line here.

>     Part of tarantool/tarantool#5970
>     Part of tarantool/tarantool#4473
>  
> ==========================================================
>  
>  
>  
> >Igor Munkin wrote:
> > 
> >Max,
> >
> >Thanks for the patch! LGTM, except the several nits.
> >
> >On 20.07.21, Maxim Kokryashkin wrote:
> >> Backports conversion to Test.Assertion patch[1] from lua-Harness suite
> >
> >Typo: Dot is missing at the end of the sentence.
> >
> >>
> >> As a result out of this change out-of-source testing is broken, but the
> >
> >Typo: s/As a result out of/As a result of/.
> >
> >> previous assertion using package.path as a second argument worked fine.
> >> Because of that, this commit includes fix, that was made by this patch[2]
> >> in mainline lua-Harness.
> >>
> >> [1]:  https://framagit.org/fperrad/lua-Harness/-/commit/074fefa51da1276078f735fa8fb568963fe541f1
> >> [2]:  https://framagit.org/fperrad/lua-Harness/-/commit/c4451fe06fcdc0d83a72dfa56eaae3ed26151c04
> >
> >Minor: You can strip commit hash in the links above up to 7 symbols to
> >shorted them a bit. Feel free to ignore.

Side note: I prefer the full commit hashes to avoid clashes, but never
mind :).

> >
> >>
> >> Part of tarantool/tarantool#5970
> >> Part of tarantool/tarantool#4473
> >> ---
> >> Additional comments on issue with out-of-source testing:
> >>  https://github.com/tarantool/tarantool/issues/5970#issuecomment-880158605
> >>
> >> test/lua-Harness-tests/090-tap.t | 8 +-
> >> test/lua-Harness-tests/091-profile.t | 10 +-
> >> test/lua-Harness-tests/101-boolean.t | 126 +--
> >> test/lua-Harness-tests/102-function.t | 218 ++---
> >> test/lua-Harness-tests/103-nil.t | 126 +--
> >> test/lua-Harness-tests/104-number.t | 270 +++----
> >> test/lua-Harness-tests/105-string.t | 308 ++++----
> >> test/lua-Harness-tests/106-table.t | 132 ++--
> >> test/lua-Harness-tests/107-thread.t | 128 +--
> >> test/lua-Harness-tests/108-userdata.t | 124 +--
> >> test/lua-Harness-tests/200-examples.t | 12 +-
> >> test/lua-Harness-tests/201-assign.t | 82 +-
> >> test/lua-Harness-tests/202-expr.t | 138 ++--
> >> test/lua-Harness-tests/203-lexico.t | 66 +-
> >> test/lua-Harness-tests/204-grammar.t | 76 +-
> >> test/lua-Harness-tests/211-scope.t | 24 +-
> >> test/lua-Harness-tests/212-function.t | 138 ++--
> >> test/lua-Harness-tests/213-closure.t | 32 +-
> >> test/lua-Harness-tests/214-coroutine.t | 96 +--
> >> test/lua-Harness-tests/221-table.t | 54 +-
> >> test/lua-Harness-tests/222-constructor.t | 34 +-
> >> test/lua-Harness-tests/223-iterator.t | 18 +-
> >> test/lua-Harness-tests/231-metatable.t | 232 +++---
> >> test/lua-Harness-tests/232-object.t | 38 +-
> >> .../241-standalone.t.disabled | 116 +--
> >> test/lua-Harness-tests/242-luac.t | 80 +-
> >> test/lua-Harness-tests/301-basic.t | 748 +++++++++---------
> >> test/lua-Harness-tests/303-package.t | 119 +--
> >> test/lua-Harness-tests/304-string.t | 648 +++++++--------
> >> test/lua-Harness-tests/305-utf8.t | 4 +-
> >> test/lua-Harness-tests/306-table.t | 186 ++---
> >> test/lua-Harness-tests/307-math.t | 266 +++----
> >> test/lua-Harness-tests/308-io.t | 248 +++---
> >> test/lua-Harness-tests/309-os.t | 158 ++--
> >> test/lua-Harness-tests/310-debug.t | 226 +++---
> >> test/lua-Harness-tests/311-bit32.t | 70 +-
> >> test/lua-Harness-tests/314-regex.t | 8 +-
> >> test/lua-Harness-tests/320-stdin.t | 26 +-
> >> test/lua-Harness-tests/401-bitop.t | 60 +-
> >> test/lua-Harness-tests/402-ffi.t | 78 +-
> >> test/lua-Harness-tests/403-jit.t | 96 +--
> >> test/lua-Harness-tests/404-ext.t | 162 ++--
> >> test/lua-Harness-tests/411-luajit.t.disabled | 166 ++--
> >> test/lua-Harness-tests/lexico52/lexico.t | 22 +-
> >> test/lua-Harness-tests/lexico53/boolean.t | 44 +-
> >> test/lua-Harness-tests/lexico53/function.t | 72 +-
> >> test/lua-Harness-tests/lexico53/lexico.t | 14 +-
> >> test/lua-Harness-tests/lexico53/nil.t | 44 +-
> >> test/lua-Harness-tests/lexico53/number.t | 224 +++---
> >> test/lua-Harness-tests/lexico53/string.t | 196 ++---
> >> test/lua-Harness-tests/lexico53/table.t | 44 +-
> >> test/lua-Harness-tests/lexico53/thread.t | 44 +-
> >> test/lua-Harness-tests/lexico53/userdata.t | 44 +-
> >> test/lua-Harness-tests/lexico53/utf8.t | 240 +++---
> >> test/lua-Harness-tests/lexico54/lexico.t | 8 +-
> >> test/lua-Harness-tests/lexico54/metatable.t | 14 +-
> >> test/lua-Harness-tests/lexico54/utf8.t | 34 +-
> >> test/lua-Harness-tests/lexicojit/basic.t | 14 +-
> >> test/lua-Harness-tests/lexicojit/ext.t | 26 +-
> >> test/lua-Harness-tests/lexicojit/lexico.t | 30 +-
> >> test/lua-Harness-tests/tap.lua | 96 ++-
> >> 61 files changed, 3599 insertions(+), 3566 deletions(-)
> >>
> >
> ><snipped>
> >
> >> --
> >> 2.32.0
> >>
> >
> >--
> >Best regards,
> >IM
>  
>  

-- 
Best regards,
Sergey Kaplun

  reply	other threads:[~2021-07-27  6:42 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20 16:26 [Tarantool-patches] [PATCH v2 00/10] test: lua-Harness suite patch bump Maxim Kokryashkin via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 01/10] test: port lua-Harness to Test.Assertion Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:08   ` Igor Munkin via Tarantool-patches
2021-07-26 10:38     ` Максим Корякшин via Tarantool-patches
2021-07-27  6:41       ` Sergey Kaplun via Tarantool-patches [this message]
2021-07-27 22:18         ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 02/10] test: rename lua-Harness tap to test_assertion Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:08   ` Igor Munkin via Tarantool-patches
2021-07-27  6:27   ` Sergey Kaplun via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 03/10] test: use CI friendly variables in lua-Harness Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:09   ` Igor Munkin via Tarantool-patches
2021-07-27  9:01     ` Sergey Kaplun via Tarantool-patches
2021-07-27 22:23       ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 04/10] test: refactor with _retrieve_progname Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:09   ` Igor Munkin via Tarantool-patches
2021-07-27  9:27     ` Sergey Kaplun via Tarantool-patches
2021-07-27 22:28       ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 05/10] test: refactor with _dofile Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:10   ` Igor Munkin via Tarantool-patches
2021-07-26 12:11     ` Максим Корякшин via Tarantool-patches
2021-07-27  9:34       ` Sergey Kaplun via Tarantool-patches
2021-07-27 22:36         ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 06/10] test: support tarantool in lua-Harness Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:11   ` Igor Munkin via Tarantool-patches
2021-07-26 11:07     ` Максим Корякшин via Tarantool-patches
2021-07-26 19:46       ` Igor Munkin via Tarantool-patches
2021-07-27 10:04   ` Sergey Kaplun via Tarantool-patches
2021-07-28 17:40     ` Максим Корякшин via Tarantool-patches
2021-07-28 17:42     ` Максим Корякшин via Tarantool-patches
2021-07-28 18:34       ` Sergey Kaplun via Tarantool-patches
2021-07-29  9:19         ` Максим Корякшин via Tarantool-patches
2021-07-29  9:22           ` Igor Munkin via Tarantool-patches
2021-07-29 10:12             ` Максим Корякшин via Tarantool-patches
2021-07-29  9:47           ` Sergey Kaplun via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 07/10] test: backport lua-Harness directory detection Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:12   ` Igor Munkin via Tarantool-patches
2021-07-26 11:13     ` Максим Корякшин via Tarantool-patches
2021-07-28 18:37       ` Sergey Kaplun via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 08/10] test: support tarantool cli in lua-Harness Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:13   ` Igor Munkin via Tarantool-patches
2021-07-26 11:17     ` Максим Корякшин via Tarantool-patches
2021-07-26 19:53       ` Igor Munkin via Tarantool-patches
2021-07-28 18:44       ` Sergey Kaplun via Tarantool-patches
2021-07-28 18:50         ` Sergey Kaplun via Tarantool-patches
2021-07-29  9:23         ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 09/10] test: update lua-Harness to b7b1a9a2 Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:14   ` Igor Munkin via Tarantool-patches
2021-07-26 12:21     ` Максим Корякшин via Tarantool-patches
2021-07-26 20:04       ` Igor Munkin via Tarantool-patches
2021-07-28 18:48       ` Sergey Kaplun via Tarantool-patches
2021-07-29  9:27         ` Максим Корякшин via Tarantool-patches
2021-07-20 16:26 ` [Tarantool-patches] [PATCH v2 10/10] test: disable test/lua-Harness-tests/241-standalone.t on FreeBSD Maxim Kokryashkin via Tarantool-patches
2021-07-25 21:17   ` Igor Munkin via Tarantool-patches
2021-07-26 12:31     ` Максим Корякшин via Tarantool-patches
2021-07-26 12:32       ` Максим Корякшин via Tarantool-patches
2021-07-26 12:36         ` Максим Корякшин via Tarantool-patches
2021-07-26 20:13           ` Igor Munkin via Tarantool-patches
2021-07-27  6:21           ` Sergey Kaplun via Tarantool-patches
2021-07-29  9:41             ` Максим Корякшин via Tarantool-patches
2021-07-29  9:45               ` Sergey Kaplun via Tarantool-patches
2021-07-29  9:57                 ` Максим Корякшин via Tarantool-patches
2021-07-30 17:09                   ` Igor Munkin via Tarantool-patches
2021-07-25 21:03 ` [Tarantool-patches] [PATCH v2 00/10] test: lua-Harness suite patch bump Igor Munkin via Tarantool-patches
2021-07-30 19:19 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YP+qho+FjutU9K0n@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2 01/10] test: port lua-Harness to Test.Assertion' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox