From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B24BF6EC55; Tue, 27 Jul 2021 09:42:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B24BF6EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627368144; bh=HWFsVghhV8pFnd2GL2eNUHgLHPViTWzLpXZsJaZrz7I=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Tmjlkrm3nQYD67O9gsTBc0MNvE8A8l9Bevk9jMbQeZmyOLei/noyuV+BbJ0AdkpA9 6kfgciEpb5hlj81jce2xTemkoNQLBUAmfx6ExYPC32sBUVkrUZpsFXLls7E70PNrNn Hq+jqEoyJN75G17YycnmjKz0+UeZQbh11OGRbPwM= Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 545AC6EC55 for ; Tue, 27 Jul 2021 09:42:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 545AC6EC55 Received: by smtp49.i.mail.ru with esmtpa (envelope-from ) id 1m8GnG-0003o1-8Y; Tue, 27 Jul 2021 09:42:22 +0300 Date: Tue, 27 Jul 2021 09:41:10 +0300 To: =?utf-8?B?0JzQsNC60YHQuNC8INCa0L7RgNGP0LrRiNC40L0=?= Message-ID: References: <3fc0b9e1c18be73ceabe85e41818b0a4ee3e2102.1626797225.git.m.kokryashkin@tarantool.org> <20210725210838.GC27855@tarantool.org> <1627295891.514312153@f172.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1627295891.514312153@f172.i.mail.ru> X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD941C43E597735A9C354866C15C72ED952BE56FFA0EFAF5B8C182A05F538085040769F99B011496471823036E9994712D9182DA4AD169962F957E4C733D3C824CE X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7811C3E343B302E2EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063748C26B83F2B024408638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D88C346B89DC525416FAC78B4B38D379BF117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B65D56369A3576CBA5089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A53C3F783A92D5092161618D5975C04DA45D7DC34D7512F43AD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7536C62C4FBC402878410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A2EC120135420F90B94A78E1ED6B6079417118532B99C6CDB6A8375DAFAD3FAB358B9615F3CFF39A1D7E09C32AA3244C48B49C1CEE88CEB5CE2B1421C6673DDE9CA7333006C390A0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMEANdStWW5+r7oFMq33ABw== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4B587AF180403FF2246F6BC56207E7B0DFFF5FBF3E5C49B23F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 01/10] test: port lua-Harness to Test.Assertion X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! LGTM, except a few nits regarding the commit message. On 26.07.21, Максим Корякшин wrote: > > Thanks for the review, Igor! > Here is the new commit message with your suggestions in mind: > ========================================================== >     test: port lua-Harness to Test.Assertion >     Backports conversion to Test.Assertion patch[1] from lua-Harness suite. Typo: s/from lua-Harness suite/from the lua-Harness suite/ >     As a result of this change out-of-source testing is broken, but the >     previous assertion using package.path as a second argument worked fine. >     Because of that, this commit includes fix, that was made by this patch[2] >     in mainline lua-Harness. Nit: Missing optional empty line here. >     [1]: https://framagit.org/fperrad/lua-Harness/-/commit/074fefa >     [2]: https://framagit.org/fperrad/lua-Harness/-/commit/c4451fe Nit: Missing empty line here. >     Part of tarantool/tarantool#5970 >     Part of tarantool/tarantool#4473 >   > ========================================================== >   >   >   > >Igor Munkin wrote: > >  > >Max, > > > >Thanks for the patch! LGTM, except the several nits. > > > >On 20.07.21, Maxim Kokryashkin wrote: > >> Backports conversion to Test.Assertion patch[1] from lua-Harness suite > > > >Typo: Dot is missing at the end of the sentence. > > > >> > >> As a result out of this change out-of-source testing is broken, but the > > > >Typo: s/As a result out of/As a result of/. > > > >> previous assertion using package.path as a second argument worked fine. > >> Because of that, this commit includes fix, that was made by this patch[2] > >> in mainline lua-Harness. > >> > >> [1]: https://framagit.org/fperrad/lua-Harness/-/commit/074fefa51da1276078f735fa8fb568963fe541f1 > >> [2]: https://framagit.org/fperrad/lua-Harness/-/commit/c4451fe06fcdc0d83a72dfa56eaae3ed26151c04 > > > >Minor: You can strip commit hash in the links above up to 7 symbols to > >shorted them a bit. Feel free to ignore. Side note: I prefer the full commit hashes to avoid clashes, but never mind :). > > > >> > >> Part of tarantool/tarantool#5970 > >> Part of tarantool/tarantool#4473 > >> --- > >> Additional comments on issue with out-of-source testing: > >> https://github.com/tarantool/tarantool/issues/5970#issuecomment-880158605 > >> > >> test/lua-Harness-tests/090-tap.t | 8 +- > >> test/lua-Harness-tests/091-profile.t | 10 +- > >> test/lua-Harness-tests/101-boolean.t | 126 +-- > >> test/lua-Harness-tests/102-function.t | 218 ++--- > >> test/lua-Harness-tests/103-nil.t | 126 +-- > >> test/lua-Harness-tests/104-number.t | 270 +++---- > >> test/lua-Harness-tests/105-string.t | 308 ++++---- > >> test/lua-Harness-tests/106-table.t | 132 ++-- > >> test/lua-Harness-tests/107-thread.t | 128 +-- > >> test/lua-Harness-tests/108-userdata.t | 124 +-- > >> test/lua-Harness-tests/200-examples.t | 12 +- > >> test/lua-Harness-tests/201-assign.t | 82 +- > >> test/lua-Harness-tests/202-expr.t | 138 ++-- > >> test/lua-Harness-tests/203-lexico.t | 66 +- > >> test/lua-Harness-tests/204-grammar.t | 76 +- > >> test/lua-Harness-tests/211-scope.t | 24 +- > >> test/lua-Harness-tests/212-function.t | 138 ++-- > >> test/lua-Harness-tests/213-closure.t | 32 +- > >> test/lua-Harness-tests/214-coroutine.t | 96 +-- > >> test/lua-Harness-tests/221-table.t | 54 +- > >> test/lua-Harness-tests/222-constructor.t | 34 +- > >> test/lua-Harness-tests/223-iterator.t | 18 +- > >> test/lua-Harness-tests/231-metatable.t | 232 +++--- > >> test/lua-Harness-tests/232-object.t | 38 +- > >> .../241-standalone.t.disabled | 116 +-- > >> test/lua-Harness-tests/242-luac.t | 80 +- > >> test/lua-Harness-tests/301-basic.t | 748 +++++++++--------- > >> test/lua-Harness-tests/303-package.t | 119 +-- > >> test/lua-Harness-tests/304-string.t | 648 +++++++-------- > >> test/lua-Harness-tests/305-utf8.t | 4 +- > >> test/lua-Harness-tests/306-table.t | 186 ++--- > >> test/lua-Harness-tests/307-math.t | 266 +++---- > >> test/lua-Harness-tests/308-io.t | 248 +++--- > >> test/lua-Harness-tests/309-os.t | 158 ++-- > >> test/lua-Harness-tests/310-debug.t | 226 +++--- > >> test/lua-Harness-tests/311-bit32.t | 70 +- > >> test/lua-Harness-tests/314-regex.t | 8 +- > >> test/lua-Harness-tests/320-stdin.t | 26 +- > >> test/lua-Harness-tests/401-bitop.t | 60 +- > >> test/lua-Harness-tests/402-ffi.t | 78 +- > >> test/lua-Harness-tests/403-jit.t | 96 +-- > >> test/lua-Harness-tests/404-ext.t | 162 ++-- > >> test/lua-Harness-tests/411-luajit.t.disabled | 166 ++-- > >> test/lua-Harness-tests/lexico52/lexico.t | 22 +- > >> test/lua-Harness-tests/lexico53/boolean.t | 44 +- > >> test/lua-Harness-tests/lexico53/function.t | 72 +- > >> test/lua-Harness-tests/lexico53/lexico.t | 14 +- > >> test/lua-Harness-tests/lexico53/nil.t | 44 +- > >> test/lua-Harness-tests/lexico53/number.t | 224 +++--- > >> test/lua-Harness-tests/lexico53/string.t | 196 ++--- > >> test/lua-Harness-tests/lexico53/table.t | 44 +- > >> test/lua-Harness-tests/lexico53/thread.t | 44 +- > >> test/lua-Harness-tests/lexico53/userdata.t | 44 +- > >> test/lua-Harness-tests/lexico53/utf8.t | 240 +++--- > >> test/lua-Harness-tests/lexico54/lexico.t | 8 +- > >> test/lua-Harness-tests/lexico54/metatable.t | 14 +- > >> test/lua-Harness-tests/lexico54/utf8.t | 34 +- > >> test/lua-Harness-tests/lexicojit/basic.t | 14 +- > >> test/lua-Harness-tests/lexicojit/ext.t | 26 +- > >> test/lua-Harness-tests/lexicojit/lexico.t | 30 +- > >> test/lua-Harness-tests/tap.lua | 96 ++- > >> 61 files changed, 3599 insertions(+), 3566 deletions(-) > >> > > > > > > > >> -- > >> 2.32.0 > >> > > > >-- > >Best regards, > >IM >   >   -- Best regards, Sergey Kaplun