Re: [Tarantool-patches] [PATCH v2 06/10] test: support tarantool in lua-Harness

["Максим Корякшин via Tarantool-patches" <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1822 bytes --]


Thanks for the review, Sergey!
 
 
> 
>>Hi, Maxim!
>>
>>Thanks for the patch!
>>
>>Please consider my comments below.
>>
>>On 20.07.21, Maxim Kokryashkin wrote:
>>> Backports 'supoort Tarantool' patch[1] from lua-Harness.
>>>
>>> [1]:  https://framagit.org/fperrad/lua-Harness/-/commit/d3ceee16
>>>
>>> Part of tarantool/tarantool#5970
>>> Part of tarantool/tarantool#4473
>>> ---
>>
>>| test: support tarantool in lua-Harness
>>
>>Nit: s/tarantool/Tarantool/.
>>
>>|
>>| Backports 'support Tarantool' patch[1] from lua-Harness.
>>
>>Nit: s/Tarantool/tarantool/ regarding to the original commit message.
>>
>>| This patch introduces lua-Harness profile for Tarantool considering the
>>| platform specifics. Furthermore, these changes skip all CLI-related
>>| tests for Tarantool binary, so 241-standalone.t and 411-luajit.t can be
>>| renamed back.
>>
>>I afraid, not so fast. Within these changes tests are failed in the
>>LuaJIT's repo with the following error:
>>|! unknown luaJIT command or jit.* modules not installed
>>
>>Seems like LUA_PATH should be adjusted for these tests.
>>|
>>| [1]:  https://framagit.org/fperrad/lua-Harness/-/commit/d3ceee16
>>|
>>| Part of tarantool/tarantool#5970
>>| Part of tarantool/tarantool#4473
>>
>>> ...standalone.t.disabled => 241-standalone.t} | 5 ++
>>> test/lua-Harness-tests/320-stdin.t | 2 +-
>>> .../{411-luajit.t.disabled => 411-luajit.t} | 2 +-
>>> test/lua-Harness-tests/profile_tarantool.lua | 63 +++++++++++++++++++
>>> 4 files changed, 70 insertions(+), 2 deletions(-)
>>> rename test/lua-Harness-tests/{241-standalone.t.disabled => 241-standalone.t} (99%)
>>> rename test/lua-Harness-tests/{411-luajit.t.disabled => 411-luajit.t} (99%)
>>> create mode 100644 test/lua-Harness-tests/profile_tarantool.lua
>>
>><snipped>
>>
>>--
>>Best regards,
>>Sergey Kaplun
> 

[-- Attachment #2: Type: text/html, Size: 2517 bytes --]