From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2065A6EC55; Wed, 28 Jul 2021 21:45:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2065A6EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627497928; bh=6gf+b7siO3eCoD5xyQd8cJ53DZosPqxtbh4vEkkce3U=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=D8Rc+WxBiM/oPe/ChDQPM28zxzkdThmc+gN6gTRWjseuFfJYEWVDVQXJSsLAxKo1h UB35Fts1Sgg1TLhald7U6PTkUiWqrwvQUh9BaI7UYny0r/LLEQxdJCFMueffTbxSCB 0rWreSgqBxJ9mdbXF9EKC+U4x1eo2tE+TFt7Qtyg= Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EF2066EC55 for ; Wed, 28 Jul 2021 21:45:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EF2066EC55 Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1m8oYY-0007Jd-1z; Wed, 28 Jul 2021 21:45:26 +0300 Date: Wed, 28 Jul 2021 21:44:14 +0300 To: =?utf-8?B?0JzQsNC60YHQuNC8INCa0L7RgNGP0LrRiNC40L0=?= Message-ID: References: <39f288e9c6c4722433599ab33371ecd2470f1125.1626797225.git.m.kokryashkin@tarantool.org> <20210725211327.GJ27855@tarantool.org> <1627298220.392923948@f312.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1627298220.392923948@f312.i.mail.ru> X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C3104FC76DFAAAAF7DA068FE323FAC4379182A05F538085040AEBA78B62443823DB821EDD5F8CAA66F336C395945439E3DD48BB39A3E56DA56 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F65C230EDDCD559EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637EDC9855826FBDF5A8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D87E8027475E9BB119959F37D847A2A4C4117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18C26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A45692FFBBD75A6A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B5051A1B23CB318000D38CA7D819832A164D X-C1DE0DAB: 0D63561A33F958A5470FBE604F865833F655EC5C3359767918AB239BE8C05292D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA754263BA4E959D734C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348BF433665406F3908071D6C6A12B99E3BE43B8703731425A6980378970B95DFE86F1251F5C8521391D7E09C32AA3244CCAB7F6A187A588F531DB303B539FB9298580396430872480FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiF1u9eOpfTTFtwF7Kush2A== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB491460AAC9DD9E9B6C227FA1345AF0C301D3C83D85910630EF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 08/10] test: support tarantool cli in lua-Harness X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the patch and fixes! LGTM, except a few nits regarding to the commit message. On 26.07.21, Максим Корякшин wrote: > > Thanks for the review, Igor! > Here is the new commit message, considering your comments: > ================================================= >     test: support tarantool cli in lua-Harness >   >     The patch[1] from lua-Harness suite adjusts some checks in Typo: s/from lua-Harness suite/the from lua-Harness suite/ >     lua-Harness tests, so they are compatible with Tarantool now. >   >     As a result, the introduced assertion for Tarantool error message fails >     on MacOS, since getopt_long(3) yields the error message without single >     quotes wrapping the flag. Hence, this commit also includes fix for that Typo: s/fix/the fix/ >     from patch[2] in the trunk. Typo: s/patch/the patch/ >   >     [1]: https://framagit.org/fperrad/lua-Harness/-/commit/1da5b1b >     [2]: https://framagit.org/fperrad/lua-Harness/-/commit/a0532c5 >   >     Part of tarantool/tarantool#5970 >     Part of tarantool/tarantool#4473 >   > ================================================= >   >   > >Понедельник, 26 июля 2021, 0:37 +03:00 от Igor Munkin : > >  > >Max, > > > >Thanks for the patch! The changes are fine, but please consider the > >comments below regarding the commit message. > > > >On 20.07.21, Maxim Kokryashkin wrote: > >> The patch[1] from lua-Harness suite adds some specific checks to > >> lua-Harness tests, so they are compatible with Tarantool now. > > > >Strictly saying, no *new* checks are *added*, but the *existing* ones > >are *adjusted* considering Tarantool specifics. > > > >> > >> Considering this, commit d4e12d7ac28e3bc857d30971dd77deec66a67297('test: > >> disable LuaJIT CLI tests in lua-Harness suite'), which disabled > >> tarantool cli tests, can be superseded. > > > >No, it can't. The mentioned commit is superseded by "[PATCH v2 06/10] > >test: support tarantool in lua-Harness" in this series. > > > >> > >> As a result, the introduced assertion for Tarantool error message fails > >> on MacOS, since getopt_long(3) yields the error message without single > >> quotes wrapping the flag. Hence, this commit also includes fix for that > >> from patch[2] in the trunk. > >> > >> [1]: https://framagit.org/fperrad/lua-Harness/-/commit/1da5b1b3 > > > >Minor: 7 digits are enough. This is not critical, but just odd to have > >two similar links with the different number of digits, so feel free to > >ignore this nit. > > > >> [2]: https://framagit.org/fperrad/lua-Harness/-/commit/a0532c5 > > > >Please mention the related issues: #5970 and #4473. > > > >> --- > >> Additional information on issue with MacOS: > >> https://github.com/tarantool/tarantool/issues/5970#issuecomment-880158605 > >> > >> NOTICE: tests for this separate commit are failing on FreeBSD > >> > >> test/lua-Harness-tests/241-standalone.t | 79 +++++++++++++++++++------ > >> 1 file changed, 61 insertions(+), 18 deletions(-) > >> > > > > > > > >> -- > >> 2.32.0 > >> > > > >-- > >Best regards, > >IM >   -- Best regards, Sergey Kaplun