From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id F29F96EC55; Mon, 26 Jul 2021 00:34:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F29F96EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627248871; bh=izzXQAnbWhyjWY9zh8gP54NL8k7V/Pb0GkpVsyA1N70=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=F14kru38ziaNaUJTMlztmtMYBi7vrrqSHGtEvp/NjD0/T/ChFPRhbb7uZTBAndxDQ kI/pYv2Hyx6Z5ggMcXsEfpr8cFzbL7F5NYOKyCdmUXQgdHGmNDaBZiV5LKga0G9uYv OWV9g0bMm8f23w/RWg0Ev+JgAMYJX66yblF31oDE= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EFE8B6EC55 for ; Mon, 26 Jul 2021 00:34:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EFE8B6EC55 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1m7llS-0005E3-Ts; Mon, 26 Jul 2021 00:34:27 +0300 Date: Mon, 26 Jul 2021 00:10:51 +0300 To: Maxim Kokryashkin Message-ID: <20210725211051.GG27855@tarantool.org> References: <34c2c2f332776613a3fd456ea62d00e892ad6369.1626797225.git.m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <34c2c2f332776613a3fd456ea62d00e892ad6369.1626797225.git.m.kokryashkin@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD941C43E597735A9C36A98DBA789EBB6AEFB5A483DCE5E7579182A05F538085040EF46FAB7ABFF4BC0B7CC45F3333B00915BA4F7EC9FF892F92DD21783E2BF0D7A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DECE8D0A5E25C0FCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AA32F0A5ADCF96E68638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F284715CB736A97CE5C793BF965BB035117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FBDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6BF3059D42242344A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A58C7823A801EBA0FFA372EEF66F28A20209C6EAD31CCEDA98D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34D75CEA0D7A80616EBF4AA3BC500213451EAEBBDA1DA4D996952559BA2884E687F4CF5976BB8E1B061D7E09C32AA3244C610D03258C7B4C38C6E955E218B44F00B018FE5BB746DCD1927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojBHzp66hWLW1T5QWlp4Uu2w== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D6F9A955D7B0F2F95D8FDD043BB747648A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 05/10] test: refactor with _dofile X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the fixes! LGTM, except the three typos in luajit-test-init.lua. On 20.07.21, Maxim Kokryashkin wrote: > The patch[1] from lua-Harness suite is quite similar to commit > d11c5bbc08a118b11167c5d455d4024607dab662 ('test: adjust lua-Harness > tests that use dofile'), with the one difference (except the naming): > `make_specific_checks()` provides the particular behaviour to run the > tests for out-of-source build, however `_dofile()` allows user to > overload this function considering his purposes. If user leave > `_dofile()` untouched, it defaults to `dofile()` Lua standard library > function. > > It's worth to mention, that LuaJIT testing machinery has been using > such approach since commit 734cc0f1d508429c2c3c46bd1860398db0051060 > ('test: adapt PUC-Rio suite for out-of-source build') and `_dofile()` > behaviour for running tests when out of source build is used is > already defined in luajit-test-init.lua. > > [1]: https://framagit.org/fperrad/lua-Harness/-/commit/60da289 > > Part of tarantool/tarantool#5970 > Part of tarantool/tarantool#4473 > --- > test/lua-Harness-tests/101-boolean.t | 2 +- > test/lua-Harness-tests/102-function.t | 2 +- > test/lua-Harness-tests/103-nil.t | 2 +- > test/lua-Harness-tests/104-number.t | 2 +- > test/lua-Harness-tests/105-string.t | 2 +- > test/lua-Harness-tests/106-table.t | 2 +- > test/lua-Harness-tests/107-thread.t | 2 +- > test/lua-Harness-tests/108-userdata.t | 2 +- > test/lua-Harness-tests/203-lexico.t | 8 ++++---- > test/lua-Harness-tests/231-metatable.t | 2 +- > test/lua-Harness-tests/301-basic.t | 2 +- > test/lua-Harness-tests/305-utf8.t | 4 ++-- > test/lua-Harness-tests/404-ext.t | 2 +- > test/lua-Harness-tests/test_assertion.lua | 10 ++-------- > test/luajit-test-init.lua | 2 ++ > 15 files changed, 21 insertions(+), 25 deletions(-) > > diff --git a/test/luajit-test-init.lua b/test/luajit-test-init.lua > index 54a1f815..feec17cf 100644 > --- a/test/luajit-test-init.lua > +++ b/test/luajit-test-init.lua > @@ -2,6 +2,8 @@ > -- `_loadfile()` exists and uses it for code loading from test > -- files. If the variable is not defined then suite uses > -- `loadfile()` as default. Same for the `_dofile()`. > +-- Lua-Harness also uses the same implementation of `dofile()` Typo: s/Lua-Harness/lua-Harness/. > +-- fot he same reason Typo: s/fot/for/. Typo: Dot is missing at the end of the sentence. > > -- XXX: Some tests in PUC Rio Lua 5.1 test suite clean `arg` > -- variable, so evaluate this once and use later. > -- > 2.32.0 > -- Best regards, IM