Tarantool development patches archive
 help / color / mirror / Atom feed
* [Tarantool-patches] [PATCHv4 0/3] test: -e assert(false) fixup
@ 2021-01-18 12:45 Artem Starshov via Tarantool-patches
  2021-01-18 12:45 ` [Tarantool-patches] [PATCHv4 1/3] test: change timeout in -e assert(false) test Artem Starshov via Tarantool-patches
                   ` (5 more replies)
  0 siblings, 6 replies; 11+ messages in thread
From: Artem Starshov via Tarantool-patches @ 2021-01-18 12:45 UTC (permalink / raw)
  To: Alexander Turenko; +Cc: tarantool-patches

Changes in v2:
    - changed commit message name
    - added 'follows up #4983'
    - removed collecting details about process due to Linux specific
    - left only the last commit because the previous was pushed to master
    and the first one is empty after the review
    - added comment describing the reason of using timeout module in
    presence of built-in 'popen' module

Changes in v3:
    - split one commit into two: first - increase timeout, second - move
    helper functions to separated module

Changes in v4:
    - split two commits into 3: first - increase timeout, second - add module
    process_timeout, third - modify -e assert(false) test using process_timeout.
    Creating module `process_timeout` in separate commit is convenient for working
    under other tests using this module while this patch isn't pushed on master.

Artem Starshov (3):
  test: change timeout in -e assert(false) test
  test: add separated module for proccess operations with timeout
  test: change -e assert(false) test using process_timeout module

 .../gh-4983-tnt-e-assert-false-hangs.test.lua | 70 ++++---------------
 test/app-tap/lua/process_timeout.lua          | 59 ++++++++++++++++
 test/app-tap/suite.ini                        |  2 +-
 3 files changed, 74 insertions(+), 57 deletions(-)
 create mode 100644 test/app-tap/lua/process_timeout.lua

-- 
2.28.0


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2021-01-27 13:19 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-18 12:45 [Tarantool-patches] [PATCHv4 0/3] test: -e assert(false) fixup Artem Starshov via Tarantool-patches
2021-01-18 12:45 ` [Tarantool-patches] [PATCHv4 1/3] test: change timeout in -e assert(false) test Artem Starshov via Tarantool-patches
2021-01-21 16:20   ` Sergey Bronnikov via Tarantool-patches
2021-01-26 10:26     ` Artem via Tarantool-patches
2021-01-18 12:45 ` [Tarantool-patches] [PATCHv4 2/3] test: add separated module for proccess operations with timeout Artem Starshov via Tarantool-patches
2021-01-18 12:45 ` [Tarantool-patches] [PATCHv4 3/3] test: change -e assert(false) test using process_timeout module Artem Starshov via Tarantool-patches
2021-01-21 16:23   ` Sergey Bronnikov via Tarantool-patches
2021-01-26 10:25     ` Artem via Tarantool-patches
2021-01-18 12:47 ` [Tarantool-patches] [PATCHv4 0/3] test: -e assert(false) fixup Artem via Tarantool-patches
2021-01-21 16:23 ` Sergey Bronnikov via Tarantool-patches
2021-01-27 13:19 ` Kirill Yukhin via Tarantool-patches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox