From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 913946465D; Thu, 21 Jan 2021 19:20:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 913946465D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611246010; bh=vgtXRbCC1b41pYUK2bUj+6arhMquGziWC7TvV7wk2nE=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=PS5s9vnmtgI2mkhiwcfYnn7oFxujAP13IRUzLrrIGQ2NRQ56VXq5EJrHYQvst5sd8 GdeM5SfRhvcrMiaTkUQ4UdR6q9TQt7akUZ6noBIy+EsmEg3NdteqtRgnZsJn2WwsYX gL4w4gnsXKit1KgUvxtiUtqF98Wsf+l/8lg3vb6c= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B09316465D for ; Thu, 21 Jan 2021 19:20:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B09316465D Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1l2cgo-0005H2-MA; Thu, 21 Jan 2021 19:20:07 +0300 To: Artem Starshov , Alexander Turenko References: Message-ID: <880fc79c-715e-4db2-02fd-d7b8e73ca9d0@tarantool.org> Date: Thu, 21 Jan 2021 19:20:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9FAB20BF8F0759036E9D016CAEA9DE5626062C4B45C2ADBD4182A05F53808504052BA0975114DC4C9C047B1CF70D885C002D8C77F75BD92ADD10D1AEAB71D9FC7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D77100FFB2844417EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370EBB47D88F71BB738638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCED83AE98076C068A755ABC27BF1C4235E7E156DB5A60AA12389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A3E989B1926288338941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B636DA1BED736F9328CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FC39F82E19B0A6E84575ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4931B544F03EFBC4D57C6C49853BF2B2AEEC4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F05F538519369F3743B503F486389A921A5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A557A9B266264B95F36444F6E6951A02F8C6ED0F14A04CA150D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA754DBC578B17CB11D78E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3452F7993FB7281BFD3F2A3B3B685D119073919DA395467604DAE6234AFE743137D0224533C79ECD551D7E09C32AA3244CEBF31C46D3FCD6DC074F9232DB85F769A90944CA99CF22E3927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojYT//mZRaUejn1V2icbLAKw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822701D0E9EFEF942B93E3B4726EB74040EDD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCHv4 1/3] test: change timeout in -e assert(false) test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! I think it would be more clear if you will add reasons why we need to reduce timeout for two times. On 18.01.2021 15:45, Artem Starshov wrote: > Set timeout to 60 sec for waiting operations with process, > like in default timeout for `cond_wait` in test-run. > > Follows up #4983 > --- > test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua b/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua > index 656fe212b..c8313770e 100755 > --- a/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua > +++ b/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua > @@ -60,10 +60,12 @@ local TARANTOOL_PATH = arg[-1] > local output_file = fio.abspath('out.txt') > local line = ('%s -e "assert(false)" > %s 2>&1 & echo $!'): > format(TARANTOOL_PATH, output_file) > -local process_waiting_timeout = 30.0 > -local file_read_timeout = 30.0 > + > +-- Like a default timeout for `cond_wait` in test-run > +local process_waiting_timeout = 60.0 > +local file_read_timeout = 60.0 > +local file_open_timeout = 60.0 > local file_read_interval = 0.2 > -local file_open_timeout = 30.0 > > local res = tap.test('gh-4983-tnt-e-assert-false-hangs', function(test) > test:plan(2)