From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5D8DF6465D; Thu, 21 Jan 2021 19:23:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5D8DF6465D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611246237; bh=VnkoeV0g0RrkWecLvJFX3LMLYZpXNETTmZx+s+3LprY=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=mYL5Qk4mccPqcMxKxe4+FPLBE+SZSTm5+Vvr0hDtSlbWhJGn9EYEqDy1RVE+5pp2w +D8uc+xs1hd3mEpMtSS8wSEDJVt/bT4fj99QcKcDBZ6rV6drFKbsjPIgeXIhOJAiNU aR9scZvwQb8jLx6kldbcNrWkc36AAEPUVt9HIlFk= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 545CA6465D for ; Thu, 21 Jan 2021 19:23:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 545CA6465D Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1l2ckD-0005Za-He; Thu, 21 Jan 2021 19:23:37 +0300 To: Artem Starshov , Alexander Turenko References: Message-ID: <2fc2feee-1223-70a7-c3e4-37018b04e3ff@tarantool.org> Date: Thu, 21 Jan 2021 19:23:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9FAB20BF8F0759036E9D016CAEA9DE5625EC7EDBD8999FF7A182A05F538085040C943F02E0C40DEFFF4A8943E72389325017F33B50B886735039E841931D76EE7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F65C230EDDCD559EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637560334CFC131571A8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCED83AE98076C068A459E5ABC6DE140D562909947E7396CF2389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0C26CFBAC0749D213D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BECADA55FE5B58BB7A471835C12D1D977C4224003CC836476EC64975D915A344093EC92FD9297F6718AA50765F790063726076CFCA0E6C6E4A7F4EDE966BC389F395957E7521B51C24C7702A67D5C33162DBA43225CD8A89F783D6DB41994EC49CE5475246E174218B5C8C57E37DE458B4C7702A67D5C3316FA3894348FB808DB48C21F01D89DB561574AF45C6390F7469DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5149966B605441BC4CADCE677473CFA25EF3138A2B5A90F09D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA754DBC578B17CB11D78E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34E420FF71F2F0FE032418191D8D37F15EDC9642020EF087BB6F2B79E13B7AC90101366461F84931E31D7E09C32AA3244C8123A9D702C778AF6F8AC71C926441FDA995755A1445935E927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojYT//mZRaUeh42hBj2klD/g== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822F6143AF7EFE20CF30740958F357B2FE5DD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCHv4 0/3] test: -e assert(false) fixup X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" LGTM On 18.01.2021 15:45, Artem Starshov wrote: > Changes in v2: > - changed commit message name > - added 'follows up #4983' > - removed collecting details about process due to Linux specific > - left only the last commit because the previous was pushed to master > and the first one is empty after the review > - added comment describing the reason of using timeout module in > presence of built-in 'popen' module > > Changes in v3: > - split one commit into two: first - increase timeout, second - move > helper functions to separated module > > Changes in v4: > - split two commits into 3: first - increase timeout, second - add module > process_timeout, third - modify -e assert(false) test using process_timeout. > Creating module `process_timeout` in separate commit is convenient for working > under other tests using this module while this patch isn't pushed on master. > > Artem Starshov (3): > test: change timeout in -e assert(false) test > test: add separated module for proccess operations with timeout > test: change -e assert(false) test using process_timeout module > > .../gh-4983-tnt-e-assert-false-hangs.test.lua | 70 ++++--------------- > test/app-tap/lua/process_timeout.lua | 59 ++++++++++++++++ > test/app-tap/suite.ini | 2 +- > 3 files changed, 74 insertions(+), 57 deletions(-) > create mode 100644 test/app-tap/lua/process_timeout.lua >