From: Artem via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Bronnikov <sergeyb@tarantool.org>, Alexander Turenko <alexander.turenko@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCHv4 1/3] test: change timeout in -e assert(false) test Date: Tue, 26 Jan 2021 13:26:39 +0300 [thread overview] Message-ID: <dce7f5d3-d9c3-ef92-49d9-47879e24f445@tarantool.org> (raw) In-Reply-To: <880fc79c-715e-4db2-02fd-d7b8e73ca9d0@tarantool.org> Hi, thanks for review! 21.01.2021 19:20, Sergey Bronnikov пишет: > Thanks for the patch! > > I think it would be more clear if you will add reasons > > why we need to reduce timeout for two times. Done. > > On 18.01.2021 15:45, Artem Starshov wrote: >> Set timeout to 60 sec for waiting operations with process, >> like in default timeout for `cond_wait` in test-run. >> >> Follows up #4983 >> --- >> test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua | 8 +++++--- >> 1 file changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua >> b/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua >> index 656fe212b..c8313770e 100755 >> --- a/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua >> +++ b/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua >> @@ -60,10 +60,12 @@ local TARANTOOL_PATH = arg[-1] >> local output_file = fio.abspath('out.txt') >> local line = ('%s -e "assert(false)" > %s 2>&1 & echo $!'): >> format(TARANTOOL_PATH, output_file) >> -local process_waiting_timeout = 30.0 >> -local file_read_timeout = 30.0 >> + >> +-- Like a default timeout for `cond_wait` in test-run >> +local process_waiting_timeout = 60.0 >> +local file_read_timeout = 60.0 >> +local file_open_timeout = 60.0 >> local file_read_interval = 0.2 >> -local file_open_timeout = 30.0 >> local res = tap.test('gh-4983-tnt-e-assert-false-hangs', >> function(test) >> test:plan(2)
next prev parent reply other threads:[~2021-01-26 10:26 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-18 12:45 [Tarantool-patches] [PATCHv4 0/3] test: -e assert(false) fixup Artem Starshov via Tarantool-patches 2021-01-18 12:45 ` [Tarantool-patches] [PATCHv4 1/3] test: change timeout in -e assert(false) test Artem Starshov via Tarantool-patches 2021-01-21 16:20 ` Sergey Bronnikov via Tarantool-patches 2021-01-26 10:26 ` Artem via Tarantool-patches [this message] 2021-01-18 12:45 ` [Tarantool-patches] [PATCHv4 2/3] test: add separated module for proccess operations with timeout Artem Starshov via Tarantool-patches 2021-01-18 12:45 ` [Tarantool-patches] [PATCHv4 3/3] test: change -e assert(false) test using process_timeout module Artem Starshov via Tarantool-patches 2021-01-21 16:23 ` Sergey Bronnikov via Tarantool-patches 2021-01-26 10:25 ` Artem via Tarantool-patches 2021-01-18 12:47 ` [Tarantool-patches] [PATCHv4 0/3] test: -e assert(false) fixup Artem via Tarantool-patches 2021-01-21 16:23 ` Sergey Bronnikov via Tarantool-patches 2021-01-27 13:19 ` Kirill Yukhin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=dce7f5d3-d9c3-ef92-49d9-47879e24f445@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=artemreyt@tarantool.org \ --cc=sergeyb@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCHv4 1/3] test: change timeout in -e assert(false) test' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox