From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7233F7030B; Tue, 26 Jan 2021 13:26:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7233F7030B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611656801; bh=CjgPRSLfYYIK/jN19+RP0OOeoxTpeQicyEkPcTUqFfk=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=uzvL3vKJ34LoFUuyvquOotyhZYnfyMZZcqAYCfsKgILWMM38htUtVtLSFm2Kep8Th gPTkq5xMffv7mbyu9Q36TPqfrRlp1NUcaV+Un2puTIVOsjKsx5bq66J4jHQ1yGhOxJ vqDlbS3GkaOiAGdjN/zDnlMaQz7J5Ig8DZTRlZIM= Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2F2057030B for ; Tue, 26 Jan 2021 13:26:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2F2057030B Received: by smtp41.i.mail.ru with esmtpa (envelope-from ) id 1l4LYV-0006y3-BT; Tue, 26 Jan 2021 13:26:39 +0300 To: Sergey Bronnikov , Alexander Turenko References: <880fc79c-715e-4db2-02fd-d7b8e73ca9d0@tarantool.org> Message-ID: Date: Tue, 26 Jan 2021 13:26:39 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <880fc79c-715e-4db2-02fd-d7b8e73ca9d0@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: ru X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92BC6D7A73B5E1EC9E9902A44F577D7AF667D68DB0D7EAFAB00894C459B0CD1B951550DE1DABCAD3CC912172AFD6EFB26D34DEBE8D8E5555B66B8565FC0A35870 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72AC9FB60380F23AEEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D70459436292EC88638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC383AF4AEF47C6929822C57E5741C78C2357B9334BDD37AE9389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A3E989B1926288338941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6D082881546D93491CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22495F2EF38EB7AA197676E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8BA981CCA5CC81B30A3AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE7C13763150CD373CE67F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C35F8DE6EDFC08462535872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C9DE2850DD75B2526BE5BFE6E7EFDEDCD789D4C264860C145E X-C1DE0DAB: 0D63561A33F958A59F84ECBEB24F6B74EAA8617E30D5E1D204204DBFD00E3B8DD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AC632F0BE69382F33850F7986E9642AEF405E7343DEAC50EBEEA40E62E112A02F04F36DEE7B9E8921D7E09C32AA3244CE7E6617056B7004311843628AC92AD1AF165894D92D62706927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbLwCnVtyrifSFFGJrzfW6w== X-Mailru-Sender: 65CD03CFE33A0EC7A4D6F6B2DF798FE6EFF76846ECEF495921BDB63C58299894E9B160859FB34FFFB08A37556DE0CB7BB7E364AFDB3F206FD953F29DB7D76D89B1E6F68DAE724AB9112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCHv4 1/3] test: change timeout in -e assert(false) test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Artem via Tarantool-patches Reply-To: Artem Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, thanks for review! 21.01.2021 19:20, Sergey Bronnikov пишет: > Thanks for the patch! > > I think it would be more clear if you will add reasons > > why we need to reduce timeout for two times. Done. > > On 18.01.2021 15:45, Artem Starshov wrote: >> Set timeout to 60 sec for waiting operations with process, >> like in default timeout for `cond_wait` in test-run. >> >> Follows up #4983 >> --- >>   test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua | 8 +++++--- >>   1 file changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua >> b/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua >> index 656fe212b..c8313770e 100755 >> --- a/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua >> +++ b/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua >> @@ -60,10 +60,12 @@ local TARANTOOL_PATH = arg[-1] >>   local output_file = fio.abspath('out.txt') >>   local line = ('%s -e "assert(false)" > %s 2>&1 & echo $!'): >>           format(TARANTOOL_PATH, output_file) >> -local process_waiting_timeout = 30.0 >> -local file_read_timeout = 30.0 >> + >> +-- Like a default timeout for `cond_wait` in test-run >> +local process_waiting_timeout = 60.0 >> +local file_read_timeout = 60.0 >> +local file_open_timeout = 60.0 >>   local file_read_interval = 0.2 >> -local file_open_timeout = 30.0 >>     local res = tap.test('gh-4983-tnt-e-assert-false-hangs', >> function(test) >>       test:plan(2)