Re: [Tarantool-patches] [PATCHv4 0/3] test: -e assert(false) fixup

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

LGTM

On 18.01.2021 15:45, Artem Starshov wrote:
> Changes in v2:
>      - changed commit message name
>      - added 'follows up #4983'
>      - removed collecting details about process due to Linux specific
>      - left only the last commit because the previous was pushed to master
>      and the first one is empty after the review
>      - added comment describing the reason of using timeout module in
>      presence of built-in 'popen' module
>
> Changes in v3:
>      - split one commit into two: first - increase timeout, second - move
>      helper functions to separated module
>
> Changes in v4:
>      - split two commits into 3: first - increase timeout, second - add module
>      process_timeout, third - modify -e assert(false) test using process_timeout.
>      Creating module `process_timeout` in separate commit is convenient for working
>      under other tests using this module while this patch isn't pushed on master.
>
> Artem Starshov (3):
>    test: change timeout in -e assert(false) test
>    test: add separated module for proccess operations with timeout
>    test: change -e assert(false) test using process_timeout module
>
>   .../gh-4983-tnt-e-assert-false-hangs.test.lua | 70 ++++---------------
>   test/app-tap/lua/process_timeout.lua          | 59 ++++++++++++++++
>   test/app-tap/suite.ini                        |  2 +-
>   3 files changed, 74 insertions(+), 57 deletions(-)
>   create mode 100644 test/app-tap/lua/process_timeout.lua
>