From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4CDCE70310; Wed, 27 Jan 2021 16:19:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4CDCE70310 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611753588; bh=FEINV4GeSmuVqRLrG4rAEi0qL1731oWcYHWAGBtbft0=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=QUjImwQCj9CD4OJLUfepre1mMaLoL+x+x5/FaslKArSNCTV2g+CS06BXftQYr8JH2 i4tSnfhfPZe0wnl3V4CcFh6PC9lGHNIzGcEY0Yx9+rVD0cFEdh1rLKcIBOHJceYsSD Xb0TTunv/NR43Jx0grkwiPuxDegKo3b6/elKGt1k= Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3449670310 for ; Wed, 27 Jan 2021 16:19:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3449670310 Received: by smtp57.i.mail.ru with esmtpa (envelope-from ) id 1l4kjZ-0001m3-7d; Wed, 27 Jan 2021 16:19:45 +0300 Date: Wed, 27 Jan 2021 13:19:44 +0000 To: Artem Starshov Cc: Alexander Turenko , tarantool-patches@dev.tarantool.org Message-ID: <20210127131944.a6aibbznprizu3qu@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92BC6D7A73B5E1EC98EC91D74BAC48C3C5ED0B073A515FC4C00894C459B0CD1B9DEED7F14C04AAFA6402B33DC6BA2755F346F7EB720D382790E2CF4D6E7A7A002 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C2204D4F9A221771EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637BFD6B3F1638522B88638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCBC5401B145ECB218F65C4FD48FAB577A201250BC2C9704C2389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07734D68A6916D8318941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B62AA437DA6D0FD557CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22495C137F56075BEB0576E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8B6A03BDC6CE4C620F3AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE7742996B5449390BC67F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C3515BD7C68D321F4835872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C9A9D40E7E712575E3574AF45C6390F7469DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5A18CB7913A1A132D462C72B36767C01443A5EA70A3090612D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3454CC76E5F54B410C2A95168E6C032436EF82508DC753C99BF71BE8EE118448A93A4C451469C06BE41D7E09C32AA3244C46DAC6DEB0592789A82D7901438A3935D9ADFF0C0BDB8D1FFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj5ZUBkD5pAd8rS0hZHUjMnQ== X-Mailru-Sender: 05EB39F83D09414F9B5D7F52D7CDFDD2509D723867D664AE08186FC05A2F90475DE42FAD6F97287CCA16B95394F0DD5CE99530A0C0F27B5268329DCED823713783C0E760C018FF54112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCHv4 0/3] test: -e assert(false) fixup X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kirill Yukhin via Tarantool-patches Reply-To: Kirill Yukhin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello, On 18 янв 15:45, Artem Starshov via Tarantool-patches wrote: > Changes in v2: > - changed commit message name > - added 'follows up #4983' > - removed collecting details about process due to Linux specific > - left only the last commit because the previous was pushed to master > and the first one is empty after the review > - added comment describing the reason of using timeout module in > presence of built-in 'popen' module > > Changes in v3: > - split one commit into two: first - increase timeout, second - move > helper functions to separated module > > Changes in v4: > - split two commits into 3: first - increase timeout, second - add module > process_timeout, third - modify -e assert(false) test using process_timeout. > Creating module `process_timeout` in separate commit is convenient for working > under other tests using this module while this patch isn't pushed on master. > > Artem Starshov (3): > test: change timeout in -e assert(false) test > test: add separated module for proccess operations with timeout > test: change -e assert(false) test using process_timeout module I've checked your patchset into 1.10, 2.6, 2.7 and master. -- Regards, Kirill Yukhin