Re: [Tarantool-patches] [PATCH 10/10] build: Enable 'make luacheck' target.

[Sergey Bronnikov <sergeyb@tarantool.org>]

Igor,

thanks for review. Both issues fixed in a branch.

On 23:45 Tue 26 May , Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch, it LGTM except the couple of nits I mentioned
> below, please consider them.
> 
> Typo: since you use prefix 'build: ' please "lcfirst" the next word to
> fit our contribution guidelines.

AFAIU you mean 'make first letter lower case', if so I have fixed it in
a branch. (Also removed extra whitespace before 'target' and removed
dot in a commit message summary.)

> On 12.05.20, Sergey Bronnikov wrote:
<snipped>

> > +#
> > +# Enable 'make luacheck' target.
> > +#
> > +
> > +add_custom_target(luacheck)
> > +add_custom_command(TARGET luacheck
> > +COMMAND ${LUACHECK} --codes --config "${PROJECT_SOURCE_DIR}/.luacheckrc" "${PROJECT_SOURCE_DIR}"
> > +COMMENT "Perform static analysis of Lua code"
> 
> Minor: Unfortunately, we don't have any CMake code style doc, but please
> adjust the indentation according to the one used nearby.

Fixed indentation.

<snipped>