From: Igor Munkin <imun@tarantool.org>
To: sergeyb@tarantool.org
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
alexander.turenko@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v5 05/10] Fix luacheck warnings in src/lua/
Date: Wed, 27 May 2020 14:22:13 +0300 [thread overview]
Message-ID: <20200527112212.GV5455@tarantool.org> (raw)
In-Reply-To: <40e8da837e206592e5dd623284d1506ef57aec56.1589275364.git.sergeyb@tarantool.org>
Sergey,
Thanks for the patch, LGTM!
On 12.05.20, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
>
> Closes #4681
>
> Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Reviewed-by: Igor Munkin <imun@tarantool.org>
>
> Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Co-authored-by: Igor Munkin <imun@tarantool.org>
> ---
> src/lua/argparse.lua | 6 ++--
> src/lua/buffer.lua | 4 +--
> src/lua/clock.lua | 2 +-
> src/lua/crypto.lua | 4 +--
> src/lua/csv.lua | 5 ++-
> src/lua/digest.lua | 2 +-
> src/lua/env.lua | 2 +-
> src/lua/fiber.lua | 4 +--
> src/lua/fio.lua | 37 +++++++++++----------
> src/lua/help.lua | 7 ++--
> src/lua/httpc.lua | 3 --
> src/lua/init.lua | 7 ++--
> src/lua/msgpackffi.lua | 22 +++++--------
> src/lua/socket.lua | 65 ++++++++++++++++++-------------------
> src/lua/string.lua | 1 -
> src/lua/swim.lua | 10 +++---
> src/lua/tap.lua | 74 ++++++++++++++++++++----------------------
> src/lua/trigger.lua | 3 --
> 18 files changed, 120 insertions(+), 138 deletions(-)
>
<snipped>
> --
> 2.23.0
>
--
Best regards,
IM
next prev parent reply other threads:[~2020-05-27 11:30 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 9:49 [Tarantool-patches] [PATCH v5 00/10] Add static analysis with luacheck sergeyb
2020-05-12 9:49 ` [Tarantool-patches] [PATCH v5 01/10] Add initial luacheck config sergeyb
2020-05-26 22:15 ` Igor Munkin
2020-05-28 15:31 ` Sergey Bronnikov
2020-05-28 16:07 ` Sergey Bronnikov
2020-05-29 11:20 ` Igor Munkin
2020-11-10 14:30 ` Sergey Bronnikov
2020-11-10 14:49 ` Igor Munkin
2020-05-12 9:49 ` [Tarantool-patches] [PATCH v5 02/10] gitlab-ci: enable static analysis with luacheck sergeyb
2020-05-13 14:15 ` Alexander V. Tikhonov
2020-05-13 14:40 ` Sergey Bronnikov
2020-05-26 22:39 ` Igor Munkin
2020-05-28 10:03 ` Sergey Bronnikov
2020-05-12 9:49 ` [Tarantool-patches] [PATCH v5 03/10] Fix luacheck warnings in extra/dist/tarantoolctl.in sergeyb
2020-05-26 23:11 ` Igor Munkin
2020-05-28 10:13 ` Sergey Bronnikov
2020-05-12 9:49 ` [Tarantool-patches] [PATCH v5 04/10] Fix luacheck warnings in src/lua/ sergeyb
2020-05-27 11:22 ` Igor Munkin
2020-05-28 12:22 ` Sergey Bronnikov
2020-05-12 9:50 ` [Tarantool-patches] [PATCH v5 05/10] " sergeyb
2020-05-13 11:13 ` Sergey Bronnikov
2020-05-27 11:22 ` Igor Munkin [this message]
2020-05-12 9:50 ` [Tarantool-patches] [PATCH v5 06/10] Fix luacheck warnings in src/box/lua/ sergeyb
2020-05-27 16:54 ` Igor Munkin
2020-05-28 15:16 ` Sergey Bronnikov
2020-05-12 9:50 ` [Tarantool-patches] [PATCH v5 07/10] " sergeyb
2020-05-13 11:14 ` Sergey Bronnikov
2020-05-27 16:54 ` Igor Munkin
2020-05-28 11:19 ` Sergey Bronnikov
2020-05-12 9:50 ` [Tarantool-patches] [PATCH v5 08/10] Fix luacheck warnings in test/ sergeyb
2020-05-29 11:08 ` Igor Munkin
2020-05-29 14:08 ` Sergey Bronnikov
2020-05-12 9:50 ` [Tarantool-patches] [PATCH v5 09/10] Add luacheck supressions for luajit tests sergeyb
2020-05-26 20:45 ` Igor Munkin
2020-05-28 19:25 ` Sergey Bronnikov
2020-05-12 12:28 ` [Tarantool-patches] [PATCH 10/10] build: Enable 'make luacheck' target Sergey Bronnikov
2020-05-26 20:45 ` Igor Munkin
2020-05-28 9:59 ` Sergey Bronnikov
2020-05-26 20:38 ` [Tarantool-patches] [PATCH v5 11/10] test: fix warnings spotted by luacheck sergeyb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527112212.GV5455@tarantool.org \
--to=imun@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=o.piskunov@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v5 05/10] Fix luacheck warnings in src/lua/' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox