From: Sergey Bronnikov <sergeyb@tarantool.org> To: Igor Munkin <imun@tarantool.org> Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, alexander.turenko@tarantool.org Subject: Re: [Tarantool-patches] [PATCH v5 08/10] Fix luacheck warnings in test/ Date: Fri, 29 May 2020 17:08:21 +0300 [thread overview] Message-ID: <20200529140821.GA44219@pony.bronevichok.ru> (raw) In-Reply-To: <20200529110800.GD21558@tarantool.org> Igor, thanks for review! On 14:08 Fri 29 May , Igor Munkin wrote: > Sergey, > > Thanks for the patch! The patch is huge, so please split it into > several, as we discussed. Nevertheless, I checked test/app-tap > directory, please consider my comments below. > > On 12.05.20, sergeyb@tarantool.org wrote: <snipped> > > 168 files changed, 1145 insertions(+), 1233 deletions(-) > > > > diff --git a/.luacheckrc b/.luacheckrc > > index e5c4c4509..26986ffb1 100644 > > --- a/.luacheckrc > > +++ b/.luacheckrc > > @@ -6,18 +6,18 @@ include_files = { > > <snipped> > > There is still a mess with suppressions, so I added the relevant ones > from the branch: > > | files["test/app-tap/lua/require_mod.lua"] = {globals = {"exports"}} > | files["test/app-tap/module_api.test.lua"] = {ignore = {"311"}} > > The suppression above seems to be excess and can be dropped. Removed. <snipped> > > local s1 = '☢' > > local s2 = 'İ' > > - test:is(s1 < s2, false, 'test binary cmp') > > - test:is(utf8.cmp(s1, s2) < 0, true, 'test unicode <') > > - test:is(utf8.cmp(s1, s1) == 0, true, 'test unicode eq') > > - test:is(utf8.cmp(s2, s1) > 0, true, 'test unicode >') > > - test:is(utf8.casecmp('a', 'A') == 0, true, 'test icase ==') > > - test:is(utf8.casecmp('b', 'A') > 0, true, 'test icase >, first') > > - test:is(utf8.casecmp('B', 'a') > 0, true, 'test icase >, second >') > > - test:is(utf8.cmp('', '') == 0, true, 'test empty compare') > > - test:is(utf8.cmp('', 'a') < 0, true, 'test left empty compare') > > - test:is(utf8.cmp('a', '') > 0, true, 'test right empty compare') > > - test:is(utf8.casecmp('', '') == 0, true, 'test empty icompare') > > - test:is(utf8.casecmp('', 'a') < 0, true, 'test left empty icompare') > > - test:is(utf8.casecmp('a', '') > 0, true, 'test right empty icompare') > > + testcase:is(s1 < s2, false, 'testcase binary cmp') > > + testcase:is(utf8.cmp(s1, s2) < 0, true, 'testcase unicode <') > > + testcase:is(utf8.cmp(s1, s1) == 0, true, 'testcase unicode eq') > > + testcase:is(utf8.cmp(s2, s1) > 0, true, 'testcase unicode >') > > + testcase:is(utf8.casecmp('a', 'A') == 0, true, 'testcase icase ==') > > + testcase:is(utf8.casecmp('b', 'A') > 0, true, 'testcase icase >, first') > > + testcase:is(utf8.casecmp('B', 'a') > 0, true, 'testcase icase >, second >') > > + testcase:is(utf8.cmp('', '') == 0, true, 'testcase empty compare') > > + testcase:is(utf8.cmp('', 'a') < 0, true, 'testcase left empty compare') > > + testcase:is(utf8.cmp('a', '') > 0, true, 'testcase right empty compare') > > + testcase:is(utf8.casecmp('', '') == 0, true, 'testcase empty icompare') > > + testcase:is(utf8.casecmp('', 'a') < 0, true, 'testcase left empty icompare') > > + testcase:is(utf8.casecmp('a', '') > 0, true, 'testcase right empty icompare') > > You also sed-ed test message above. Good catch! Fixed. <snipped>
next prev parent reply other threads:[~2020-05-29 14:09 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-12 9:49 [Tarantool-patches] [PATCH v5 00/10] Add static analysis with luacheck sergeyb 2020-05-12 9:49 ` [Tarantool-patches] [PATCH v5 01/10] Add initial luacheck config sergeyb 2020-05-26 22:15 ` Igor Munkin 2020-05-28 15:31 ` Sergey Bronnikov 2020-05-28 16:07 ` Sergey Bronnikov 2020-05-29 11:20 ` Igor Munkin 2020-11-10 14:30 ` Sergey Bronnikov 2020-11-10 14:49 ` Igor Munkin 2020-05-12 9:49 ` [Tarantool-patches] [PATCH v5 02/10] gitlab-ci: enable static analysis with luacheck sergeyb 2020-05-13 14:15 ` Alexander V. Tikhonov 2020-05-13 14:40 ` Sergey Bronnikov 2020-05-26 22:39 ` Igor Munkin 2020-05-28 10:03 ` Sergey Bronnikov 2020-05-12 9:49 ` [Tarantool-patches] [PATCH v5 03/10] Fix luacheck warnings in extra/dist/tarantoolctl.in sergeyb 2020-05-26 23:11 ` Igor Munkin 2020-05-28 10:13 ` Sergey Bronnikov 2020-05-12 9:49 ` [Tarantool-patches] [PATCH v5 04/10] Fix luacheck warnings in src/lua/ sergeyb 2020-05-27 11:22 ` Igor Munkin 2020-05-28 12:22 ` Sergey Bronnikov 2020-05-12 9:50 ` [Tarantool-patches] [PATCH v5 05/10] " sergeyb 2020-05-13 11:13 ` Sergey Bronnikov 2020-05-27 11:22 ` Igor Munkin 2020-05-12 9:50 ` [Tarantool-patches] [PATCH v5 06/10] Fix luacheck warnings in src/box/lua/ sergeyb 2020-05-27 16:54 ` Igor Munkin 2020-05-28 15:16 ` Sergey Bronnikov 2020-05-12 9:50 ` [Tarantool-patches] [PATCH v5 07/10] " sergeyb 2020-05-13 11:14 ` Sergey Bronnikov 2020-05-27 16:54 ` Igor Munkin 2020-05-28 11:19 ` Sergey Bronnikov 2020-05-12 9:50 ` [Tarantool-patches] [PATCH v5 08/10] Fix luacheck warnings in test/ sergeyb 2020-05-29 11:08 ` Igor Munkin 2020-05-29 14:08 ` Sergey Bronnikov [this message] 2020-05-12 9:50 ` [Tarantool-patches] [PATCH v5 09/10] Add luacheck supressions for luajit tests sergeyb 2020-05-26 20:45 ` Igor Munkin 2020-05-28 19:25 ` Sergey Bronnikov 2020-05-12 12:28 ` [Tarantool-patches] [PATCH 10/10] build: Enable 'make luacheck' target Sergey Bronnikov 2020-05-26 20:45 ` Igor Munkin 2020-05-28 9:59 ` Sergey Bronnikov 2020-05-26 20:38 ` [Tarantool-patches] [PATCH v5 11/10] test: fix warnings spotted by luacheck sergeyb
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200529140821.GA44219@pony.bronevichok.ru \ --to=sergeyb@tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=imun@tarantool.org \ --cc=o.piskunov@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v5 08/10] Fix luacheck warnings in test/' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox