From: Igor Munkin <imun@tarantool.org>
To: sergeyb@tarantool.org
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v5 02/10] gitlab-ci: enable static analysis with luacheck
Date: Wed, 27 May 2020 01:39:32 +0300 [thread overview]
Message-ID: <20200526223932.GS5455@tarantool.org> (raw)
In-Reply-To: <f0a3462530fc6ab517cc8bd8569d3620bc5b48eb.1589275364.git.sergeyb@tarantool.org>
Sergey,
Thanks, the patch LGTM, except a single nit I left below, please
consider it.
On 12.05.20, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
>
> Closes #4681
> ---
> .gitlab-ci.yml | 11 +++++++++++
> .travis.mk | 17 +++++++++++++++++
> 2 files changed, 28 insertions(+)
>
<snipped>
> diff --git a/.travis.mk b/.travis.mk
> index 8aa0e6116..3c8e627d0 100644
> --- a/.travis.mk
> +++ b/.travis.mk
> @@ -6,6 +6,8 @@ DOCKER_IMAGE?=packpack/packpack:debian-stretch
> TEST_RUN_EXTRA_PARAMS?=
> MAX_FILES?=65534
> MAX_PROC?=2500
> +LANES_ROCKSPEC="https://luarocks.org/manifests/benoitgermain/lanes-3.13.0-0.rockspec"
This constant seems to be unused, so can be dropped.
> +OOS_SRC_PATH="/source"
>
> all: package
>
<snipped>
> --
> 2.23.0
>
--
Best regards,
IM
next prev parent reply other threads:[~2020-05-26 22:47 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 9:49 [Tarantool-patches] [PATCH v5 00/10] Add " sergeyb
2020-05-12 9:49 ` [Tarantool-patches] [PATCH v5 01/10] Add initial luacheck config sergeyb
2020-05-26 22:15 ` Igor Munkin
2020-05-28 15:31 ` Sergey Bronnikov
2020-05-28 16:07 ` Sergey Bronnikov
2020-05-29 11:20 ` Igor Munkin
2020-11-10 14:30 ` Sergey Bronnikov
2020-11-10 14:49 ` Igor Munkin
2020-05-12 9:49 ` [Tarantool-patches] [PATCH v5 02/10] gitlab-ci: enable static analysis with luacheck sergeyb
2020-05-13 14:15 ` Alexander V. Tikhonov
2020-05-13 14:40 ` Sergey Bronnikov
2020-05-26 22:39 ` Igor Munkin [this message]
2020-05-28 10:03 ` Sergey Bronnikov
2020-05-12 9:49 ` [Tarantool-patches] [PATCH v5 03/10] Fix luacheck warnings in extra/dist/tarantoolctl.in sergeyb
2020-05-26 23:11 ` Igor Munkin
2020-05-28 10:13 ` Sergey Bronnikov
2020-05-12 9:49 ` [Tarantool-patches] [PATCH v5 04/10] Fix luacheck warnings in src/lua/ sergeyb
2020-05-27 11:22 ` Igor Munkin
2020-05-28 12:22 ` Sergey Bronnikov
2020-05-12 9:50 ` [Tarantool-patches] [PATCH v5 05/10] " sergeyb
2020-05-13 11:13 ` Sergey Bronnikov
2020-05-27 11:22 ` Igor Munkin
2020-05-12 9:50 ` [Tarantool-patches] [PATCH v5 06/10] Fix luacheck warnings in src/box/lua/ sergeyb
2020-05-27 16:54 ` Igor Munkin
2020-05-28 15:16 ` Sergey Bronnikov
2020-05-12 9:50 ` [Tarantool-patches] [PATCH v5 07/10] " sergeyb
2020-05-13 11:14 ` Sergey Bronnikov
2020-05-27 16:54 ` Igor Munkin
2020-05-28 11:19 ` Sergey Bronnikov
2020-05-12 9:50 ` [Tarantool-patches] [PATCH v5 08/10] Fix luacheck warnings in test/ sergeyb
2020-05-29 11:08 ` Igor Munkin
2020-05-29 14:08 ` Sergey Bronnikov
2020-05-12 9:50 ` [Tarantool-patches] [PATCH v5 09/10] Add luacheck supressions for luajit tests sergeyb
2020-05-26 20:45 ` Igor Munkin
2020-05-28 19:25 ` Sergey Bronnikov
2020-05-12 12:28 ` [Tarantool-patches] [PATCH 10/10] build: Enable 'make luacheck' target Sergey Bronnikov
2020-05-26 20:45 ` Igor Munkin
2020-05-28 9:59 ` Sergey Bronnikov
2020-05-26 20:38 ` [Tarantool-patches] [PATCH v5 11/10] test: fix warnings spotted by luacheck sergeyb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526223932.GS5455@tarantool.org \
--to=imun@tarantool.org \
--cc=o.piskunov@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v5 02/10] gitlab-ci: enable static analysis with luacheck' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox