Re: [Tarantool-patches] [PATCH v5 09/10] Add luacheck supressions for luajit tests

[Sergey Bronnikov <sergeyb@tarantool.org>]

Igor, thanks for review!

supression has been removed.

On 23:45 Tue 26 May , Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch! Since you've already fixed the warning <231> in
> test/luajit-tap/gh-4476-fix-string-find-recording.test.lua here[1], the
> corresponding suppression below can be removed.
>
> Furthermore, please bump LuaJIT submodule in scope of this patch, to
> pull the corresponding changes made in tarantool/luajit repo.
> 
> Otherwise, the patch LGTM, thanks!
> 
> On 12.05.20, sergeyb@tarantool.org wrote:
> > From: Sergey Bronnikov <sergeyb@tarantool.org>
> > 
> > Closes #4681
> > 
> > Reviewed-by: Igor Munkin <imun@tarantool.org>
> > ---
> >  .luacheckrc | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/.luacheckrc b/.luacheckrc
> > index 26986ffb1..62a0135d1 100644
> > --- a/.luacheckrc
> > +++ b/.luacheckrc
> > @@ -67,6 +67,8 @@ files["test/box/lua/fifo.lua"] = {globals = {"fifomax", "find_or_create_fifo", "
> >  files["test/box/lua/identifier.lua"] = {globals = {"run_test"}}
> >  files["test/box/lua/require_mod.lua"] = {globals = {"exports"}}
> >  files["test/engine/conflict.lua"] = {globals = {"test_conflict"}}
> > +files["test/luajit-tap/gh-4476-fix-string-find-recording.test.lua"] = {ignore = {"231"}}
> > +files["test/luajit-tap/or-232-unsink-64-kptr.test.lua"] = {ignore = {"542"}}
> >  files["test/replication/replica_quorum.lua"] = {globals = {"INSTANCE_URI", "nonexistent_uri"}}
> >  files["test/replication/replica_on_schema_init.lua"] = {globals = {"trig_local", "trig_engine"}}
> >  files["test/replication/lua/fast_replica.lua"] = {
> > -- 
> > 2.23.0
> > 
> 
> [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-May/017066.html
> 
> -- 
> Best regards,
> IM

-- 
sergeyb@