Re: [Tarantool-patches] [PATCH 10/10] build: Enable 'make luacheck' target.

[Igor Munkin <imun@tarantool.org>]

Sergey,

Thanks for the patch, it LGTM except the couple of nits I mentioned
below, please consider them.

Typo: since you use prefix 'build: ' please "lcfirst" the next word to
fit our contribution guidelines.

On 12.05.20, Sergey Bronnikov wrote:
> Closes #4681
> ---
>  CMakeLists.txt | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 1d80b6806..67c31c7d3 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt

<snipped>

> @@ -151,6 +152,16 @@ add_custom_target(tags COMMAND ${CTAGS} -R ${tagsExclude} -f tags
>      WORKING_DIRECTORY ${CMAKE_SOURCE_DIR})
>  add_custom_target(ctags DEPENDS tags)
>  
> +#
> +# Enable 'make luacheck' target.
> +#
> +
> +add_custom_target(luacheck)
> +add_custom_command(TARGET luacheck
> +COMMAND ${LUACHECK} --codes --config "${PROJECT_SOURCE_DIR}/.luacheckrc" "${PROJECT_SOURCE_DIR}"
> +COMMENT "Perform static analysis of Lua code"

Minor: Unfortunately, we don't have any CMake code style doc, but please
adjust the indentation according to the one used nearby.

> +)
> +
>  #
>  # Get version
>  #
> -- 
> 2.23.0
> 
> 
> -- 
> sergeyb@

-- 
Best regards,
IM