From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B07E7469710
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 26 May 2020 23:53:53 +0300 (MSK)
Date: Tue, 26 May 2020 23:45:28 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200526204528.GP5455@tarantool.org>
References: <cover.1589275364.git.sergeyb@tarantool.org>
 <3d316dca2f11fa089c3fbe9074d79356ee3f214c.1589286395.git.sergeyb@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <3d316dca2f11fa089c3fbe9074d79356ee3f214c.1589286395.git.sergeyb@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 10/10] build: Enable 'make luacheck'
 target.
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org

Sergey,

Thanks for the patch, it LGTM except the couple of nits I mentioned
below, please consider them.

Typo: since you use prefix 'build: ' please "lcfirst" the next word to
fit our contribution guidelines.

On 12.05.20, Sergey Bronnikov wrote:
> Closes #4681
> ---
>  CMakeLists.txt | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 1d80b6806..67c31c7d3 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt

<snipped>

> @@ -151,6 +152,16 @@ add_custom_target(tags COMMAND ${CTAGS} -R ${tagsExclude} -f tags
>      WORKING_DIRECTORY ${CMAKE_SOURCE_DIR})
>  add_custom_target(ctags DEPENDS tags)
>  
> +#
> +# Enable 'make luacheck' target.
> +#
> +
> +add_custom_target(luacheck)
> +add_custom_command(TARGET luacheck
> +COMMAND ${LUACHECK} --codes --config "${PROJECT_SOURCE_DIR}/.luacheckrc" "${PROJECT_SOURCE_DIR}"
> +COMMENT "Perform static analysis of Lua code"

Minor: Unfortunately, we don't have any CMake code style doc, but please
adjust the indentation according to the one used nearby.

> +)
> +
>  #
>  # Get version
>  #
> -- 
> 2.23.0
> 
> 
> -- 
> sergeyb@

-- 
Best regards,
IM