From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 94B71469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 27 May 2020 01:47:57 +0300 (MSK)
Date: Wed, 27 May 2020 01:39:32 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200526223932.GS5455@tarantool.org>
References: <cover.1589275364.git.sergeyb@tarantool.org>
 <f0a3462530fc6ab517cc8bd8569d3620bc5b48eb.1589275364.git.sergeyb@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <f0a3462530fc6ab517cc8bd8569d3620bc5b48eb.1589275364.git.sergeyb@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v5 02/10] gitlab-ci: enable static
 analysis with luacheck
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergeyb@tarantool.org
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org

Sergey,

Thanks, the patch LGTM, except a single nit I left below, please
consider it.

On 12.05.20, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> Closes #4681
> ---
>  .gitlab-ci.yml | 11 +++++++++++
>  .travis.mk     | 17 +++++++++++++++++
>  2 files changed, 28 insertions(+)
> 

<snipped>

> diff --git a/.travis.mk b/.travis.mk
> index 8aa0e6116..3c8e627d0 100644
> --- a/.travis.mk
> +++ b/.travis.mk
> @@ -6,6 +6,8 @@ DOCKER_IMAGE?=packpack/packpack:debian-stretch
>  TEST_RUN_EXTRA_PARAMS?=
>  MAX_FILES?=65534
>  MAX_PROC?=2500
> +LANES_ROCKSPEC="https://luarocks.org/manifests/benoitgermain/lanes-3.13.0-0.rockspec"

This constant seems to be unused, so can be dropped.

> +OOS_SRC_PATH="/source"
>  
>  all: package
>  

<snipped>

> -- 
> 2.23.0
> 

-- 
Best regards,
IM