From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 90BDB469710
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 28 May 2020 13:00:25 +0300 (MSK)
Date: Thu, 28 May 2020 12:59:28 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200528095928.GA5970@pony.bronevichok.ru>
References: <cover.1589275364.git.sergeyb@tarantool.org>
 <3d316dca2f11fa089c3fbe9074d79356ee3f214c.1589286395.git.sergeyb@tarantool.org>
 <20200526204528.GP5455@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200526204528.GP5455@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 10/10] build: Enable 'make luacheck'
 target.
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org

Igor,

thanks for review. Both issues fixed in a branch.

On 23:45 Tue 26 May , Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch, it LGTM except the couple of nits I mentioned
> below, please consider them.
> 
> Typo: since you use prefix 'build: ' please "lcfirst" the next word to
> fit our contribution guidelines.

AFAIU you mean 'make first letter lower case', if so I have fixed it in
a branch. (Also removed extra whitespace before 'target' and removed
dot in a commit message summary.)

> On 12.05.20, Sergey Bronnikov wrote:
<snipped>

> > +#
> > +# Enable 'make luacheck' target.
> > +#
> > +
> > +add_custom_target(luacheck)
> > +add_custom_command(TARGET luacheck
> > +COMMAND ${LUACHECK} --codes --config "${PROJECT_SOURCE_DIR}/.luacheckrc" "${PROJECT_SOURCE_DIR}"
> > +COMMENT "Perform static analysis of Lua code"
> 
> Minor: Unfortunately, we don't have any CMake code style doc, but please
> adjust the indentation according to the one used nearby.

Fixed indentation.

<snipped>