Re: [Tarantool-patches] [PATCH v2 luajit 6/6] ci: introduce workflow to test debugger extension

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the review!
Please, consider my answers below.

On 20.05.26, Sergey Bronnikov wrote:
> Hi, Sergey,
> 
> thanks for the patch! See my comments.
> 
> Sergey
> 
> On 5/19/26 15:39, Sergey Kaplun wrote:
> > The debugger extension test is run for both LLDB and GDB for GC64 and
> > non-GC64 builds for arm64 and x86_64.
> > ---
> >   .github/actions/setup-debuggers/README.md  | 13 +++++
> >   .github/actions/setup-debuggers/action.yml | 12 +++++
> >   .github/workflows/debuggers.yml            | 61 ++++++++++++++++++++++
> >   3 files changed, 86 insertions(+)
> >   create mode 100644 .github/actions/setup-debuggers/README.md
> >   create mode 100644 .github/actions/setup-debuggers/action.yml
> >   create mode 100644 .github/workflows/debuggers.yml
> >
> > diff --git a/.github/actions/setup-debuggers/README.md b/.github/actions/setup-debuggers/README.md
> > new file mode 100644
> > index 00000000..7c542ddb
> > --- /dev/null
> > +++ b/.github/actions/setup-debuggers/README.md
> > @@ -0,0 +1,13 @@
> > +# Setup environment for testing debugger extension on Linux
> > +
> > +Action setups the environment on Linux runners (install requirements, setup the
> > +workflow environment, etc.) for testing the python debugger extension for
> > +various debuggers.
> > +
> > +## How to use Github Action from Github workflow
> > +
> > +Add the following code to the running steps before LuaJIT configuration:
> > +```
> > +- uses: ./.github/actions/setup-debuggers
> > +  if: ${{ matrix.OS == 'Linux' }}
> > +```
> > diff --git a/.github/actions/setup-debuggers/action.yml b/.github/actions/setup-debuggers/action.yml
> > new file mode 100644
> > index 00000000..c34d4502
> > --- /dev/null
> > +++ b/.github/actions/setup-debuggers/action.yml
> > @@ -0,0 +1,12 @@
> > +name: Setup CI environment for testing the debugger extension
> > +description: The Linux machine setup for tests of the debugger extension
> > +runs:
> > +  using: composite
> > +  steps:
> > +    - name: Setup CI environment (Linux)
> > +      uses: ./.github/actions/setup-linux
> > +    - name: Install dependencies for the tests
> > +      run: |
> > +        apt -y update
> > +        apt install -y python3 gdb lldb
> 
> Why Python 3 only? AFAIR we discussed that Python 2 should be supported 
> as well,
> 
> it means we should test with Python 2 too.

Python 2 can't be easily installed on modern Ubuntu since this package
is removed due to its EOL. I tested GDB manually for ancient Python. I
suppose we will implement it as is and fix bugs for Python 2 by demand.

> 
> Also, should we test with the latest versions of GDB/LLDB?

Does apt install not provide the latest version?

> 

<snipped>

-- 
Best regards,
Sergey Kaplun