Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Mikhail Elhimov <m.elhimov@vk.team>,
	Sergey Bronnikov <sergeyb@tarantool.org>,
	Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v2 luajit 3/6] dbg: sort initialization of commands
Date: Tue, 19 May 2026 15:39:10 +0300	[thread overview]
Message-ID: <20260519123913.178775-4-skaplun@tarantool.org> (raw)
In-Reply-To: <20260519123913.178775-1-skaplun@tarantool.org>

This patch sorts the commands for extensions' initialization
alphabetically. Also, it fixes the typo in the lldb extension.

This allows enabling the loading test for LLDB as well.
---
 src/luajit-gdb.py                             |  8 ++---
 src/luajit_lldb.py                            |  8 ++---
 .../debug-extension-tests.py                  | 30 +++++++++----------
 3 files changed, 22 insertions(+), 24 deletions(-)

diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py
index dab07b35..be67bf18 100644
--- a/src/luajit-gdb.py
+++ b/src/luajit-gdb.py
@@ -872,12 +872,12 @@ def init(commands):
 def load(event=None):
     init({
         'lj-arch':  LJDumpArch,
-        'lj-tv':    LJDumpTValue,
-        'lj-str':   LJDumpString,
-        'lj-tab':   LJDumpTable,
+        'lj-gc':    LJGC,
         'lj-stack': LJDumpStack,
         'lj-state': LJState,
-        'lj-gc':    LJGC,
+        'lj-str':   LJDumpString,
+        'lj-tab':   LJDumpTable,
+        'lj-tv':    LJDumpTValue,
     })
 
 
diff --git a/src/luajit_lldb.py b/src/luajit_lldb.py
index 218cc8d1..7668a94c 100644
--- a/src/luajit_lldb.py
+++ b/src/luajit_lldb.py
@@ -958,7 +958,7 @@ def register_commands(debugger, commands):
                 cmd=cls.command,
             )
         )
-        print('{cmd} command intialized'.format(cmd=cls.command))
+        print('{cmd} command initialized'.format(cmd=cls.command))
 
 
 def configure(debugger):
@@ -986,12 +986,12 @@ def configure(debugger):
 def __lldb_init_module(debugger, internal_dict):
     configure(debugger)
     register_commands(debugger, {
-        'lj-tv':    LJDumpTValue,
-        'lj-state': LJState,
         'lj-arch':  LJDumpArch,
         'lj-gc':    LJGC,
+        'lj-stack': LJDumpStack,
+        'lj-state': LJState,
         'lj-str':   LJDumpString,
         'lj-tab':   LJDumpTable,
-        'lj-stack': LJDumpStack,
+        'lj-tv':    LJDumpTValue,
     })
     print('luajit_lldb.py is successfully loaded')
diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py
index 11c2492b..f3ce3ced 100644
--- a/test/tarantool-debugger-tests/debug-extension-tests.py
+++ b/test/tarantool-debugger-tests/debug-extension-tests.py
@@ -125,22 +125,20 @@ class TestCaseBase(unittest.TestCase):
             self.assertRegex(self.output, self.pattern.strip())
 
 
-# FIXME: Skip for LLDB since it has different order.
-if not LLDB:
-    class TestLoad(TestCaseBase):
-        extension_cmds = ''
-        location = 'lj_cf_print'
-        lua_script = 'print(1)'
-        pattern = (
-            r'lj-arch command initialized\n'
-            r'lj-tv command initialized\n'
-            r'lj-str command initialized\n'
-            r'lj-tab command initialized\n'
-            r'lj-stack command initialized\n'
-            r'lj-state command initialized\n'
-            r'lj-gc command initialized\n'
-            r'.*is successfully loaded'
-        )
+class TestLoad(TestCaseBase):
+    extension_cmds = ''
+    location = 'lj_cf_print'
+    lua_script = 'print(1)'
+    pattern = (
+        r'lj-arch command initialized\n'
+        r'lj-gc command initialized\n'
+        r'lj-stack command initialized\n'
+        r'lj-state command initialized\n'
+        r'lj-str command initialized\n'
+        r'lj-tab command initialized\n'
+        r'lj-tv command initialized\n'
+        r'.*is successfully loaded'
+    )
 
 
 class TestLJArch(TestCaseBase):
-- 
2.53.0


  parent reply	other threads:[~2026-05-19 12:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 12:39 [Tarantool-patches] [PATCH v2 luajit 0/6] Unified extension for debuggers Sergey Kaplun via Tarantool-patches
2026-05-19 12:39 ` [Tarantool-patches] [PATCH v2 luajit 1/6] test: introduce tests for debugging extensions Sergey Kaplun via Tarantool-patches
2026-05-19 12:39 ` [Tarantool-patches] [PATCH v2 luajit 2/6] lldb: refactor extension Sergey Kaplun via Tarantool-patches
2026-05-19 12:39 ` Sergey Kaplun via Tarantool-patches [this message]
2026-05-19 12:39 ` [Tarantool-patches] [PATCH v2 luajit 4/6] lldb: support full-range 64-bit lightuserdata Sergey Kaplun via Tarantool-patches
2026-05-19 12:39 ` [Tarantool-patches] [PATCH v2 luajit 5/6] dbg: generalize extension Sergey Kaplun via Tarantool-patches
2026-05-19 12:39 ` [Tarantool-patches] [PATCH v2 luajit 6/6] ci: introduce workflow to test debugger extension Sergey Kaplun via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260519123913.178775-4-skaplun@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=e.temirgaleev@tarantool.org \
    --cc=m.elhimov@vk.team \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2 luajit 3/6] dbg: sort initialization of commands' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox