Tarantool development patches archive
 help / color / mirror / Atom feed
From: Evgeniy Temirgaleev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Sergey Kaplun" <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches]  [PATCH v2 luajit 1/6] test: introduce tests for debugging extensions
Date: Tue, 26 May 2026 21:52:11 +0300	[thread overview]
Message-ID: <1779821531.981652053@f468.i.mail.ru> (raw)
In-Reply-To: <ahWxCzGchb0sfrft@root>

[-- Attachment #1: Type: text/plain, Size: 4517 bytes --]

Hi, Sergey!

> Fixed your comment and force-pushed the branch.

Thanks for the patch!

Also, I have a problem to run lldb tests inside Docker container with Ubuntu 24.04.

The gdb produce a warning «Error disabling address space randomization: Operation not permitted» only, but lldb produce an error «Cannot launch '/xxx/src/luajit': personality set failed: Operation not permitted» and don’t want to continue without disabling the ASLR. ‘/xxx’ is my build directory.

Please, consider this fix:

diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py
index f337f0e9..65eefd0c 100644
--- a/test/tarantool-debugger-tests/debug-extension-tests.py
+++ b/test/tarantool-debugger-tests/debug-extension-tests.py
@@ -22,7 +22,7 @@ TIMEOUT = 10
if LLDB:
INFERIOR_ARGS = '--'
LOAD_EXTENSION = 'command script import ' + EXTENSION
-    PROCESS_RUN = 'process launch'
+    PROCESS_RUN = 'settings set target.disable-aslr false\nprocess launch'
# Don't run any initialization scripts.
RUN_CMD_FILE = [
'--batch',

--
Best regards,
Evgeniy Temirgaleev

> 
> From: Sergey Kaplun <skaplun@tarantool.org>
> To: Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
> Cc: tarantool-patches@dev.tarantool.org, Mikhail Elhimov <m.elhimov@vk.team
> >, Sergey Bronnikov <sergeyb@tarantool.org>
> Date: Tuesday, May 26, 2026 5:42 PM +03:00
> Hi, Evgeniy!
> Thanks for the review!
> Fixed your comment and force-pushed the branch.
> 
> On 26.05.26, Evgeniy Temirgaleev wrote:
> > Hi, Sergey!
> >
> > Thanks for the patch. Please, consider my suggestion: the debugger-aware
> «constants» are defined in one block per debugger.
> >
> > diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py
> b/test/tarantool-debugger-tests/debug-extension-tests.py
> > index 30a2c478..f4414f4d 100644
> > --- a/test/tarantool-debugger-tests/debug-extension-tests.py
> > +++ b/test/tarantool-debugger-tests/debug-extension-tests.py
> > @@ -19,9 +19,6 @@ LLDB = 'lldb' in DEBUGGER
> > EXTENSION = EXTENSION_PATH + '/luajit_dbg.py'
> > TIMEOUT = 10
> >
> > -# Don't run any initialization scripts.
> > -RUN_CMD_FILE = []
> > -
> > if LLDB:
> > RUN_CMD_FILE = [
> > '--batch',
> > @@ -30,15 +27,15 @@ if LLDB:
> > '--source-quietly',
> > '--source'
> > ]
> > +    INFERIOR_ARGS = '--'
> > +    PROCESS_RUN = 'process launch'
> > +    LOAD_EXTENSION = 'command script import
> {ext}'.format(ext=EXTENSION)
> > else:
> > # GDB.
> > RUN_CMD_FILE = ['--batch', '--nx', '--quiet', '--command']
> > -
> > -INFERIOR_ARGS = '--' if LLDB else '--args'
> > -PROCESS_RUN = 'process launch' if LLDB else 'r'
> > -LOAD_EXTENSION = (
> > -    'command script import {ext}' if LLDB else 'source {ext}'
> > -).format(ext=EXTENSION)
> > +    INFERIOR_ARGS = '--args'
> > +    PROCESS_RUN = 'r'
> > +    LOAD_EXTENSION = 'source {ext}'.format(ext=EXTENSION)
> 
> Fixed. See the iterative patch below:
> 
> ===================================================================
> diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py
> b/test/tarantool-debugger-tests/debug-extension-tests.py
> index 30a2c478..f337f0e9 100644
> --- a/test/tarantool-debugger-tests/debug-extension-tests.py
> +++ b/test/tarantool-debugger-tests/debug-extension-tests.py
> @@ -19,10 +19,11 @@ LLDB = 'lldb' in DEBUGGER
> EXTENSION = EXTENSION_PATH + '/luajit_dbg.py'
> TIMEOUT = 10
> 
> -# Don't run any initialization scripts.
> -RUN_CMD_FILE = []
> -
> if LLDB:
> + INFERIOR_ARGS = '--'
> + LOAD_EXTENSION = 'command script import ' + EXTENSION
> + PROCESS_RUN = 'process launch'
> + # Don't run any initialization scripts.
> RUN_CMD_FILE = [
> '--batch',
> '--no-lldbinit',
> @@ -32,15 +33,12 @@ if LLDB:
> ]
> else:
> # GDB.
> + INFERIOR_ARGS = '--args'
> + LOAD_EXTENSION = 'source ' + EXTENSION
> + PROCESS_RUN = 'run'
> + # Don't run any initialization scripts.
> RUN_CMD_FILE = ['--batch', '--nx', '--quiet', '--command']
> 
> -INFERIOR_ARGS = '--' if LLDB else '--args'
> -PROCESS_RUN = 'process launch' if LLDB else 'r'
> -LOAD_EXTENSION = (
> - 'command script import {ext}' if LLDB else 'source {ext}'
> -).format(ext=EXTENSION)
> -
> -
> RX_ADDR = r'0x[a-f0-9]+'
> RX_HASH = RX_ADDR # The same pattern for hexademic values.
> RX_FRAME = r'\[(S|\s)(B|\s)(T|\s)(M|\s)\]'
> ===================================================================
> 
> >
> > --
> > Best regards,
> > Evgeniy Temirgaleev
> >
> > >
> 
> <snipped>
> 
> --
> Best regards,
> Sergey Kaplun
>

[-- Attachment #2: Type: text/html, Size: 6056 bytes --]

  reply	other threads:[~2026-05-26 18:52 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 12:39 [Tarantool-patches] [PATCH v2 luajit 0/6] Unified extension for debuggers Sergey Kaplun via Tarantool-patches
2026-05-19 12:39 ` [Tarantool-patches] [PATCH v2 luajit 1/6] test: introduce tests for debugging extensions Sergey Kaplun via Tarantool-patches
2026-05-20 13:38   ` Sergey Bronnikov via Tarantool-patches
2026-05-25  9:14     ` Sergey Kaplun via Tarantool-patches
2026-05-27  9:54       ` Sergey Bronnikov via Tarantool-patches
2026-05-27 10:52         ` Sergey Kaplun via Tarantool-patches
2026-05-26 13:50   ` Evgeniy Temirgaleev via Tarantool-patches
2026-05-26 14:41     ` Sergey Kaplun via Tarantool-patches
2026-05-26 18:52       ` Evgeniy Temirgaleev via Tarantool-patches [this message]
2026-05-27  7:56         ` Sergey Kaplun via Tarantool-patches
2026-05-27 12:41   ` Sergey Bronnikov via Tarantool-patches
2026-05-19 12:39 ` [Tarantool-patches] [PATCH v2 luajit 2/6] lldb: refactor extension Sergey Kaplun via Tarantool-patches
2026-05-27 12:27   ` Sergey Bronnikov via Tarantool-patches
2026-05-19 12:39 ` [Tarantool-patches] [PATCH v2 luajit 3/6] dbg: sort initialization of commands Sergey Kaplun via Tarantool-patches
2026-05-20 13:43   ` Sergey Bronnikov via Tarantool-patches
2026-05-19 12:39 ` [Tarantool-patches] [PATCH v2 luajit 4/6] lldb: support full-range 64-bit lightuserdata Sergey Kaplun via Tarantool-patches
2026-05-27 12:28   ` Sergey Bronnikov via Tarantool-patches
2026-05-19 12:39 ` [Tarantool-patches] [PATCH v2 luajit 5/6] dbg: generalize extension Sergey Kaplun via Tarantool-patches
2026-05-27 12:38   ` Sergey Bronnikov via Tarantool-patches
2026-05-27 12:55     ` Sergey Kaplun via Tarantool-patches
2026-05-19 12:39 ` [Tarantool-patches] [PATCH v2 luajit 6/6] ci: introduce workflow to test debugger extension Sergey Kaplun via Tarantool-patches
2026-05-20 13:52   ` Sergey Bronnikov via Tarantool-patches
2026-05-25  7:00     ` Sergey Kaplun via Tarantool-patches
2026-05-27 10:57       ` Sergey Bronnikov via Tarantool-patches
2026-05-27 11:58         ` Sergey Kaplun via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1779821531.981652053@f468.i.mail.ru \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=e.temirgaleev@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches]  [PATCH v2 luajit 1/6] test: introduce tests for debugging extensions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox