Re: [Tarantool-patches] [PATCH v2 luajit 1/6] test: introduce tests for debugging extensions

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 4126 bytes --]

Hi, Sergey,

LGTM with a comment below.

Sergey

On 5/25/26 12:14, Sergey Kaplun wrote:

<snipped>

>>> diff --git a/test/tarantool-debugger-tests/CMakeLists.txt b/test/tarantool-debugger-tests/CMakeLists.txt
>>> new file mode 100644
>>> index 00000000..7fd0debc
>>> --- /dev/null
>>> +++ b/test/tarantool-debugger-tests/CMakeLists.txt
>>> @@ -0,0 +1,93 @@
>>> +set(TEST_SUITE_NAME "tarantool-debugger-tests")
>>> +
>>> +# XXX: The call produces both test and target
>>> +# <tarantool-debugger-tests-deps> as a side effect.
>>> +add_test_suite_target(tarantool-debugger-tests
>>> +  LABELS ${TEST_SUITE_NAME}
>>> +  DEPENDS ${LUAJIT_TEST_BINARY}
>>> +)
>>> +
>>> +# Debug info is required for testing of extensions.
>>> +if(NOT (CMAKE_BUILD_TYPE MATCHES Debug))
>>> +  message(WARNING
>>> +    "Not a DEBUG build, tarantool-debugger-tests is dummy"
>>> +  )
>> it is not dummy, it doesn't exist at all:
>>
>> cmake -S . -B build -DCMAKE_BUILD_TYPE=Release
>>
>> cd build
>>
>> make tarantool-debugger-tests
>> make[3]: *** No rule to make target 'src/luajit', needed by
>> 'test/tarantool-debugger-tests/CMakeFiles/tarantool-debugger-tests-deps'.
>> Stop.
> Replaced elsewhere with "omitted". =================================================================== 
> diff --git a/test/tarantool-debugger-tests/CMakeLists.txt 
> b/test/tarantool-debugger-tests/CMakeLists.txt index 
> 7fd0debc..a6684e72 100644 --- 
> a/test/tarantool-debugger-tests/CMakeLists.txt +++ 
> b/test/tarantool-debugger-tests/CMakeLists.txt @@ -10,7 +10,7 @@ 
> add_test_suite_target(tarantool-debugger-tests # Debug info is 
> required for testing of extensions. if(NOT (CMAKE_BUILD_TYPE MATCHES 
> Debug)) message(WARNING - "Not a DEBUG build, tarantool-debugger-tests is dummy"
> +    "Not a DEBUG build, tarantool-debugger-tests is omitted"
>     )
>     return()
>   endif()
> @@ -22,7 +22,7 @@ endif()
>   if(CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND DEFINED ENV{CI})
>     message(WARNING
>       "Interactive debugging is unavailable for macOS CI builds,"
> -    " tarantool-debugger-tests is dummy"
> +    " tarantool-debugger-tests is omitted"
>     )
>     return()
>   endif()
> @@ -31,13 +31,17 @@ if(CMAKE_VERSION VERSION_LESS "3.12")
>     #TODO:Can remove this after upgrading to CMake >= 3.12.
>     find_package(PythonInterp)
>     if(NOT PYTHONINTERP_FOUND)
> -    message(WARNING "`python` is not found, tarantool-debugger-tests is dummy")
> +    message(WARNING
> +      "`python` is not found, tarantool-debugger-tests is omitted"
> +    )
>       return()
>     endif()
>   else()
>     find_package(Python COMPONENTS Interpreter)
>     if(NOT PYTHON_FOUND)
> -    message(WARNING "`python` is not found, tarantool-debugger-tests is dummy")
> +    message(WARNING
> +      "`python` is not found, tarantool-debugger-tests is omitted"
> +    )
>       return()
>     endif()
>     set(PYTHON_EXECUTABLE "${Python_EXECUTABLE}")
> ===================================================================

Let's create a target after checking requirements:

diff --git a/test/tarantool-debugger-tests/CMakeLists.txt 
b/test/tarantool-debugger-tests/CMakeLists.txt
index 39414db3..ab90b803 100644
--- a/test/tarantool-debugger-tests/CMakeLists.txt
+++ b/test/tarantool-debugger-tests/CMakeLists.txt
@@ -1,12 +1,5 @@
  set(TEST_SUITE_NAME "tarantool-debugger-tests")

-# XXX: The call produces both test and target
-# <tarantool-debugger-tests-deps> as a side effect.
-add_test_suite_target(tarantool-debugger-tests
-  LABELS ${TEST_SUITE_NAME}
-  DEPENDS ${LUAJIT_TEST_BINARY}
-)
-
  # Debug info is required for testing of extensions.
  if(NOT (CMAKE_BUILD_TYPE MATCHES Debug))
    message(WARNING
@@ -47,6 +40,13 @@ else()
    set(PYTHON_EXECUTABLE "${Python_EXECUTABLE}")
  endif()

+# XXX: The call produces both test and target
+# <tarantool-debugger-tests-deps> as a side effect.
+add_test_suite_target(tarantool-debugger-tests
+  LABELS ${TEST_SUITE_NAME}
+  DEPENDS ${LUAJIT_TEST_BINARY}
+)
+
  set(DEBUGGER_TEST_ENV
    "LUAJIT_TEST_BINARY=${LUAJIT_TEST_BINARY}"
    # Suppresses __pycache__ generation.

<snipped>

[-- Attachment #2: Type: text/html, Size: 5772 bytes --]