From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3C8596ECE6; Wed, 27 May 2026 12:54:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3C8596ECE6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1779875673; bh=ZzsL5bfp/zm4EK0esL6EI7gEMQfCqtF/TV3WccYjlYE=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=KmmSODZjI0W1TtK0kpiUuFMuzVYR+LdEgmSfeYeLrkTPCQOx7yVf706gQbmsCY3d5 /QZYultBR1yWEPfz+YDdVnSNeekDrGYZNiVy/V4xwN3OJhKLXLQHuiUwBqc1ENn0gJ qxAJd8LUy6fwnSA15Av0oE8ZFWUpyQMRY4PNIvmE= Received: from send129.i.mail.ru (send129.i.mail.ru [89.221.237.224]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5342B6ECE6 for ; Wed, 27 May 2026 12:54:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5342B6ECE6 Received: by exim-smtp-5b85998476-tb2gb with esmtpa (envelope-from ) id 1wSAy7-000000003Hv-1VJw; Wed, 27 May 2026 12:54:31 +0300 Content-Type: multipart/alternative; boundary="------------Gpon40sH5as90CBdqH2N0I9N" Message-ID: <2cb77f7b-40f1-4e97-8f8f-31a7dfedc167@tarantool.org> Date: Wed, 27 May 2026 12:54:30 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun References: <20260519123913.178775-1-skaplun@tarantool.org> <20260519123913.178775-2-skaplun@tarantool.org> <3703735e-192b-4e3f-8842-2cff7a61e725@tarantool.org> Content-Language: en-US In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD98DC58EE55F2C5C37B3A4B3A8651D40747F919B4CB67D6B7B00894C459B0CD1B9EF1ED26496ABFC20A6D5EE0DB6E1EC8D34156256D39E00E4F1754700D01C2302ACCB5262BB601CA2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE793ECC5BC4DAF6EC5EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FE9EFE935CD7C6AE8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2A8F778F70D5B98C82E070BE324C7D3C49916E017BB4B7FEFF6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249D082881546D93491CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0A29E2F051442AF778941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3517C622C16A6DF10089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A51EF0C6A805A36A325002B1117B3ED696FBBEF73C957B734C30E4A65F242F5898823CB91A9FED034534781492E4B8EEADDFC043C56F70D752BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADB58128AB1E6D661A716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659D4E20B0217142B0A5308F3A99FFF8B9D1671128774DDBA66750B178040D0F278B1FB521FE37583BBB8341EE9D5BE9A0AE2E7AEFF94C6E8178218B38FA18EA901E88D255B9ADA8352C7CEAA0681F5848F4C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVax5M0mESuWm2qgQBbRskyM= X-DA7885C5: 1708AD9A70EE410AF255D290C0D534F935F955A9F28481A1DFF652AE14EFAEB9C18217BCAEEA8BE45B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE23A0C42F99C24F7C053B96CAEDDB8C8D4E0B80F8E8ED12A4CEF86D5F70DA33880E41E8EF7A07863ECB274557F927329BE2DDF8182D28ACDB545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 1/6] test: introduce tests for debugging extensions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------Gpon40sH5as90CBdqH2N0I9N Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, Sergey, LGTM with a comment below. Sergey On 5/25/26 12:14, Sergey Kaplun wrote: >>> diff --git a/test/tarantool-debugger-tests/CMakeLists.txt b/test/tarantool-debugger-tests/CMakeLists.txt >>> new file mode 100644 >>> index 00000000..7fd0debc >>> --- /dev/null >>> +++ b/test/tarantool-debugger-tests/CMakeLists.txt >>> @@ -0,0 +1,93 @@ >>> +set(TEST_SUITE_NAME "tarantool-debugger-tests") >>> + >>> +# XXX: The call produces both test and target >>> +# as a side effect. >>> +add_test_suite_target(tarantool-debugger-tests >>> + LABELS ${TEST_SUITE_NAME} >>> + DEPENDS ${LUAJIT_TEST_BINARY} >>> +) >>> + >>> +# Debug info is required for testing of extensions. >>> +if(NOT (CMAKE_BUILD_TYPE MATCHES Debug)) >>> + message(WARNING >>> + "Not a DEBUG build, tarantool-debugger-tests is dummy" >>> + ) >> it is not dummy, it doesn't exist at all: >> >> cmake -S . -B build -DCMAKE_BUILD_TYPE=Release >> >> cd build >> >> make tarantool-debugger-tests >> make[3]: *** No rule to make target 'src/luajit', needed by >> 'test/tarantool-debugger-tests/CMakeFiles/tarantool-debugger-tests-deps'. >> Stop. > Replaced elsewhere with "omitted". =================================================================== > diff --git a/test/tarantool-debugger-tests/CMakeLists.txt > b/test/tarantool-debugger-tests/CMakeLists.txt index > 7fd0debc..a6684e72 100644 --- > a/test/tarantool-debugger-tests/CMakeLists.txt +++ > b/test/tarantool-debugger-tests/CMakeLists.txt @@ -10,7 +10,7 @@ > add_test_suite_target(tarantool-debugger-tests # Debug info is > required for testing of extensions. if(NOT (CMAKE_BUILD_TYPE MATCHES > Debug)) message(WARNING - "Not a DEBUG build, tarantool-debugger-tests is dummy" > + "Not a DEBUG build, tarantool-debugger-tests is omitted" > ) > return() > endif() > @@ -22,7 +22,7 @@ endif() > if(CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND DEFINED ENV{CI}) > message(WARNING > "Interactive debugging is unavailable for macOS CI builds," > - " tarantool-debugger-tests is dummy" > + " tarantool-debugger-tests is omitted" > ) > return() > endif() > @@ -31,13 +31,17 @@ if(CMAKE_VERSION VERSION_LESS "3.12") > #TODO:Can remove this after upgrading to CMake >= 3.12. > find_package(PythonInterp) > if(NOT PYTHONINTERP_FOUND) > - message(WARNING "`python` is not found, tarantool-debugger-tests is dummy") > + message(WARNING > + "`python` is not found, tarantool-debugger-tests is omitted" > + ) > return() > endif() > else() > find_package(Python COMPONENTS Interpreter) > if(NOT PYTHON_FOUND) > - message(WARNING "`python` is not found, tarantool-debugger-tests is dummy") > + message(WARNING > + "`python` is not found, tarantool-debugger-tests is omitted" > + ) > return() > endif() > set(PYTHON_EXECUTABLE "${Python_EXECUTABLE}") > =================================================================== Let's create a target after checking requirements: diff --git a/test/tarantool-debugger-tests/CMakeLists.txt b/test/tarantool-debugger-tests/CMakeLists.txt index 39414db3..ab90b803 100644 --- a/test/tarantool-debugger-tests/CMakeLists.txt +++ b/test/tarantool-debugger-tests/CMakeLists.txt @@ -1,12 +1,5 @@  set(TEST_SUITE_NAME "tarantool-debugger-tests") -# XXX: The call produces both test and target -# as a side effect. -add_test_suite_target(tarantool-debugger-tests -  LABELS ${TEST_SUITE_NAME} -  DEPENDS ${LUAJIT_TEST_BINARY} -) -  # Debug info is required for testing of extensions.  if(NOT (CMAKE_BUILD_TYPE MATCHES Debug))    message(WARNING @@ -47,6 +40,13 @@ else()    set(PYTHON_EXECUTABLE "${Python_EXECUTABLE}")  endif() +# XXX: The call produces both test and target +# as a side effect. +add_test_suite_target(tarantool-debugger-tests +  LABELS ${TEST_SUITE_NAME} +  DEPENDS ${LUAJIT_TEST_BINARY} +) +  set(DEBUGGER_TEST_ENV    "LUAJIT_TEST_BINARY=${LUAJIT_TEST_BINARY}"    # Suppresses __pycache__ generation. --------------Gpon40sH5as90CBdqH2N0I9N Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi, Sergey,

LGTM with a comment below.

Sergey

On 5/25/26 12:14, Sergey Kaplun wrote:

<snipped>

diff --git a/test/tarantool-debugger-tests/CMakeLists.txt b/test/tarantool-debugger-tests/CMakeLists.txt
new file mode 100644
index 00000000..7fd0debc
--- /dev/null
+++ b/test/tarantool-debugger-tests/CMakeLists.txt
@@ -0,0 +1,93 @@
+set(TEST_SUITE_NAME "tarantool-debugger-tests")
+
+# XXX: The call produces both test and target
+# <tarantool-debugger-tests-deps> as a side effect.
+add_test_suite_target(tarantool-debugger-tests
+  LABELS ${TEST_SUITE_NAME}
+  DEPENDS ${LUAJIT_TEST_BINARY}
+)
+
+# Debug info is required for testing of extensions.
+if(NOT (CMAKE_BUILD_TYPE MATCHES Debug))
+  message(WARNING
+    "Not a DEBUG build, tarantool-debugger-tests is dummy"
+  )

it is not dummy, it doesn't exist at all:

cmake -S . -B build -DCMAKE_BUILD_TYPE=Release

cd build

make tarantool-debugger-tests
make[3]: *** No rule to make target 'src/luajit', needed by 
'test/tarantool-debugger-tests/CMakeFiles/tarantool-debugger-tests-deps'. 
Stop.

Replaced elsewhere with "omitted".
===================================================================
diff --git a/test/tarantool-debugger-tests/CMakeLists.txt b/test/tarantool-debugger-tests/CMakeLists.txt
index 7fd0debc..a6684e72 100644
--- a/test/tarantool-debugger-tests/CMakeLists.txt
+++ b/test/tarantool-debugger-tests/CMakeLists.txt
@@ -10,7 +10,7 @@ add_test_suite_target(tarantool-debugger-tests
 # Debug info is required for testing of extensions.
 if(NOT (CMAKE_BUILD_TYPE MATCHES Debug))
   message(WARNING
-    "Not a DEBUG build, tarantool-debugger-tests is dummy"
+    "Not a DEBUG build, tarantool-debugger-tests is omitted"
   )
   return()
 endif()
@@ -22,7 +22,7 @@ endif()
 if(CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND DEFINED ENV{CI})
   message(WARNING
     "Interactive debugging is unavailable for macOS CI builds,"
-    " tarantool-debugger-tests is dummy"
+    " tarantool-debugger-tests is omitted"
   )
   return()
 endif()
@@ -31,13 +31,17 @@ if(CMAKE_VERSION VERSION_LESS "3.12")
   # TODO:Can remove this after upgrading to CMake >= 3.12.
   find_package(PythonInterp)
   if(NOT PYTHONINTERP_FOUND)
-    message(WARNING "`python` is not found, tarantool-debugger-tests is dummy")
+    message(WARNING
+      "`python` is not found, tarantool-debugger-tests is omitted"
+    )
     return()
   endif()
 else()
   find_package(Python COMPONENTS Interpreter)
   if(NOT PYTHON_FOUND)
-    message(WARNING "`python` is not found, tarantool-debugger-tests is dummy")
+    message(WARNING
+      "`python` is not found, tarantool-debugger-tests is omitted"
+    )
     return()
   endif()
   set(PYTHON_EXECUTABLE "${Python_EXECUTABLE}")
===================================================================

Let's create a target after checking requirements:

diff --git a/test/tarantool-debugger-tests/CMakeLists.txt b/test/tarantool-debugger-tests/CMakeLists.txt
index 39414db3..ab90b803 100644
--- a/test/tarantool-debugger-tests/CMakeLists.txt
+++ b/test/tarantool-debugger-tests/CMakeLists.txt
@@ -1,12 +1,5 @@
 set(TEST_SUITE_NAME "tarantool-debugger-tests")
 
-# XXX: The call produces both test and target
-# <tarantool-debugger-tests-deps> as a side effect.
-add_test_suite_target(tarantool-debugger-tests
-  LABELS ${TEST_SUITE_NAME}
-  DEPENDS ${LUAJIT_TEST_BINARY}
-)
-
 # Debug info is required for testing of extensions.
 if(NOT (CMAKE_BUILD_TYPE MATCHES Debug))
   message(WARNING
@@ -47,6 +40,13 @@ else()
   set(PYTHON_EXECUTABLE "${Python_EXECUTABLE}")
 endif()
 
+# XXX: The call produces both test and target
+# <tarantool-debugger-tests-deps> as a side effect.
+add_test_suite_target(tarantool-debugger-tests
+  LABELS ${TEST_SUITE_NAME}
+  DEPENDS ${LUAJIT_TEST_BINARY}
+)
+
 set(DEBUGGER_TEST_ENV
   "LUAJIT_TEST_BINARY=${LUAJIT_TEST_BINARY}"
   # Suppresses __pycache__ generation.

<snipped>


    

  
  


--------------Gpon40sH5as90CBdqH2N0I9N--