From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4DD366ECCC; Mon, 25 May 2026 10:01:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4DD366ECCC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1779692490; bh=nTF09WT6nOitFUfQh6C9M7G3ZEjpROWMaJRRkk7uPcU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=YfU9EMI7CdQ8BffwlWDQNfLjC2QWPQmbtlL9UjKpabxoEgsmoU/Nh0BGfwpcTXrXR EqjPmci/QpuQn0Rzx902zttlV59dVaA5V6SCI84DwVzc1r3ArByCK99XiXNv1PHRPT z4xdTJOCEQpGcaC5BEdRqcGeCeRa27ClRVMvSB1U= Received: from send174.i.mail.ru (send174.i.mail.ru [95.163.59.13]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AB3836ECCC for ; Mon, 25 May 2026 10:01:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AB3836ECCC Received: by exim-smtp-8466d5ddfc-g2b9b with esmtpa (envelope-from ) id 1wRPJX-00000000SAr-2Mn3; Mon, 25 May 2026 10:01:28 +0300 Date: Mon, 25 May 2026 10:00:50 +0300 To: Sergey Bronnikov Message-ID: References: <20260519123913.178775-1-skaplun@tarantool.org> <20260519123913.178775-7-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD98DC58EE55F2C5C3727C4554E5DD35F3CD4977B58BF78567F00894C459B0CD1B9A204C57FCB0EBB46EDF1CDDB2C83CE56D2DC58ED76197EB68F29CAC1FC0D896B4C6784DEA8096F07 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F65C230EDDCD559EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FE9EFE935CD7C6AE8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B269A903F389A16BA62E070BE324C7D3C4A55753B6F0132FC8F6B57BC7E64490618DEB871D839B73339E8FC8737B5C224952D31B9D28593E51CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C078FCF50C7EAF9C588941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C31C94431981024FA535872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A56327812436A18CE85002B1117B3ED696B077C7A64413C42903803A57F48E4E5A823CB91A9FED034534781492E4B8EEAD0AA277257C6A5E3DBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADB58128AB1E6D661A8E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6594186524140E24A7100D5F3E2C26862F6B48529544CBDC88C8B9EDD23B9F7F40700E5F8F9D1B86FD9B8341EE9D5BE9A0A18E7F850E526D1106B9FB07D8EBB2D55265C3B3F1F3A8376C7CEAA0681F5848F4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVax5M0mESuWm3QJ+JnGYNjQ= X-DA7885C5: A7EF311059E7F73DF255D290C0D534F999AC571A5B78D165AF5D94554C5B0A35E116B7C39BA482DF5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE2B224EC6F8BBE742ECB611BD91C70BE905669B69C9F6DC124E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 6/6] ci: introduce workflow to test debugger extension X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Please, consider my answers below. On 20.05.26, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! See my comments. > > Sergey > > On 5/19/26 15:39, Sergey Kaplun wrote: > > The debugger extension test is run for both LLDB and GDB for GC64 and > > non-GC64 builds for arm64 and x86_64. > > --- > > .github/actions/setup-debuggers/README.md | 13 +++++ > > .github/actions/setup-debuggers/action.yml | 12 +++++ > > .github/workflows/debuggers.yml | 61 ++++++++++++++++++++++ > > 3 files changed, 86 insertions(+) > > create mode 100644 .github/actions/setup-debuggers/README.md > > create mode 100644 .github/actions/setup-debuggers/action.yml > > create mode 100644 .github/workflows/debuggers.yml > > > > diff --git a/.github/actions/setup-debuggers/README.md b/.github/actions/setup-debuggers/README.md > > new file mode 100644 > > index 00000000..7c542ddb > > --- /dev/null > > +++ b/.github/actions/setup-debuggers/README.md > > @@ -0,0 +1,13 @@ > > +# Setup environment for testing debugger extension on Linux > > + > > +Action setups the environment on Linux runners (install requirements, setup the > > +workflow environment, etc.) for testing the python debugger extension for > > +various debuggers. > > + > > +## How to use Github Action from Github workflow > > + > > +Add the following code to the running steps before LuaJIT configuration: > > +``` > > +- uses: ./.github/actions/setup-debuggers > > + if: ${{ matrix.OS == 'Linux' }} > > +``` > > diff --git a/.github/actions/setup-debuggers/action.yml b/.github/actions/setup-debuggers/action.yml > > new file mode 100644 > > index 00000000..c34d4502 > > --- /dev/null > > +++ b/.github/actions/setup-debuggers/action.yml > > @@ -0,0 +1,12 @@ > > +name: Setup CI environment for testing the debugger extension > > +description: The Linux machine setup for tests of the debugger extension > > +runs: > > + using: composite > > + steps: > > + - name: Setup CI environment (Linux) > > + uses: ./.github/actions/setup-linux > > + - name: Install dependencies for the tests > > + run: | > > + apt -y update > > + apt install -y python3 gdb lldb > > Why Python 3 only? AFAIR we discussed that Python 2 should be supported > as well, > > it means we should test with Python 2 too. Python 2 can't be easily installed on modern Ubuntu since this package is removed due to its EOL. I tested GDB manually for ancient Python. I suppose we will implement it as is and fix bugs for Python 2 by demand. > > Also, should we test with the latest versions of GDB/LLDB? Does apt install not provide the latest version? > -- Best regards, Sergey Kaplun